From nobody Tue Feb 10 03:44:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1622048703; cv=none; d=zohomail.com; s=zohoarc; b=mUkl/FwybO+Km9GcQrp2r1wvO0wBqPz4oMGhqfiUFKSHnqtywIw2hvMyuKIaREFEjrI9aXCtB7ZKMm9q/EyQumSURf02zbBdFfaa02jadBjA/upPZ0Iq+BCaEWbGbpy04187UtcbtF7tJouNSwiDywQzFI2p6l7lE0KWdN+hhc8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622048703; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=3uXX+K1GXf7TrWdaqri3KbXM16p7ZXQ8jRKVT3E8l+g=; b=DXz5nGjVzG8nir4ymxm0pqywZAGiQ5QU0q2F1+uMjAtsmNYFD1ImN5Zg1cBipvrTiiyC1NCz8GmF+oVzUMTcATv1YqSFqKTF60J7NDzXh7MUuBj/PmFf03j7CC3ilPv6Mgmh+2peJRwTlvSW+2RXV70SyJao5oUJKeuapWWbexw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1622048703668191.311754181403; Wed, 26 May 2021 10:05:03 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-5WnnXMLWMJSoJ5Hm9YSPzg-1; Wed, 26 May 2021 13:05:01 -0400 Received: by mail-wm1-f71.google.com with SMTP id j71-20020a1c234a0000b0290192d5ad58d9so387670wmj.4 for ; Wed, 26 May 2021 10:05:00 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (64.red-88-10-103.dynamicip.rima-tde.net. [88.10.103.64]) by smtp.gmail.com with ESMTPSA id w12sm20326986wrt.16.2021.05.26.10.04.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 May 2021 10:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622048702; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3uXX+K1GXf7TrWdaqri3KbXM16p7ZXQ8jRKVT3E8l+g=; b=MADN760r1zlu8MIHaY+S0AJDP7SvM0xNcNuvLM0EKilnJ9MDNATV3ftLObVxbKs+al3/Z8 r3OWv8/r3lxbt+osjSX+3Fl31wSSK5RRAg8ig3kxTRAA+rBJkqSS05esh2gQ8WUT1aS2KV uouj9mIBNtheXxDZTsF77TyCjJHm3c4= X-MC-Unique: 5WnnXMLWMJSoJ5Hm9YSPzg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3uXX+K1GXf7TrWdaqri3KbXM16p7ZXQ8jRKVT3E8l+g=; b=byHUkIUgrvmY9dHeJwDgWzruRRWatxayjFns29tAZUnfEEbXvLnFL0K6QrAL4oAFA4 2PC2XtIOuXZO3HpIZrJZ5Z5InNndijFHTC4nDdoVgvwUQpiv9g+fzR0Dz1Empx7K7vqO IXdiv5CytRLn4jgzoGbgC5Z2x4jMf0lxamV370GnOSx6k7CorQtEXdxH6i++YwgzKSEj TKJhfva91bxsJyig9K7KdI6/fTM+l37/qubrMNVz31e5Kt/BEgOpNdWG9T13KXo0rqja 1uoEKfFTx+mdCtyM5VpimnJc5kDp/Ab1SzhNtYO0NDdKOkrNNrVLxPADA0xH64KY8q0Z y7bQ== X-Gm-Message-State: AOAM5315KKowAHaFeCGs2zxc4sPoZCoIwen7PBG3rKWihAgKXbP+EOGp faNuQg1mSv9T3O+/1tgN4Xi/dzBOJfRt2I3m19bfydK0QCS4sHHERvSbVeASs/TaI0EGlXag2zx 0OOVlAIK7Cr0csQ== X-Received: by 2002:adf:fa42:: with SMTP id y2mr33945023wrr.12.1622048699867; Wed, 26 May 2021 10:04:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1cnHw/E71Lh8KfQ4kl/CRqEG9TJdCE27goJKc5KOzwuECBffF+uGm07qXVlNgGBOvKjL72Q== X-Received: by 2002:adf:fa42:: with SMTP id y2mr33945011wrr.12.1622048699726; Wed, 26 May 2021 10:04:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, Eric Blake , Markus Armbruster , Richard Henderson , Eduardo Habkost , Paolo Bonzini , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= , John Snow , Marcel Apfelbaum Subject: [PATCH v8 02/12] accel: Introduce 'query-accels' QMP command Date: Wed, 26 May 2021 19:04:22 +0200 Message-Id: <20210526170432.343588-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210526170432.343588-1-philmd@redhat.com> References: <20210526170432.343588-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Introduce the 'query-accels' QMP command which returns a list of built-in accelerator names. - Accelerator is a QAPI enum of all existing accelerators, - AcceleratorInfo is a QAPI structure providing accelerator specific information. Currently the common structure base provides the name of the accelerator, while the specific part is empty, but each accelerator can expand it. - 'query-accels' QMP command returns a list of @AcceleratorInfo For example on a KVM-only build we get: { "execute": "query-accels" } { "return": [ { "name": "qtest" }, { "name": "kvm" } ] } Reviewed-by: Eric Blake Reviewed-by: Alex Benn=C3=A9e Tested-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Markus Armbruster --- v8: - Include code snippet from Markus adding to machine-target.json to be able to use enum values or union branches conditional. - Use accel_find() on enum to be sure the accelerator is enabled at runtime (chat with jsnow / eblake). Cc: Eric Blake Cc: John Snow Cc: Markus Armbruster --- qapi/machine-target.json | 54 ++++++++++++++++++++++++++++++++++++++++ accel/accel-qmp.c | 32 ++++++++++++++++++++++++ accel/meson.build | 2 +- 3 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 accel/accel-qmp.c diff --git a/qapi/machine-target.json b/qapi/machine-target.json index e7811654b72..586a61b5d99 100644 --- a/qapi/machine-target.json +++ b/qapi/machine-target.json @@ -329,3 +329,57 @@ ## { 'command': 'query-cpu-definitions', 'returns': ['CpuDefinitionInfo'], 'if': 'defined(TARGET_PPC) || defined(TARGET_ARM) || defined(TARGET_I386= ) || defined(TARGET_S390X) || defined(TARGET_MIPS)' } + +## +# @Accelerator: +# +# An enumeration of accelerator names. +# +# Since: 6.1 +## +{ 'enum': 'Accelerator', + 'data': [ + { 'name': 'hax', 'if': 'defined(CONFIG_HAX)' }, + { 'name': 'hvf', 'if': 'defined(CONFIG_HVF)' }, + { 'name': 'kvm', 'if': 'defined(CONFIG_KVM)' }, + { 'name': 'qtest' }, + { 'name': 'tcg', 'if': 'defined(CONFIG_TCG)' }, + { 'name': 'whpx', 'if': 'defined(CONFIG_WHPX)' }, + { 'name': 'xen', 'if': 'defined(CONFIG_XEN_BACKEND)' } ] } + +## +# @AcceleratorInfo: +# +# Accelerator information. +# +# @name: The accelerator name. +# +# Since: 6.1 +## +{ 'struct': 'AcceleratorInfo', + 'data': { 'name': 'Accelerator' } } + +## +# @query-accels: +# +# Get a list of AcceleratorInfo for all built-in accelerators. +# +# Returns: a list of @AcceleratorInfo describing each accelerator. +# +# Since: 6.1 +# +# Example: +# +# -> { "execute": "query-accels" } +# <- { "return": [ +# { +# "name": "qtest" +# }, +# { +# "name": "kvm" +# } +# ] } +# +## +{ 'command': 'query-accels', + 'returns': ['AcceleratorInfo'] } diff --git a/accel/accel-qmp.c b/accel/accel-qmp.c new file mode 100644 index 00000000000..0098297caa5 --- /dev/null +++ b/accel/accel-qmp.c @@ -0,0 +1,32 @@ +/* + * QEMU accelerators, QMP commands + * + * Copyright (c) 2021 Red Hat Inc. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "qemu/accel.h" +#include "qapi/qapi-types-machine-target.h" +#include "qapi/qapi-commands-machine-target.h" + +AcceleratorInfoList *qmp_query_accels(Error **errp) +{ + AcceleratorInfoList *list =3D NULL, **tail =3D &list; + + for (Accelerator accel =3D 0; accel < ACCELERATOR__MAX; accel++) { + AcceleratorInfo *info; + + if (!accel_find(Accelerator_str(accel))) { + /* Accelerator available at build time but not at runtime. */ + continue; + } + + info =3D g_new0(AcceleratorInfo, 1); + info->name =3D accel; + QAPI_LIST_APPEND(tail, info); + } + + return list; +} diff --git a/accel/meson.build b/accel/meson.build index b44ba30c864..7a48f6d568d 100644 --- a/accel/meson.build +++ b/accel/meson.build @@ -1,4 +1,4 @@ -specific_ss.add(files('accel-common.c')) +specific_ss.add(files('accel-common.c', 'accel-qmp.c')) softmmu_ss.add(files('accel-softmmu.c')) user_ss.add(files('accel-user.c')) =20 --=20 2.26.3