From nobody Tue Dec 16 12:35:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1622020471; cv=none; d=zohomail.com; s=zohoarc; b=kncf6wtoic9oL3lFkaNnMRnPlsm1zQ/p4eVbiQH6yu4ydKFNtjx+8UJOgSVwovGUQtEVxgGKfjU1NhQ7FXIT5QzMypTT97zew/dYlkqDAOnlpO0QK3zGzsruyle2UUI1rqlfNrFAyS8g6geRkdemDQ4zkBWPc+/LoxR8M/3hxLI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1622020471; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OjzrBE27jlzhMuAkjUiyZ08J6x+y8wyOEtbfqNd9XZ4=; b=WPUWTkcpvuQ/Pqugf5vk1NGBfA2DH3mr+KVpqeX//B4JA1uB9oZIKZpbiwCRXKBE7MraEtMS3kVN4f5EVE21tzYPNvka69XtynnPLwLR2u5OFC56Sik5AO96S/7ZRyYqV4SAQJnedn+YzAwaCI9pevDZnMchyd1GqoE2Eg1udEs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1622020471529944.2954919226528; Wed, 26 May 2021 02:14:31 -0700 (PDT) Received: from localhost ([::1]:39782 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llpcU-0003Na-Gl for importer@patchew.org; Wed, 26 May 2021 05:14:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55518) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llpbF-0001pW-1L for qemu-devel@nongnu.org; Wed, 26 May 2021 05:13:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36550) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llpbB-0001AH-T5 for qemu-devel@nongnu.org; Wed, 26 May 2021 05:13:12 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-Cxo4bY3VMzOUuwqnrHiLJw-1; Wed, 26 May 2021 05:13:07 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 604A7801B13; Wed, 26 May 2021 09:13:06 +0000 (UTC) Received: from localhost (ovpn-115-80.ams2.redhat.com [10.36.115.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 046E35D9D3; Wed, 26 May 2021 09:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622020389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OjzrBE27jlzhMuAkjUiyZ08J6x+y8wyOEtbfqNd9XZ4=; b=ZwOnPL24s48teRPVYhiGnlcceu1lAP31sOZJXXdO9nYklEXDCleLK7YWmVG5gW9lsxcno5 jbfA7QKGtsiSa5Ys3DksynQyd5AMrBuvPn+uohRTlnnNBo2R2ABmOGUM6Vw42dKwGQ3dFn P2A0YY9Ovn5gyAJQ2JQlNZI5vqde+VA= X-MC-Unique: Cxo4bY3VMzOUuwqnrHiLJw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 2/3] vhost-user-blk-test: fix Coverity mkstemp(2) umask warning Date: Wed, 26 May 2021 10:12:47 +0100 Message-Id: <20210526091248.434459-3-stefanha@redhat.com> In-Reply-To: <20210526091248.434459-1-stefanha@redhat.com> References: <20210526091248.434459-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Kevin Wolf , Thomas Huth , qemu-block@nongnu.org, Coiby Xu , Gerd Hoffmann , Stefan Hajnoczi , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The Linux man page for mkstemp(3) states: In glibc versions 2.06 and earlier, the file is created with permissions 0666, that is, read and write for all users. This old behavior may be a security risk, especially since other UNIX flavors use 0600, and somebody might overlook this detail when porting programs. POSIX.1-2008 adds a requirement that the file be created with mode 0600. More generally, the POSIX specification of mkstemp() does not say anything about file modes, so the application should make sure its file mode creation mask (see umask(2)) is set appropriately before calling mkstemp() (and mkostemp()). glibc 2.0.6 was released in 1997 and POSIX caught up in 2008. macOS and FreeBSD also use POSIX-compliant 0600 permissions. At this point the Coverity warning seems archaic and no longer useful, but go ahead and silence it. *** CID 1453267: Security best practices violations (SECURE_TEMP) /qemu/tests/qtest/vhost-user-blk-test.c: 827 in create_listen_socket() 821 { 822 int tmp_fd; 823 char *path; 824 825 /* No race because our pid makes the path unique */ 826 path =3D g_strdup_printf("/tmp/qtest-%d-sock.XXXXXX", getpid()); >>> CID 1453267: Security best practices violations (SECURE_TEMP) >>> Calling "mkstemp" without securely setting umask first. 827 tmp_fd =3D mkstemp(path); 828 g_assert_cmpint(tmp_fd, >=3D, 0); 829 close(tmp_fd); 830 unlink(path); 831 832 *fd =3D qtest_socket_server(path); Signed-off-by: Stefan Hajnoczi --- tests/qtest/vhost-user-blk-test.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/tests/qtest/vhost-user-blk-test.c b/tests/qtest/vhost-user-blk= -test.c index 581e283a03..412e010db8 100644 --- a/tests/qtest/vhost-user-blk-test.c +++ b/tests/qtest/vhost-user-blk-test.c @@ -803,11 +803,16 @@ static void destroy_file(void *path) static char *drive_create(void) { int fd, ret; + mode_t old_umask; /** vhost-user-blk won't recognize drive located in /tmp */ char *t_path =3D g_strdup("qtest.XXXXXX"); =20 /** Create a temporary raw image */ + old_umask =3D umask(S_IXUSR | + S_IRGRP | S_IWGRP | S_IXGRP | + S_IROTH | S_IWOTH | S_IXOTH); fd =3D mkstemp(t_path); + umask(old_umask); g_assert_cmpint(fd, >=3D, 0); ret =3D ftruncate(fd, TEST_IMAGE_SIZE); g_assert_cmpint(ret, =3D=3D, 0); @@ -821,10 +826,15 @@ static char *create_listen_socket(int *fd) { int tmp_fd; char *path; + mode_t old_umask; =20 /* No race because our pid makes the path unique */ path =3D g_strdup_printf("/tmp/qtest-%d-sock.XXXXXX", getpid()); + old_umask =3D umask(S_IXUSR | + S_IRGRP | S_IWGRP | S_IXGRP | + S_IROTH | S_IWOTH | S_IXOTH); tmp_fd =3D mkstemp(path); + umask(old_umask); g_assert_cmpint(tmp_fd, >=3D, 0); close(tmp_fd); unlink(path); --=20 2.31.1