From nobody Thu Dec 18 19:36:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1621957282; cv=none; d=zohomail.com; s=zohoarc; b=O1RXUydQK3g2to2m63bdo1rGiz2z6UIJYVKV1JP9VBzxPWRY3kcoajQOqPqhlxNi8cE0dLZNM2L5FJRSRd7HbNAAt65b9L6rKMKy0z11505MKgjV6sLsjSf1ftUCUrjOdc2KiugHksrCTLYf0Ztx+CBma4cef0xQBtKDtm/EjXw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621957282; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sODj0LMpLo51Qf4P152XQ6CbBYrCTxrIYP5T7eUUPm4=; b=d4uN3AO1oAoS5Mplek5TIF53A9ahO6LkDXwvrC5NDsUg3qzbDGr8k/t+wdtwWnrGdGh3d4GOpcmZ+xlqGW25spPLLSAWsd/Q7u8AF7RGIkB8n3MM27WV3K5TQBG/Oc8o6y7fxvYScXg/yakq7rWxFtIuRKhMGDZUyxzkskyWKPE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621957282342717.5174847755491; Tue, 25 May 2021 08:41:22 -0700 (PDT) Received: from localhost ([::1]:54780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llZBJ-00062S-Cg for importer@patchew.org; Tue, 25 May 2021 11:41:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llYbO-00035Y-5d for qemu-devel@nongnu.org; Tue, 25 May 2021 11:04:14 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:43870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llYbC-0004KX-HM for qemu-devel@nongnu.org; Tue, 25 May 2021 11:04:13 -0400 Received: by mail-wm1-x32f.google.com with SMTP id z85-20020a1c7e580000b029017a76f3afbaso10479489wmc.2 for ; Tue, 25 May 2021 08:04:00 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id q62sm11710284wma.42.2021.05.25.08.03.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 08:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=sODj0LMpLo51Qf4P152XQ6CbBYrCTxrIYP5T7eUUPm4=; b=qsr24pFl51evccrEOVrJtnVRcenciYOv9XbIptZ4k9qdCWV0mQ2ZbbehdMsCDUytN2 BEuarDokz/fG0vHgs4d3MqO4Jg4jHmsszpHt7P+2XYXWXuY8fvG6LGRUB0b4gk+L0QsC QzGT0Ou2gjI//6fseqEhxowMSC5LGyBEnyOgNR/R3IXgL09HjSdesABJe6WiEmKnwF+w pUFeCSdfK/Taqm1ooTb5QTF/SYMJV979Z7cWzBo0mQ1CuULHBghK2sMN6YStcYgzZIYk 9/gKXvP6TGfEoFkluLZAQuTNq0behB+Wy9/BN7uLcI/fiVBKmjveyWBZBgqExs+QC5j4 AauA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sODj0LMpLo51Qf4P152XQ6CbBYrCTxrIYP5T7eUUPm4=; b=VFTaYm0cteQrr7jHblcU8aLWaf79ZStv0pmFUMho/9j9P4WqHpJnToR+bxv97Y4Ymf Ah5xCfL4qlYuPXkekLNPcDhlYregK/V04Wez/arCwJQvhtMxB0rPCLrJTFs3wthrZ+Jb tGKlnEcG2dt+S63LSCyS8FvH5UYAmm7KydnLO6bHWiLk7eVTCiIBiDWgYuIgXQL3yYQl ZRz2vW/THbol8FLo1gc6QccRovyPkre/lHUheTefgBBEI+7nF7Kj6I2E2jPDRY9MO6mt I+oX7xRC9Djm4SikGz+e7AzQ5xe1H7Vbfr04PC+vO8pO4ytjKjg8lH9SCQgXNbdYYOYo CgLA== X-Gm-Message-State: AOAM532j8B6Q58xTpuDoKsNeSz31fMTARlKUonnnDcniMBpT2uDRfzzX zafot8v5aZWrTbC+MbTdWuJos62cZEyBdk+p X-Google-Smtp-Source: ABdhPJxqgVjHV+1bYQbSr5fv9hVuwLu9uH60bmbqXxdwCOKzcNPUXGhSkZR5/xTYgCr3e9HPQyswTQ== X-Received: by 2002:a1c:9dc6:: with SMTP id g189mr4338149wme.59.1621955039317; Tue, 25 May 2021 08:03:59 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 036/114] target/arm: Implement SVE2 PMULLB, PMULLT Date: Tue, 25 May 2021 16:02:06 +0100 Message-Id: <20210525150324.32370-37-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210525150324.32370-1-peter.maydell@linaro.org> References: <20210525150324.32370-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20210525010358.152808-15-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/cpu.h | 10 ++++++++++ target/arm/helper-sve.h | 1 + target/arm/sve.decode | 2 ++ target/arm/translate-sve.c | 22 ++++++++++++++++++++++ target/arm/vec_helper.c | 24 ++++++++++++++++++++++++ 5 files changed, 59 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index b7ce3b1e89b..6e149d8349a 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -4241,6 +4241,16 @@ static inline bool isar_feature_aa64_sve2(const ARMI= SARegisters *id) return FIELD_EX64(id->id_aa64zfr0, ID_AA64ZFR0, SVEVER) !=3D 0; } =20 +static inline bool isar_feature_aa64_sve2_aes(const ARMISARegisters *id) +{ + return FIELD_EX64(id->id_aa64zfr0, ID_AA64ZFR0, AES) !=3D 0; +} + +static inline bool isar_feature_aa64_sve2_pmull128(const ARMISARegisters *= id) +{ + return FIELD_EX64(id->id_aa64zfr0, ID_AA64ZFR0, AES) >=3D 2; +} + /* * Feature tests for "does this exist in either 32-bit or 64-bit?" */ diff --git a/target/arm/helper-sve.h b/target/arm/helper-sve.h index ad8121eec6a..bf3e533eb4f 100644 --- a/target/arm/helper-sve.h +++ b/target/arm/helper-sve.h @@ -2363,3 +2363,4 @@ DEF_HELPER_FLAGS_4(sve2_umull_zzz_s, TCG_CALL_NO_RWG,= void, ptr, ptr, ptr, i32) DEF_HELPER_FLAGS_4(sve2_umull_zzz_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr,= i32) =20 DEF_HELPER_FLAGS_4(sve2_pmull_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) +DEF_HELPER_FLAGS_4(sve2_pmull_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) diff --git a/target/arm/sve.decode b/target/arm/sve.decode index d9a72b7661c..016c15ebb67 100644 --- a/target/arm/sve.decode +++ b/target/arm/sve.decode @@ -1201,6 +1201,8 @@ USUBWT 01000101 .. 0 ..... 010 111 ..... ...= .. @rd_rn_rm =20 SQDMULLB_zzz 01000101 .. 0 ..... 011 000 ..... ..... @rd_rn_rm SQDMULLT_zzz 01000101 .. 0 ..... 011 001 ..... ..... @rd_rn_rm +PMULLB 01000101 .. 0 ..... 011 010 ..... ..... @rd_rn_rm +PMULLT 01000101 .. 0 ..... 011 011 ..... ..... @rd_rn_rm SMULLB_zzz 01000101 .. 0 ..... 011 100 ..... ..... @rd_rn_rm SMULLT_zzz 01000101 .. 0 ..... 011 101 ..... ..... @rd_rn_rm UMULLB_zzz 01000101 .. 0 ..... 011 110 ..... ..... @rd_rn_rm diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 19a1f289d8a..fbdccc1c680 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -6030,6 +6030,28 @@ DO_SVE2_ZZZ_TB(SMULLT_zzz, smull_zzz, true, true) DO_SVE2_ZZZ_TB(UMULLB_zzz, umull_zzz, false, false) DO_SVE2_ZZZ_TB(UMULLT_zzz, umull_zzz, true, true) =20 +static bool do_trans_pmull(DisasContext *s, arg_rrr_esz *a, bool sel) +{ + static gen_helper_gvec_3 * const fns[4] =3D { + gen_helper_gvec_pmull_q, gen_helper_sve2_pmull_h, + NULL, gen_helper_sve2_pmull_d, + }; + if (a->esz =3D=3D 0 && !dc_isar_feature(aa64_sve2_pmull128, s)) { + return false; + } + return do_sve2_zzw_ool(s, a, fns[a->esz], sel); +} + +static bool trans_PMULLB(DisasContext *s, arg_rrr_esz *a) +{ + return do_trans_pmull(s, a, false); +} + +static bool trans_PMULLT(DisasContext *s, arg_rrr_esz *a) +{ + return do_trans_pmull(s, a, true); +} + #define DO_SVE2_ZZZ_WTB(NAME, name, SEL2) \ static bool trans_##NAME(DisasContext *s, arg_rrr_esz *a) \ { \ diff --git a/target/arm/vec_helper.c b/target/arm/vec_helper.c index 40b92100bf3..b0ce597060d 100644 --- a/target/arm/vec_helper.c +++ b/target/arm/vec_helper.c @@ -1750,6 +1750,30 @@ void HELPER(sve2_pmull_h)(void *vd, void *vn, void *= vm, uint32_t desc) d[i] =3D pmull_h(nn, mm); } } + +static uint64_t pmull_d(uint64_t op1, uint64_t op2) +{ + uint64_t result =3D 0; + int i; + + for (i =3D 0; i < 32; ++i) { + uint64_t mask =3D -((op1 >> i) & 1); + result ^=3D (op2 << i) & mask; + } + return result; +} + +void HELPER(sve2_pmull_d)(void *vd, void *vn, void *vm, uint32_t desc) +{ + intptr_t sel =3D H4(simd_data(desc)); + intptr_t i, opr_sz =3D simd_oprsz(desc); + uint32_t *n =3D vn, *m =3D vm; + uint64_t *d =3D vd; + + for (i =3D 0; i < opr_sz / 8; ++i) { + d[i] =3D pmull_d(n[2 * i + sel], m[2 * i + sel]); + } +} #endif =20 #define DO_CMP0(NAME, TYPE, OP) \ --=20 2.20.1