From nobody Mon Feb 9 06:00:46 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621530545; cv=none; d=zohomail.com; s=zohoarc; b=SdXchrOSxZdqAyt2rrB4WSrB+mLdGIb7Btz5k1O7evAecC2AdXPrU/wESxqvg/LRErcYjcuAJ8LIxXmzByf4EFPwYHt2zcuDvH/hDb/BylVPMbwpsFzWwlvGTwv0M2o5ZrL2yIhySmat6ZJENqCnj5IkDJQjyrPZV0haYk7C8Bs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621530545; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9eVSHhnlZ1XejkdF0IqqJB91nZk1tTrfzmjT7Kiy3ys=; b=ZKMDonY79xB7KCu9lThgxGEeVxanlA23H8O8+iu4PDPnuQ8OJg8c6QcilUNdstlV1EjkCrMncniBXtkB+Kbic61UwbBiWoVP9lIxil1WfA1DxGvsNF8vUAw7Hun8x5RKsbbMBd3N8cVHd3+to0CCxPR7KrOwR/9NCoQ8mHFU9Bk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621530545292868.0203234540595; Thu, 20 May 2021 10:09:05 -0700 (PDT) Received: from localhost ([::1]:33720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljmAS-000121-9s for importer@patchew.org; Thu, 20 May 2021 13:09:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljm7E-0001Ut-IZ for qemu-devel@nongnu.org; Thu, 20 May 2021 13:05:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35332) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljm76-0005an-VM for qemu-devel@nongnu.org; Thu, 20 May 2021 13:05:41 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-347-VC4qglK0P1KiCoqGt1zvzg-1; Thu, 20 May 2021 13:05:34 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EF73D802575; Thu, 20 May 2021 17:05:32 +0000 (UTC) Received: from gondolin.fritz.box (ovpn-113-166.ams2.redhat.com [10.36.113.166]) by smtp.corp.redhat.com (Postfix) with ESMTP id A5C5B5D6D5; Thu, 20 May 2021 17:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621530336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9eVSHhnlZ1XejkdF0IqqJB91nZk1tTrfzmjT7Kiy3ys=; b=Bu0wIPBbGU3i678ZOj90jzK/3cQxryWuctxw7yfkQjklwGKqwpX4yPpc1hoHrTlpOr1fO8 MXUnbsJTHVmUTa1/NipFwuVBPr5uiNZoBk/Qdfv+C+CyaBkFE4GxcPnb1M7y1+BCxslV0Y eA4O4uJIJ6OgY6fMPnSpIlZKwN+p/GA= X-MC-Unique: VC4qglK0P1KiCoqGt1zvzg-1 From: Cornelia Huck To: Peter Maydell Subject: [PULL v2 2/9] target/arm: Make sure that commpage's tb->size != 0 Date: Thu, 20 May 2021 19:05:12 +0200 Message-Id: <20210520170519.300951-3-cohuck@redhat.com> In-Reply-To: <20210520170519.300951-1-cohuck@redhat.com> References: <20210520170519.300951-1-cohuck@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-s390x@nongnu.org, Cornelia Huck , Richard Henderson , qemu-devel@nongnu.org, Ilya Leoshkevich Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Ilya Leoshkevich tb_gen_code() assumes that tb->size must never be zero, otherwise it may produce spurious exceptions. For ARM this may happen when creating a translation block for the commpage. Fix by pretending that commpage translation blocks have at least one instruction. Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20210416154939.32404-3-iii@linux.ibm.com> Signed-off-by: Cornelia Huck --- target/arm/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/translate.c b/target/arm/translate.c index 455352bcf60f..8e0e55c1e0f5 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -8981,6 +8981,7 @@ static void arm_tr_translate_insn(DisasContextBase *d= cbase, CPUState *cpu) unsigned int insn; =20 if (arm_pre_translate_insn(dc)) { + dc->base.pc_next +=3D 4; return; } =20 @@ -9050,6 +9051,7 @@ static void thumb_tr_translate_insn(DisasContextBase = *dcbase, CPUState *cpu) bool is_16bit; =20 if (arm_pre_translate_insn(dc)) { + dc->base.pc_next +=3D 2; return; } =20 --=20 2.31.1