From nobody Fri Dec 19 07:15:31 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621509014; cv=none; d=zohomail.com; s=zohoarc; b=h1+CEvcrbOH4sFKuHFw+tMoSwCkn8XJv5mQfVr9H4uZFp3iNnPZSNvuONMGaIivdUuxeQSP8094a4NL5vs7rPpRucGhX/2tbk7gIlPXxPSAJgpXPa1w3JhFU6VXgMUuSXLl9PvZfOKzWGb3jzaIIxWkC63VpvkHRXPHgPohl95k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621509014; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=hT9YCxRj1ou3uPTM7bSJ+zjEyH6kGbopTpVH+99i5eA=; b=TRcW6QRdd7Fwrawzjs9LuUq0IQdof+4q74PwKgMR/Rt2HsRXspKsfRSfiOB2Q0GoGZjgXjHm+6CsfSDll1cf2k2Fec/zRTwEQy7d03OTsIhSRhwlnACXNQhAfJZVpn/DL56preoMUvBoglClTpoRPCB7Y547o5qbD8eG+9IyQbc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1621509014709929.2536681533354; Thu, 20 May 2021 04:10:14 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-_THqcu1dPky5pYOT91ePFQ-1; Thu, 20 May 2021 07:10:12 -0400 Received: by mail-wr1-f69.google.com with SMTP id 67-20020adf81490000b029010756d109e6so8435359wrm.13 for ; Thu, 20 May 2021 04:10:11 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id f13sm3010371wrt.86.2021.05.20.04.10.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 May 2021 04:10:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621509013; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hT9YCxRj1ou3uPTM7bSJ+zjEyH6kGbopTpVH+99i5eA=; b=HO9dqijb1Yl9a/WJpsVFU5iPlOono3NyxdBfp8uTxmH7iQzRRCXm96tghZW1eNvlev5eFk Q1aqkIS7UlG0PWsJJoEemDT6JDaRpriA1zY4I38kQuVIf/n2Pru1W+hDXVnPEzs+08CWbv FTz3rcSKqLR30UMXml3C5U9FDG3w2f0= X-MC-Unique: _THqcu1dPky5pYOT91ePFQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hT9YCxRj1ou3uPTM7bSJ+zjEyH6kGbopTpVH+99i5eA=; b=lRffBMQ+9YUGxNZPjbiG9ySzZviZsJyZXJDT+3Xgy6FH8OT+rdk9LNkYgAbb2C5YG2 fsgWdjcyZn5aS8xEfP8b5mCyCxijF5xp71uwqY78PIlozLRC/05IR66/o4kW98Bncp+6 +SaDMBdZ9oNbKVTr8WEc6xCdjKiNu5tUSHwZUlb4dNOST19eraNC6A3NAyAsZdvTfOLF sU1Ccwp+t6N7tzE15MEsA2imily+ORS7leyBfCmzlldPvjYW0+mh9PzWMFFuCeqQ3Ado ZgKB0rvIFXWfqR4XrZrIHxEZWSJ/1OuNplu4NzgWwuGLLD7aCEX75VvKdox4Qvjc8JIU jW2A== X-Gm-Message-State: AOAM5301jNwojWi58dLpDK8zd7nSZMcTKUO7hjv9L2CqG51Dh9KKbS2X QyOk5NT1T+pNJrU2d73QlQMkcsn31/xvqTuq/pX0DT1yE3CHsFxLU5RXPZX+pvTu5rvXJkRFwEy UcoVeJJ3DkFc1yA== X-Received: by 2002:a05:600c:1909:: with SMTP id j9mr3175846wmq.100.1621509010984; Thu, 20 May 2021 04:10:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNpo4h4UrADIjXZ1b95pgvWd070pZ4FEyaaomJsGttuRFQyMPcbIM8LWkbeqgCSQnyXkoUtA== X-Received: by 2002:a05:600c:1909:: with SMTP id j9mr3175822wmq.100.1621509010775; Thu, 20 May 2021 04:10:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Stefan Hajnoczi , Peter Maydell , Peter Xu , Paolo Bonzini , Richard Henderson , Bibo Mao , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH 11/12] hw/virtio: Have vring_avail_flags() return a boolean value Date: Thu, 20 May 2021 13:09:18 +0200 Message-Id: <20210520110919.2483190-12-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210520110919.2483190-1-philmd@redhat.com> References: <20210520110919.2483190-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) To be able to check the memory transaction succeeded, change the vring_avail_flags() to take the value to read by argument, so we can return a boolean whether we succeeded or not. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/virtio.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index e02544b2df7..1b8bc194ce1 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -287,16 +287,19 @@ static VRingMemoryRegionCaches *vring_get_region_cach= es(struct VirtQueue *vq) } =20 /* Called within rcu_read_lock(). */ -static inline uint16_t vring_avail_flags(VirtQueue *vq) +static inline bool vring_avail_flags(VirtQueue *vq, uint16_t *val) { VRingMemoryRegionCaches *caches =3D vring_get_region_caches(vq); hwaddr pa =3D offsetof(VRingAvail, flags); =20 if (!caches) { - return 0; + *val =3D 0; + return true; } =20 - return virtio_lduw_phys_cached(vq->vdev, &caches->avail, pa); + *val =3D virtio_lduw_phys_cached_with_attrs(vq->vdev, &caches->avail, = pa); + + return true; } =20 /* Called within rcu_read_lock(). */ @@ -2462,7 +2465,9 @@ static bool virtio_split_should_notify(VirtIODevice *= vdev, VirtQueue *vq) } =20 if (!virtio_vdev_has_feature(vdev, VIRTIO_RING_F_EVENT_IDX)) { - return !(vring_avail_flags(vq) & VRING_AVAIL_F_NO_INTERRUPT); + uint16_t flags; + return vring_avail_flags(vq, &flags) + && !(flags & VRING_AVAIL_F_NO_INTERRUPT); } =20 v =3D vq->signalled_used_valid; --=20 2.26.3