From nobody Tue May 14 23:19:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621493346; cv=none; d=zohomail.com; s=zohoarc; b=XLqt/LnZKdz5DhtGRQ8Rga62N3XgneNcPzsQVoHcZ8wmS/B2xEfMkag+J0mvCBcAXDOpS4j4w1Nda7FhU/0qheyFtJC8ka1YRoEh1lqxMwTQ5jMp9qGPrnUZkKSxlwe/SfktMHyWh3TC5l1DrLo6jdAfTcK+HD8u1Ze1X12K/Ek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621493346; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=Qb2jTKgpI/8jzWMA/fGcIeY07/BtSeOxotYpWWJgiMA=; b=Zy8rbXkJJj9TFpLhJTLQH99gadDzVJpQ15fH9xTIgQNtSc5As9jmLhqauIiz3gXLha0XmgSrXD9uAifSv7wrJR5uK0J6nA21T5loFnb2hPDh9hcNapdEpAu6WovUfsiPXPQZ+KWHzKpo6Caer4DqtZ0sFmlddfQiGuiPnhHszDk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621493346436237.99167849434752; Wed, 19 May 2021 23:49:06 -0700 (PDT) Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-N6WjDz0YNbqwxpWMFAQtgA-1; Thu, 20 May 2021 02:49:03 -0400 Received: by mail-wr1-f70.google.com with SMTP id 7-20020adf95070000b02901104ad3ef04so8275233wrs.16 for ; Wed, 19 May 2021 23:49:03 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id u126sm9580157wmb.9.2021.05.19.23.49.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 23:49:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621493345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Qb2jTKgpI/8jzWMA/fGcIeY07/BtSeOxotYpWWJgiMA=; b=W0udbSbZ7Tq4VPP88lfpnrL+l54x0DBrLf4tEvB1nPq8Y25VbIfZlsosQnJ+IoBhQNhsBV bgPW2DUUHCbUh1A4Tch0JqJFgCiYWmqfW/qV16g0n75hfX6oLTU+c9T2Kk8ZPRbC49RNFe zn2srKl+fl1xYJb29Yz/IPRW8Hkn8Ck= X-MC-Unique: N6WjDz0YNbqwxpWMFAQtgA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Qb2jTKgpI/8jzWMA/fGcIeY07/BtSeOxotYpWWJgiMA=; b=cCtx1wUEkMY+c+jhSkId8UeBXi5uoSCA+ozMLqNk7lbysRxlcOWUsojb6LMtVqE9Xx 2ytzum/kXLPS5zal4NTXYhUeR5WTLEdjsf9GNYAOobSBVxFB8zBlslh7eBG+pkbh4K2L CRjkvcq3lPSwzRataQbkWzt7uqbVzY5PyoZ2r+oxsMXt6LCToggORQd8e6EYa7o0uh3p +utEPQWURzbQDSWSOTLs2yoYe5yYg9ZFTBYYuDtw+MuNo6R1RMYbrS8LH30+QaXwl3HH QG6GayiuMHoOS6fZyRjZW7aQf4GcBAcS7iBCuF9H8+6SqKTwCfVKoBrQgOlQZsq8p1+w ZFbA== X-Gm-Message-State: AOAM532XhMGPKwMbcWX0Aek/Xu6i18/vX0R/mNBR6OEPeSA+pEEo7ke+ Wkocqec6u6dfQ/IotJIfyo7LjmPoEsFbff8xE3GPzm/1/J4sM5rpAhIEJjm3111Msp69PHspwJZ +kerFPqMXGtcGAg== X-Received: by 2002:a5d:638b:: with SMTP id p11mr2598941wru.90.1621493342489; Wed, 19 May 2021 23:49:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxglwyztEVEdE7RE97jv69WDujaCXZDD23lEnshfpec5hG0doeGDUiwGAL4x6ES7ZT4n/UPJg== X-Received: by 2002:a5d:638b:: with SMTP id p11mr2598931wru.90.1621493342351; Wed, 19 May 2021 23:49:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/virtio: Document *_should_notify() are called within rcu_read_lock() Date: Thu, 20 May 2021 08:49:00 +0200 Message-Id: <20210520064900.2413612-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Such comments make reviewing this file somehow easier. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/virtio/virtio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index e02544b2df7..2b4c6c4b875 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -2449,6 +2449,7 @@ static void virtio_set_isr(VirtIODevice *vdev, int va= lue) } } =20 +/* Called within rcu_read_lock(). */ static bool virtio_split_should_notify(VirtIODevice *vdev, VirtQueue *vq) { uint16_t old, new; @@ -2485,6 +2486,7 @@ static bool vring_packed_need_event(VirtQueue *vq, bo= ol wrap, return vring_need_event(off, new, old); } =20 +/* Called within rcu_read_lock(). */ static bool virtio_packed_should_notify(VirtIODevice *vdev, VirtQueue *vq) { VRingPackedDescEvent e; --=20 2.26.3