From nobody Tue Feb 10 13:18:13 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1621454997; cv=none; d=zohomail.com; s=zohoarc; b=mEgRarOx7Xd+zFgYCfvUiGIEwChinT3PfIqzw6V93AqNys6TxQX6mVQgZfP51Wo+RG9WcCy1c5DC4OWKvdK0O33kJkGI6kZtSuDr9112hEZP+JSutCpobZCYDlJSIlLWk/aeO/Pt6xlHRI9CTZjo4zsl+f2VJfNWLfGhtCAK0wE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621454997; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+1cCgzdNERUA2fldYa5OSx6THJ2HPT3UIVGVPz585YA=; b=PMWJsVdQH4f3iMhwc4SPFcYGS6p50qB7JYIpc2Q/nFPquTDIvcqKSrINUzLsD/53+QMBYLjKbfAk+6O3zlQmpXA4Z2ZvVczDtQfazbObaU1wX0NLsb//xksYAIn7IbljC+DTDnwH5XBwwUZo0Nt/Pb/LxO9w7tGqvO/a9r1LRbs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1621454997192498.19688335098533; Wed, 19 May 2021 13:09:57 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id n2so15372098wrm.0 for ; Wed, 19 May 2021 13:09:56 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id h14sm7682484wmb.1.2021.05.19.13.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 13:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+1cCgzdNERUA2fldYa5OSx6THJ2HPT3UIVGVPz585YA=; b=IZR6cLq7TbuRY68MoX65C0CZ/KAgrRugZ51VO0KqROTql3Fk6WOfZJBlZsZ+xXBiGc xqUED0sDabeX/vgGtnE6kgQOGHB41pxwe2TxotFmTUQcGPMVO6Aip68DaqjNAuIHIjjZ Vr6r+JcMkfnPmGxrdVODDIsacyFM1AUM81HhmQABl/s+NzcB3bdAIMagY7HT7A24oVoM yIZywsuUep3E0dPujGf/mAp2s8Rp50e5ahLvqsjR8xsfMrjszbf4MOJ5a6smlaE6ZojG SpDG+I7kuOYnwK6+jP6nhnmsSh5ilf9hAN6s3E1Kg1CzVQZZnLt3oiKbJuzcqA9uEWMw +hbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+1cCgzdNERUA2fldYa5OSx6THJ2HPT3UIVGVPz585YA=; b=oy2sbTXF0miQudmfzcEPMBd4+9MFutZVntGeOk2sDc9yTQNro1KRaYb2Q1TUzh4dmQ SK0OZtoq6zCl987PaHAXPANlPqWyX4PbCYDUs3WVQ8JN7JY+4wZn7PyKRRHPR4N/4n1v RbSimAYbNv7vh+9LeRLBefvY3QNoA1tAHb93MMui92G2jhUtra5/taf3iygj0MwAkzi8 g2fxpfrghqG/skEm/oT1CnCuz6nlcG8PZvkPmwOqUE9kNO5Ndip37dJElTN3CaUADeXr pSp8+DQhIM7bzCVEp7ZHq7eKhAmpc5jjbxZo6M1suC053qakjgQ/AgZjvoUTJDgOW1Du Jjlw== X-Gm-Message-State: AOAM533Qt1KdNjG0cPCzrgwAprlMyOuMsnCUU8DliKXWmdT54Hjsxwry 5rmX7rg6i4nGMVIRLw/63ecyBNrK33Ja6Q== X-Google-Smtp-Source: ABdhPJzn2tYBjTKXrP8LVS7dGBjeHdZeYqXJ7K2/7c4V4BFGEGVwpRuJw7u4+RYyLuYwUEEMM4XdtA== X-Received: by 2002:adf:e291:: with SMTP id v17mr660239wri.149.1621454995510; Wed, 19 May 2021 13:09:55 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , qemu-arm@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" , Peter Maydell , Guenter Roeck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] hw/arm/Kconfig: Add missing dependency ZYNQ -> USB_CHIPIDEA Date: Wed, 19 May 2021 22:09:41 +0200 Message-Id: <20210519200942.2223292-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210519200942.2223292-1-f4bug@amsat.org> References: <20210519200942.2223292-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When using a binary built using --without-default-devices we get: $ qemu-system-arm -M xilinx-zynq-a9 ** ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type !=3D= NULL) Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed: = (type !=3D NULL) Looking at the stack trace: (gdb) bt #3 0x00007ffff6e229ff in g_assertion_message_expr () at /lib64/libglib-2= .0.so.0 #4 0x00005555558d3f01 in object_new_with_type (type=3D) a= t qom/object.c:714 #5 0x00005555558d3f59 in object_new (typename=3Dtypename@entry=3D0x55555= 5ad4545 "usb-chipidea") at qom/object.c:747 #6 0x00005555558cd526 in qdev_new (name=3Dname@entry=3D0x555555ad4545 "u= sb-chipidea") at hw/core/qdev.c:153 #7 0x0000555555739fc6 in sysbus_create_varargs (name=3Dname@entry=3D0x55= 5555ad4545 "usb-chipidea", addr=3Daddr@entry=3D3758104576) at hw/core/sysbu= s.c:234 #8 0x0000555555796b57 in sysbus_create_simple (irq=3D, ad= dr=3D3758104576, name=3D0x555555ad4545 "usb-chipidea") at include/hw/sysbus= .h:104 #9 zynq_init (machine=3D0x555555de07a0) at hw/arm/xilinx_zynq.c:254 #10 0x000055555573707c in machine_run_board_init (machine=3Dmachine@entry= =3D0x555555de07a0) at hw/core/machine.c:1238 When replacing the xlnx,ps7-usb device by the IDEA one in commit 616ec12d0fc ("hw/arm/xilinx_zynq: Fix USB port instantiation") we forgot to add the Kconfig dependency on the new device. Do it now. Fixes: 616ec12d0fc ("hw/arm/xilinx_zynq: Fix USB port instantiation") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 585de92f00a..838737656f7 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -292,6 +292,7 @@ config ZYNQ select XILINX_SPI select XILINX_SPIPS select ZYNQ_DEVCFG + select USB_CHIPIDEA =20 config ARM_V7M bool --=20 2.26.3