From nobody Wed May 15 21:57:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) client-ip=209.85.221.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1621454992; cv=none; d=zohomail.com; s=zohoarc; b=DwrSO9zMTqioXnCfXyaZqtB9z7uCAMAoGBFKHGBbxyxqn23ll9xu0p9vZPpL+B0KgDGCb3udyFnsKJmNhuk/VP6MB/IKnrmuNcpv7AyXtBLQPolnc28H93+161a2GPLRdezG/vXdroSrpYz0Ra9AuARPEDhIV48NmorngMkqFRY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621454992; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=i0R1B2wNv5GtUfi6OCru6hxSiiBtsSrJgzRomgBg/As=; b=cLbvgHj9J2t3Rs668oSpIVJ8kWE5mhhkzgpz4UxwT5ecWdx5lvimgayZPAdfMR5tUnZHtxck7ttPKRvGOjz4prheBpswVboVoW5IyRNi5WyNbKE/GR1scG58G6p9FIsxYK6/5kviRy5jKNvPBiLvyGJD1CZFlWOnOFa/cSE9UHA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.zohomail.com with SMTPS id 1621454992230975.8042684030411; Wed, 19 May 2021 13:09:52 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id h4so15255647wrt.12 for ; Wed, 19 May 2021 13:09:51 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id s15sm556216wrt.54.2021.05.19.13.09.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 13:09:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i0R1B2wNv5GtUfi6OCru6hxSiiBtsSrJgzRomgBg/As=; b=OeMfG2cfQfVN52nUjKXQ3AMdcD59alHrcziLnVegGHY8dkzK0jd6Gt/qy405537MbF espHXC6CBM19Y7alfGl24hGsRlG5t1HMt1K1b8xKQqS5fa1Pqu2GKTv58qHk1OY/A+hf uVEP24fnqWF2DwP1UI/joiVf6v/08vOvMGpl+GOxHgjfaAujAr1Fk4aKJWqm5eJyPLun TErRuWo2LmPV6qX7tVBlblqUJJDBRUgSRz5SgHhc12vdY5TFFgE0CvjeCuLHcluk85dv 7GSR5UjMCcm+vezrPXX3WGCZxLtzgg0gNB4T1uOgGIO1UMoIQfGlCGpOm57Nr2/GXQMH ae2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=i0R1B2wNv5GtUfi6OCru6hxSiiBtsSrJgzRomgBg/As=; b=rwQBd7m3nm5lq6uV9+lZw4VVeT6EsmaBWxoU485Exlzbao8DZ0M3nVQHLTiMYdNqBD OSheWK2i9hn6ncM07rzWU1VNvFHiPjUvbi0Qz90DhEQ67eLD5cb+QblIBw4Fz6us1/pt RYl3ehFZLET0UNmH4y1haVOU0EDacnOtvfx3EaW5LB9ZNQB08WRmGGvD/BUs8yUGOEJ0 bBoPWaOZzjN33LkMoqt2ktvGB8UMmvSOeANHl4OpR0yd9hTebNY0joih2SBUHLsMvcCx nCUN2vJBZs5HUTwtmpl7m7gwtVVFLIz8OLXHiOmtrA/ptzwY4tw0a9+djmrP4FZc4Izf YTUQ== X-Gm-Message-State: AOAM5328X2GnM1J/5X+NmVZzJfrvy4fTIwCXoWPIIgYoLe1cGENimdnq tjxPZcFk6l8FN3C3Z6rWwXs= X-Google-Smtp-Source: ABdhPJxHzZyMp07IajDSGSrYzkRJjtlcvciQo07FHJ2d5qDamCox1d/LdqVD4/xC+/HNqIguRpyvLg== X-Received: by 2002:a5d:4ccc:: with SMTP id c12mr650478wrt.137.1621454990577; Wed, 19 May 2021 13:09:50 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , qemu-arm@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" , Peter Maydell , Guenter Roeck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] hw/usb/Kconfig: Introduce USB_CHIPIDEA symbol Date: Wed, 19 May 2021 22:09:40 +0200 Message-Id: <20210519200942.2223292-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210519200942.2223292-1-f4bug@amsat.org> References: <20210519200942.2223292-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Currently the TYPE_CHIPIDEA model is only built when the IMX machines are built. Since it is not specific to IMX, add its symbol to allow other machines to use it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/arm/Kconfig | 4 ++++ hw/usb/Kconfig | 3 +++ hw/usb/meson.build | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index b887f6a5b17..585de92f00a 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -385,6 +385,7 @@ config FSL_IMX25 select IMX_I2C select WDT_IMX2 select DS1338 + select USB_CHIPIDEA =20 config FSL_IMX31 bool @@ -403,6 +404,7 @@ config FSL_IMX6 select IMX_USBPHY select WDT_IMX2 select SDHCI + select USB_CHIPIDEA =20 config ASPEED_SOC bool @@ -447,6 +449,7 @@ config FSL_IMX7 select PCI_EXPRESS_DESIGNWARE select SDHCI select UNIMP + select USB_CHIPIDEA =20 config ARM_SMMUV3 bool @@ -460,6 +463,7 @@ config FSL_IMX6UL select WDT_IMX2 select SDHCI select UNIMP + select USB_CHIPIDEA =20 config MICROBIT bool diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index 53f8283ffdc..5b230cfbf33 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -133,3 +133,6 @@ config XLNX_USB_SUBSYS bool default y if XLNX_VERSAL select USB_DWC3 + +config USB_CHIPIDEA + bool diff --git a/hw/usb/meson.build b/hw/usb/meson.build index f357270d0b6..67df878f0f3 100644 --- a/hw/usb/meson.build +++ b/hw/usb/meson.build @@ -27,7 +27,7 @@ softmmu_ss.add(when: 'CONFIG_USB_DWC3', if_true: files('hcd-dwc3.c')) =20 softmmu_ss.add(when: 'CONFIG_TUSB6010', if_true: files('tusb6010.c')) -softmmu_ss.add(when: 'CONFIG_IMX', if_true: files('chipidea.c')) +softmmu_ss.add(when: 'CONFIG_USB_CHIPIDEA', if_true: files('chipidea.c')) softmmu_ss.add(when: 'CONFIG_IMX_USBPHY', if_true: files('imx-usb-phy.c')) softmmu_ss.add(when: 'CONFIG_VT82C686', if_true: files('vt82c686-uhci-pci.= c')) specific_ss.add(when: 'CONFIG_XLNX_VERSAL', if_true: files('xlnx-versal-us= b2-ctrl-regs.c')) --=20 2.26.3 From nobody Wed May 15 21:57:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1621454997; cv=none; d=zohomail.com; s=zohoarc; b=mEgRarOx7Xd+zFgYCfvUiGIEwChinT3PfIqzw6V93AqNys6TxQX6mVQgZfP51Wo+RG9WcCy1c5DC4OWKvdK0O33kJkGI6kZtSuDr9112hEZP+JSutCpobZCYDlJSIlLWk/aeO/Pt6xlHRI9CTZjo4zsl+f2VJfNWLfGhtCAK0wE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621454997; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+1cCgzdNERUA2fldYa5OSx6THJ2HPT3UIVGVPz585YA=; b=PMWJsVdQH4f3iMhwc4SPFcYGS6p50qB7JYIpc2Q/nFPquTDIvcqKSrINUzLsD/53+QMBYLjKbfAk+6O3zlQmpXA4Z2ZvVczDtQfazbObaU1wX0NLsb//xksYAIn7IbljC+DTDnwH5XBwwUZo0Nt/Pb/LxO9w7tGqvO/a9r1LRbs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1621454997192498.19688335098533; Wed, 19 May 2021 13:09:57 -0700 (PDT) Received: by mail-wr1-f42.google.com with SMTP id n2so15372098wrm.0 for ; Wed, 19 May 2021 13:09:56 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id h14sm7682484wmb.1.2021.05.19.13.09.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 13:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+1cCgzdNERUA2fldYa5OSx6THJ2HPT3UIVGVPz585YA=; b=IZR6cLq7TbuRY68MoX65C0CZ/KAgrRugZ51VO0KqROTql3Fk6WOfZJBlZsZ+xXBiGc xqUED0sDabeX/vgGtnE6kgQOGHB41pxwe2TxotFmTUQcGPMVO6Aip68DaqjNAuIHIjjZ Vr6r+JcMkfnPmGxrdVODDIsacyFM1AUM81HhmQABl/s+NzcB3bdAIMagY7HT7A24oVoM yIZywsuUep3E0dPujGf/mAp2s8Rp50e5ahLvqsjR8xsfMrjszbf4MOJ5a6smlaE6ZojG SpDG+I7kuOYnwK6+jP6nhnmsSh5ilf9hAN6s3E1Kg1CzVQZZnLt3oiKbJuzcqA9uEWMw +hbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+1cCgzdNERUA2fldYa5OSx6THJ2HPT3UIVGVPz585YA=; b=oy2sbTXF0miQudmfzcEPMBd4+9MFutZVntGeOk2sDc9yTQNro1KRaYb2Q1TUzh4dmQ SK0OZtoq6zCl987PaHAXPANlPqWyX4PbCYDUs3WVQ8JN7JY+4wZn7PyKRRHPR4N/4n1v RbSimAYbNv7vh+9LeRLBefvY3QNoA1tAHb93MMui92G2jhUtra5/taf3iygj0MwAkzi8 g2fxpfrghqG/skEm/oT1CnCuz6nlcG8PZvkPmwOqUE9kNO5Ndip37dJElTN3CaUADeXr pSp8+DQhIM7bzCVEp7ZHq7eKhAmpc5jjbxZo6M1suC053qakjgQ/AgZjvoUTJDgOW1Du Jjlw== X-Gm-Message-State: AOAM533Qt1KdNjG0cPCzrgwAprlMyOuMsnCUU8DliKXWmdT54Hjsxwry 5rmX7rg6i4nGMVIRLw/63ecyBNrK33Ja6Q== X-Google-Smtp-Source: ABdhPJzn2tYBjTKXrP8LVS7dGBjeHdZeYqXJ7K2/7c4V4BFGEGVwpRuJw7u4+RYyLuYwUEEMM4XdtA== X-Received: by 2002:adf:e291:: with SMTP id v17mr660239wri.149.1621454995510; Wed, 19 May 2021 13:09:55 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , qemu-arm@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" , Peter Maydell , Guenter Roeck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] hw/arm/Kconfig: Add missing dependency ZYNQ -> USB_CHIPIDEA Date: Wed, 19 May 2021 22:09:41 +0200 Message-Id: <20210519200942.2223292-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210519200942.2223292-1-f4bug@amsat.org> References: <20210519200942.2223292-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) When using a binary built using --without-default-devices we get: $ qemu-system-arm -M xilinx-zynq-a9 ** ERROR:qom/object.c:714:object_new_with_type: assertion failed: (type !=3D= NULL) Bail out! ERROR:qom/object.c:714:object_new_with_type: assertion failed: = (type !=3D NULL) Looking at the stack trace: (gdb) bt #3 0x00007ffff6e229ff in g_assertion_message_expr () at /lib64/libglib-2= .0.so.0 #4 0x00005555558d3f01 in object_new_with_type (type=3D) a= t qom/object.c:714 #5 0x00005555558d3f59 in object_new (typename=3Dtypename@entry=3D0x55555= 5ad4545 "usb-chipidea") at qom/object.c:747 #6 0x00005555558cd526 in qdev_new (name=3Dname@entry=3D0x555555ad4545 "u= sb-chipidea") at hw/core/qdev.c:153 #7 0x0000555555739fc6 in sysbus_create_varargs (name=3Dname@entry=3D0x55= 5555ad4545 "usb-chipidea", addr=3Daddr@entry=3D3758104576) at hw/core/sysbu= s.c:234 #8 0x0000555555796b57 in sysbus_create_simple (irq=3D, ad= dr=3D3758104576, name=3D0x555555ad4545 "usb-chipidea") at include/hw/sysbus= .h:104 #9 zynq_init (machine=3D0x555555de07a0) at hw/arm/xilinx_zynq.c:254 #10 0x000055555573707c in machine_run_board_init (machine=3Dmachine@entry= =3D0x555555de07a0) at hw/core/machine.c:1238 When replacing the xlnx,ps7-usb device by the IDEA one in commit 616ec12d0fc ("hw/arm/xilinx_zynq: Fix USB port instantiation") we forgot to add the Kconfig dependency on the new device. Do it now. Fixes: 616ec12d0fc ("hw/arm/xilinx_zynq: Fix USB port instantiation") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 585de92f00a..838737656f7 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -292,6 +292,7 @@ config ZYNQ select XILINX_SPI select XILINX_SPIPS select ZYNQ_DEVCFG + select USB_CHIPIDEA =20 config ARM_V7M bool --=20 2.26.3 From nobody Wed May 15 21:57:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) client-ip=209.85.221.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1621455002; cv=none; d=zohomail.com; s=zohoarc; b=bXOkuOeRl7xBwqkHG+e8qHU0Hk1LY0E82hmuM744m1mFoAxj7KUxbL11mB2h5r1lvNMETvpHfNXJ/H3yQZLIAyvrFJ5N/OBGOBE/rjgU1DFqe16l8xDQJtZifwXzkQowUFDLxEZtP222B3vvy5c4+hSQ27p1hZQjGMQCMatVxs0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621455002; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UNRUgI7bQlcsYYliaD9X4GS1cwgUena3dydk8aG8JR4=; b=JE09sCqH1v7RT1oug24NqByNILxwjzAWczZBBgn4V1QiIDksVbZcBjB8AyIgDT+OzSRsQW4CETqByioBxIo2H0b9ZBB9ELVdO+YNW1Lplbqzi7rYFun1ieFXAoeYNXjyI2D6bfkP5BuWyvhVuLfco6kogcXvcw0PibzlrBRC/XU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.zohomail.com with SMTPS id 1621455002059859.7802194931899; Wed, 19 May 2021 13:10:02 -0700 (PDT) Received: by mail-wr1-f53.google.com with SMTP id x8so15288631wrq.9 for ; Wed, 19 May 2021 13:10:01 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id r5sm438109wrw.96.2021.05.19.13.09.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 13:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UNRUgI7bQlcsYYliaD9X4GS1cwgUena3dydk8aG8JR4=; b=KP1eSi0wZ5rZkpG98HHwsb2jPyjGS+OISbQPbKTswYfHGW5B2AmM2sYp0b+qT6ckIT WChwmzNjFWBszm/0JGZBpLc39MPsL66PDamiKtGdZbc+hutA5gV76Mbt6g+B7jBTaMcA oyWAYsSDWPhxl8qK3iCrqUq9Xl/nMR5sAwFj7RZy4y68oDXAaBejAeenIhwKSQzC6vAP w8nc6dnIy4FCxmrsZ3oVSSh9tAc61c4+jKGsve0Q3lAgAlbC1l7LS8/2OuC4aMlCU2BR nAVRL7RCEZOVI7pOd6oqpBpRrHyo4487PXgK3apDYwymRBA3qeZQyOeiHwIGRAhGITuk wcHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=UNRUgI7bQlcsYYliaD9X4GS1cwgUena3dydk8aG8JR4=; b=WAKIWX0C7wft64Qjy8uooiqCkUm0vPZLmGMF8oLbSDreXa9tWJ366bKrWxvNsNee73 czNTuNYDSc6/AfmRh4K7hfvT+jVrjRtXQ5bv2r/aXBoU9q2xKPbXo5f0DcdFpMl5bFs1 5pFr1fVz6zdwG5QAxn8UiCMqRkpxOYd4DEUdsqgO6zY0Mqh/xudhIgH0SXcK/Bmn5v4e YpPw5I085DBPIMWCdAWh2xbYLv6Sh4X+O+IAhbgsVg1AcWRTMqMCJXf324Z6L/8xdJHc RmLeprdMduPcJ699f2SIcsSzBn5lH9dpyW33Vv8vPU3t45F1kCimztfv+alUbfffrBWq TZVQ== X-Gm-Message-State: AOAM532rkBv3aMSIBqCZgD/fgYUtRfpCKkvmIxdbTs2Zn6293ZZc9ZN3 gcEDyRBJ//ayWndj2rovJAg= X-Google-Smtp-Source: ABdhPJx0vKB+UVbL5p/hNEoU7AxoUKh0ghFKqA2z9TExs4mUXC2OGXsXGZfwrdrr7O4GD6bmoH+tfA== X-Received: by 2002:a5d:568c:: with SMTP id f12mr695934wrv.382.1621455000321; Wed, 19 May 2021 13:10:00 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Alistair Francis , qemu-arm@nongnu.org, Gerd Hoffmann , "Edgar E. Iglesias" , Peter Maydell , Guenter Roeck , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/3] hw/arm/Kconfig: Add missing dependency IMX_USBPHY -> FSL_IMX6UL Date: Wed, 19 May 2021 22:09:42 +0200 Message-Id: <20210519200942.2223292-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210519200942.2223292-1-f4bug@amsat.org> References: <20210519200942.2223292-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We added IMX_USBPHY in commit 0701a5efa01 ("hw/usb: Add basic i.MX USB Phy support") and had the FSL_IMX6 machine select it, however this machine did not use the IMX_USBPHY until commit 49cd55789bb ("hw/arm/fsl-imx6: Wire up USB controllers"). Commit 17372bd812d ("hw/arm/fsl-imx6ul: Wire up USB controllers") added the similar dependency but forgot to select the Kconfig symbol. Do it now to solve when building using --without-default-devices: $ qemu-system-arm -M mcimx6ul-evk qemu-system-arm: missing object type 'imx.usbphy' Aborted (core dumped) Fixes: 17372bd812d ("hw/arm/fsl-imx6ul: Wire up USB controllers") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 838737656f7..3c3e2e94086 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -465,6 +465,7 @@ config FSL_IMX6UL select SDHCI select UNIMP select USB_CHIPIDEA + select IMX_USBPHY =20 config MICROBIT bool --=20 2.26.3