From nobody Mon Feb 9 16:19:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621442102; cv=none; d=zohomail.com; s=zohoarc; b=J+loABRYOwcDZDLSPq7VjiKUXFWRshG7a3gVwWLoRW+efJFN7AhuIX7ZoyyTiI3x2ky6xNHQW47yveN6/o7MsfV627UxtfhonMnzVDQmV7Ed3FdOvdi2M9Sfzfru1ax0Zxv2POFVbhPLyFv6t5P3Zb/nWQmL6UbNvD1o+IPpezA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621442102; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=zQBaPB2rPx7zwmJ2L9PvToDExIoXxeF+Eyck4rA2oM0=; b=YYkygcM+/lXAlQRRrfnSQrWGzxJc6MqGFCBd6fdKVjGZbZ2XrHtx8qwEq3Vxy2avm7w3vk0FB5XE0e5n0ZCV/oKmURZPb2vU7uwFGYEqtapCgERortUBKabY+cxEEZ1/qCgHw6uHR0bt/22x3xa/AlDaU1tgikwHAr4s3vbSe6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621442102673466.90923175994214; Wed, 19 May 2021 09:35:02 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-W6qqHXFGP5-Rq2hC9As0Zw-1; Wed, 19 May 2021 12:35:00 -0400 Received: by mail-wr1-f72.google.com with SMTP id 2-20020adf94020000b0290110481f75ddso7373667wrq.21 for ; Wed, 19 May 2021 09:35:00 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id b8sm27015076wrx.15.2021.05.19.09.34.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 09:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621442101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zQBaPB2rPx7zwmJ2L9PvToDExIoXxeF+Eyck4rA2oM0=; b=as0Vq6cqP/Fr/CbXv1UH/txHodkwDqyoYeLE9KOlOO8GWBPHT8cqQcbWznY4mA7rryD5Yr QDiEph0ImO+kE7uMHeNRAwXi3VPPvKvuZjb7xn0/vNPtC/KCQYkTMWnGtW0MZ9OKQH5ICv 6TB8V5szy8F9v+InLO62ThQ/5riEqr8= X-MC-Unique: W6qqHXFGP5-Rq2hC9As0Zw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zQBaPB2rPx7zwmJ2L9PvToDExIoXxeF+Eyck4rA2oM0=; b=dHx1yVTeSMI4McfZUsqmN0H7WBzuXbatlJiHL83pB8Ukgx+Ph0KGBNvJ6qdcv2FkV8 MIH5KBJXqzxL4vJZd/Cn7yxbC1yuURbdvrbXy7Ehg7MReAxX7B/fpHmHfu0MZtt5neXg 6mLjd8CtxLwVSa5FIPvm9AUG6tztOnmPqkXl74GwQ6QxRFzhYHD+7zl3qjFqO2Dq/nsb 1ue3vpC2Bo/qooYJSH6FSlzSutG3Vtz71gmx3xkELuKtcdHWblet2MhXwJEa5H12fTB2 kwEm+oV5xWi7rLSSW/hfxWUZ9epNCHcptzYRBzSlhlvcaAtb7H+xAciMbwIG17+AQwhS CSeQ== X-Gm-Message-State: AOAM532AiIEOh/r+V+/xm2nQQrZ3hLg74V/zm6S0QCzBKTrvpAbhn/mc lhLWw/9jxa8h9dzEgiUAIVs3Gh3MlimDbIkr71DBVeOaJTjAEVX5I5RzIhFnMfQ9ujmK/FYd32p ol5LONnfLOQEbRg== X-Received: by 2002:a05:6000:244:: with SMTP id m4mr15692483wrz.225.1621442099154; Wed, 19 May 2021 09:34:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJywwJOety9/DBSOSzzTvYDzInt8nSuOZZrF0A9b3n1kH6PiHULNuMGh/KNuFa2lyQsxUq0leQ== X-Received: by 2002:a05:6000:244:: with SMTP id m4mr15692468wrz.225.1621442099047; Wed, 19 May 2021 09:34:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: John Snow , qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland Subject: [PATCH v6 2/5] hw/block/fdc: Replace disabled fprintf() by trace event Date: Wed, 19 May 2021 18:34:45 +0200 Message-Id: <20210519163448.2154339-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210519163448.2154339-1-philmd@redhat.com> References: <20210519163448.2154339-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Reviewed-by: John Snow Acked-by: Mark Cave-Ayland Reviewed-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/fdc.c | 7 +------ hw/block/trace-events | 1 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a825c2acbae..1d3a0473678 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -1242,12 +1242,7 @@ static void fdctrl_external_reset_isa(DeviceState *d) =20 static void fdctrl_handle_tc(void *opaque, int irq, int level) { - //FDCtrl *s =3D opaque; - - if (level) { - // XXX - FLOPPY_DPRINTF("TC pulsed\n"); - } + trace_fdctrl_tc_pulse(level); } =20 /* Change IRQ state */ diff --git a/hw/block/trace-events b/hw/block/trace-events index 646917d045f..7b26fc738f0 100644 --- a/hw/block/trace-events +++ b/hw/block/trace-events @@ -3,6 +3,7 @@ # fdc.c fdc_ioport_read(uint8_t reg, uint8_t value) "read reg 0x%02x val 0x%02x" fdc_ioport_write(uint8_t reg, uint8_t value) "write reg 0x%02x val 0x%02x" +fdctrl_tc_pulse(int level) "TC pulse: %u" =20 # pflash_cfi01.c # pflash_cfi02.c --=20 2.26.3