From nobody Mon Feb 9 11:30:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621373876; cv=none; d=zohomail.com; s=zohoarc; b=aFEcJN5Vt+45WhEaT8DSMNcBl8upxcv6UFI90M8iMvaT26ta8V7K1dQVJHq2PXT+8hRmEgQ6Mpbo2Ios0a+4z7bO+Y2c1NX3bmydsQF/fo3dVD+yJWg5qWThJgTI8Z+VxhlM/Uxim3gk6EvDYURbNHnft5baG7yCaTfDJEnDjqI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621373876; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zh9ddEMVe0cvJYMbA2aLZHBcCUYjRQqS6U2FtHGIOr4=; b=K5/Qf9lvSRcp7zPK/NBlbliN9/EHYnKjtF8f+QNaHrpgjRAdti/p7oJfCfD+E0mYBcf5loMk6GvN9qZVkhjbX4qWhHPlsaY6hABheG1uylE8cTm56+ovqwIrAwAHQR2Uo4iF0bd5oiXDiRie1gWC8rixEm+YUhAizVwpJRBKNSw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621373876655133.83453585155246; Tue, 18 May 2021 14:37:56 -0700 (PDT) Received: from localhost ([::1]:35090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lj7PW-0001aH-Ed for importer@patchew.org; Tue, 18 May 2021 17:37:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj7Nf-00074S-3r for qemu-devel@nongnu.org; Tue, 18 May 2021 17:35:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:33525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lj7Na-0007P1-Mp for qemu-devel@nongnu.org; Tue, 18 May 2021 17:35:58 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-iHVHuCpIMZenw7xmgE2jQw-1; Tue, 18 May 2021 17:35:52 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A24A4180FD64 for ; Tue, 18 May 2021 21:35:50 +0000 (UTC) Received: from horse.redhat.com (ovpn-114-77.rdu2.redhat.com [10.10.114.77]) by smtp.corp.redhat.com (Postfix) with ESMTP id DBB9D18534; Tue, 18 May 2021 21:35:46 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 678C2225FCF; Tue, 18 May 2021 17:35:46 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621373753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zh9ddEMVe0cvJYMbA2aLZHBcCUYjRQqS6U2FtHGIOr4=; b=LtxqkQ7RZH3N8PMzx73dYhuU1mPB+eo9npJ444AL1yOX6jYTuGfQRcRAE1gmuB7TiFdCxf QlKh7QJK/5+GQNwB2XIL7hsLA5pAFl3+YilbpV//RAtwO20voE+rOD6YXfEcoys5PJ0z0L 4/p+tte4fe7Ma9WTWzcVb+tucrabLFU= X-MC-Unique: iHVHuCpIMZenw7xmgE2jQw-1 From: Vivek Goyal To: qemu-devel@nongnu.org, virtio-fs@redhat.com Subject: [PATCH v2 3/7] virtiofsd: Use iov_discard_front() to skip bytes Date: Tue, 18 May 2021 17:35:34 -0400 Message-Id: <20210518213538.693422-4-vgoyal@redhat.com> In-Reply-To: <20210518213538.693422-1-vgoyal@redhat.com> References: <20210518213538.693422-1-vgoyal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vgoyal@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=vgoyal@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ckuehl@redhat.com, dgilbert@redhat.com, vgoyal@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" There are places where we need to skip few bytes from front of the iovec array. We have our own custom code for that. Looks like iov_discard_front() can do same thing. So use that helper instead. Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Connor Kuehl Signed-off-by: Vivek Goyal --- tools/virtiofsd/fuse_virtio.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 28e2974d1a..09674f2e90 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -389,23 +389,15 @@ int virtio_send_data_iov(struct fuse_session *se, str= uct fuse_chan *ch, memcpy(in_sg_cpy, in_sg, sizeof(struct iovec) * in_num); /* These get updated as we skip */ struct iovec *in_sg_ptr =3D in_sg_cpy; - int in_sg_cpy_count =3D in_num; + unsigned int in_sg_cpy_count =3D in_num; =20 /* skip over parts of in_sg that contained the header iov */ size_t skip_size =3D iov_len; =20 size_t in_sg_left =3D 0; do { - while (skip_size !=3D 0 && in_sg_cpy_count) { - if (skip_size >=3D in_sg_ptr[0].iov_len) { - skip_size -=3D in_sg_ptr[0].iov_len; - in_sg_ptr++; - in_sg_cpy_count--; - } else { - in_sg_ptr[0].iov_len -=3D skip_size; - in_sg_ptr[0].iov_base +=3D skip_size; - break; - } + if (skip_size !=3D 0) { + iov_discard_front(&in_sg_ptr, &in_sg_cpy_count, skip_size); } =20 int i; --=20 2.25.4