From nobody Mon Feb 9 16:02:30 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621366374; cv=none; d=zohomail.com; s=zohoarc; b=R3qfMQ7n4AFxBK7XS9bNjRALlq1qYlKtEJqTj2uttCAEgMbphXEZBff3ei7VRMS0/wOc3rVnptCAfxcCNbbRIbr7ypRFjKkArpuLhnRXmSt28B7SyqkrecvZN1bzrYe9ze4izE/4p1HVVTbbgKo+WBFTSdidEUvVMhppqwdjItc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621366374; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=zQBaPB2rPx7zwmJ2L9PvToDExIoXxeF+Eyck4rA2oM0=; b=ev7y2LLnfhfSGScJRxJc9n7RqnH2UQ65d1dKO1xqWDDE5jJSHXF0gDEsU1g7RDjsQvNjhhjdCD8G1VWMZAmFV5du+yhV/mtqzA6klFSL8flHWOtCZdDMVSphOx8J1TC3lPDCByoNPjwH7w1VLLbWQrxh+eUl4IsRhQ7nupPPOH0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621366374529327.7980175751476; Tue, 18 May 2021 12:32:54 -0700 (PDT) Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-551-8fz7dFFWNyOIrqZZWt6xWQ-1; Tue, 18 May 2021 15:32:51 -0400 Received: by mail-ej1-f69.google.com with SMTP id w13-20020a170906384db02903d9ad6b26d8so935130ejc.0 for ; Tue, 18 May 2021 12:32:51 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id k2sm10880861ejj.30.2021.05.18.12.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 12:32:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621366373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zQBaPB2rPx7zwmJ2L9PvToDExIoXxeF+Eyck4rA2oM0=; b=NgoFI48JFjtYk/fM+Gh/FbulQO26GNL/s80ChDyvLnFp4K/mHUaAJesa+VGLIj29rvhHKd 150ws2daeG4h7srtQkOwzjfbwps+y3CThwTusp29BMMMToqIllxyfu+BtBNV8ovwawa65u 4gyVo6jOmiSLXPkg0KF+g52wnoyvCco= X-MC-Unique: 8fz7dFFWNyOIrqZZWt6xWQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zQBaPB2rPx7zwmJ2L9PvToDExIoXxeF+Eyck4rA2oM0=; b=p7acKT3/FWPjeFayQcA+3GYlc5TpitwRmt7oBIBlpP17X6pGTXldqEEkPx94KJoF3x ggHqDXqFVBByobY3mvAQiJDpCS5HU8p6K8gi39nQ2Y+kS98M+fWWw6PMGKEPB/Hwd1li MNJDj8tAJ9FjQ9lIFFrdTObDPEvV+QjL6br20YYeq9DAJbqgic4sVbnIsBqwAbhw6fm7 fouCjLgpJi9A43u2UaWAlgR2s2//Cr6rnUyI263OXPj7gPrxcpX7ZOBWk6FDhCKzbkh4 4ksCULOajydLMe/2aQ2oIrT/YKla/21ZiTexx6l0mImlfeM8XJKGtr+hGH+PSYRFRZAP dVzg== X-Gm-Message-State: AOAM530L8kFCwVTiRhGqHLnt/YPPcIdn1zLU5x5Uqo4PEX1WB1Q27FiD OBLMgzLojZ5stzPVriQ+xSzG5Rk7O2pPwkshutAwLzXyNmKBNwKpZ+w3VsJHJuzIKpoYp9q1TK2 IjJ7IaUXrBSiJKg== X-Received: by 2002:a17:906:5291:: with SMTP id c17mr7540150ejm.527.1621366370758; Tue, 18 May 2021 12:32:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQlqwGuNWZE/w+xuvejbIZiFbzPdPfRz8bH6wbR6h8wIcu4lGd062J8/Cx60CAyIM8mFgtXQ== X-Received: by 2002:a17:906:5291:: with SMTP id c17mr7540136ejm.527.1621366370623; Tue, 18 May 2021 12:32:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, John Snow Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland Subject: [PATCH v5 2/6] hw/block/fdc: Replace disabled fprintf() by trace event Date: Tue, 18 May 2021 21:32:35 +0200 Message-Id: <20210518193239.1725624-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210518193239.1725624-1-philmd@redhat.com> References: <20210518193239.1725624-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Reviewed-by: John Snow Acked-by: Mark Cave-Ayland Reviewed-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/fdc.c | 7 +------ hw/block/trace-events | 1 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a825c2acbae..1d3a0473678 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -1242,12 +1242,7 @@ static void fdctrl_external_reset_isa(DeviceState *d) =20 static void fdctrl_handle_tc(void *opaque, int irq, int level) { - //FDCtrl *s =3D opaque; - - if (level) { - // XXX - FLOPPY_DPRINTF("TC pulsed\n"); - } + trace_fdctrl_tc_pulse(level); } =20 /* Change IRQ state */ diff --git a/hw/block/trace-events b/hw/block/trace-events index 646917d045f..7b26fc738f0 100644 --- a/hw/block/trace-events +++ b/hw/block/trace-events @@ -3,6 +3,7 @@ # fdc.c fdc_ioport_read(uint8_t reg, uint8_t value) "read reg 0x%02x val 0x%02x" fdc_ioport_write(uint8_t reg, uint8_t value) "write reg 0x%02x val 0x%02x" +fdctrl_tc_pulse(int level) "TC pulse: %u" =20 # pflash_cfi01.c # pflash_cfi02.c --=20 2.26.3