From nobody Tue Feb 10 04:33:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621366369; cv=none; d=zohomail.com; s=zohoarc; b=QLLzBqEb4z0ynRom8kuXCpF59FHHyoos8pkiE2bg1yW9pdNNC29p4P8lGLbkPxCaMak4UQTxlFEZOhNRapFP/0bQPk5wYVDDjZioPCsouLb3Vx1OY4jajeRC5E0VBfeI31eoJJ+lYqKaMpxEOm7PUHIeCW96pmC9dNzWlFQ9uiE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621366369; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=yIx6qnixzEdCFqcaxOcBVgzeXQKdqlMaGZGGlAdFf2k=; b=GrX6v4QG/8uB2U+iI4xoWDjwG09oTK7tVztht9X387GxlMVY75JHtiM0wcjGeyT2qxeh4Q7csaqIYbghb0i+swdN8Q+w4jld+Y+HkaVYwNYj+EpSyqAAisG0/PYA6WPzcsxdehway9H2UbhAyNaWAxNGVhtLqlQkCbAMuzg/88w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621366369896521.9233246910245; Tue, 18 May 2021 12:32:49 -0700 (PDT) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-517-XR4vTLolPjWZCgCbbhvaNA-1; Tue, 18 May 2021 15:32:47 -0400 Received: by mail-ej1-f72.google.com with SMTP id k9-20020a17090646c9b029039d323bd239so2788986ejs.16 for ; Tue, 18 May 2021 12:32:47 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id g4sm13795876edw.8.2021.05.18.12.32.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 12:32:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621366368; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yIx6qnixzEdCFqcaxOcBVgzeXQKdqlMaGZGGlAdFf2k=; b=FrQhQXs+7PEW656SV53oq06Dil8T2zzJXE3wg1DWoHjwMjDGgV10QtbEIQPMKouFyasxZE Gca3ioqlVkqZF4Owv35vbDJX2w8/gIDBLsNodKSPfxdggYHXX+/WSK8TrBleVeOzvDJ5BK zWkhwQG6EFC4b+YNvjuzozpvJA1oods= X-MC-Unique: XR4vTLolPjWZCgCbbhvaNA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yIx6qnixzEdCFqcaxOcBVgzeXQKdqlMaGZGGlAdFf2k=; b=dGatOX7wintPZtu6yzgJurtePt/CouyEfmYwJ7G2r5y8w2PFQyvXdLzniGBgBLUf9J BOKf0RsSdsUYT5G6dVbq6JaQIsGdFIgbJbLyOHydtThJzMolamPEB2lkkq0Mx1wjL9jP /ZZ1iCPXglFx85cAcieO7YVWeQFTUs+cmZCP+mYDkHht7hyrVIKNbRt5ESm9lrJZc7ge DaZCSp6o8+tuAXdliyu6/+2x2Xopo2sddr1qNq+MbdI/nHB9iOolzEdaFTJyFOEdaIib 7F0P4RjQ3aPocT7+NxLO4SrDLGm2HpBFpXeb8DjTsvrmJuyxWMuX3EDbrwK7YydMREWF 4mHg== X-Gm-Message-State: AOAM530yeTmsBITeWGjN4fC0wKg7yKWMMrWaun1be1aYvZ3vU6mOwIJE Q3klutEfe1zmCAYvPpMWM/CTkG0vFACUdC0QIoecbymssR0vVOkjg+r7T59DLQEVSp0nuYQafI+ 0gIIxrj5e2mloJw== X-Received: by 2002:a05:6402:22a8:: with SMTP id cx8mr9002708edb.296.1621366366160; Tue, 18 May 2021 12:32:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyi9MbN+GaQlROKLmKdvxFf0PCYniIN8qbV9iBhw2eYepl0m5MupEDpbrvgJv6dm01d1Q8EA== X-Received: by 2002:a05:6402:22a8:: with SMTP id cx8mr9002693edb.296.1621366366048; Tue, 18 May 2021 12:32:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, John Snow Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v5 1/6] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC Date: Tue, 18 May 2021 21:32:34 +0200 Message-Id: <20210518193239.1725624-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210518193239.1725624-1-philmd@redhat.com> References: <20210518193239.1725624-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) isa_superio_realize() calls isa_fdc_init_drives(), which is defined in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol. Reported-by: John Snow Fixes: c0ff3795143 ("Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.= c") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 55e0003ce40..7216f66a54a 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -17,6 +17,7 @@ config ISA_SUPERIO bool select ISA_BUS select PCKBD + select FDC =20 config PC87312 bool --=20 2.26.3