From nobody Sun Feb 8 22:58:06 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621331905; cv=none; d=zohomail.com; s=zohoarc; b=lcdw388FxcTFFtXoAnxjoNOMcjFOEy0Oua1SIDgYjKPbjie2ylROMCks7pkK1O8eIo/pMfxvDR8LwI0DWyN0acu5Cimlka4V1tsa8PEyGrBBoK2i5tJH/8unO4G/jdZy1maf9fj+JqF7YcbIhb4ZuOew/WuM+hrgI8ydL/pg0/8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621331905; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CFDnO1vlXZk8m9pr0EPJZR/pNpnGcIQXuCLDnP9TTqg=; b=RQSJGOSbESmaZ+kvOqRF4cC5mTljmf0K3bJUM3OcSSH2yxV0q2FEsbwLrQAWfQM6CjSUyOGnspHL51+rEgihm05i/07SbF+gBPHC5tKb5XBp+cUGGc4d3ATX3TLy886usAcwqb6xnaLXP8x3xljx+jpn0t+yWisOv45RNJiA4D0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621331905743349.09595485483567; Tue, 18 May 2021 02:58:25 -0700 (PDT) Received: from localhost ([::1]:42916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liwUa-0001Tn-HD for importer@patchew.org; Tue, 18 May 2021 05:58:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liwE4-0002bp-Lk for qemu-devel@nongnu.org; Tue, 18 May 2021 05:41:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:53370) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liwE2-0007zD-T3 for qemu-devel@nongnu.org; Tue, 18 May 2021 05:41:20 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-oIFYk7aVPzmuHjKBKg6e_Q-1; Tue, 18 May 2021 05:41:15 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DCB7C6414C; Tue, 18 May 2021 09:41:14 +0000 (UTC) Received: from localhost.localdomain (ovpn-114-236.ams2.redhat.com [10.36.114.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id 991CB17A9B; Tue, 18 May 2021 09:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621330878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFDnO1vlXZk8m9pr0EPJZR/pNpnGcIQXuCLDnP9TTqg=; b=iVozlirge61bmao6wufC8XcDDAHwiwWD10qtudrWdUrI4Kqlo2zOdscjIF9Qd5s3JQizr1 mJgFodftpMFbdBN4Vg1lnm/B6GoB86dSYDHLfczmOAJGMLpfNYOrt85r0/EjfrFiOgazE/ FDT7EBLV3DMtu/o/txC+kByObAe23HY= X-MC-Unique: oIFYk7aVPzmuHjKBKg6e_Q-1 From: Emanuele Giuseppe Esposito To: qemu-block@nongnu.org Subject: [PATCH v2 3/5] blockjob: let ratelimit handle a speed of 0 Date: Tue, 18 May 2021 11:40:56 +0200 Message-Id: <20210518094058.25952-4-eesposit@redhat.com> In-Reply-To: <20210518094058.25952-1-eesposit@redhat.com> References: <20210518094058.25952-1-eesposit@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Emanuele Giuseppe Esposito , Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Paolo Bonzini Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Paolo Bonzini Signed-off-by: Emanuele Giuseppe Esposito --- blockjob.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/blockjob.c b/blockjob.c index dc1d9e0e46..22e5bb9b1f 100644 --- a/blockjob.c +++ b/blockjob.c @@ -300,10 +300,6 @@ bool block_job_set_speed(BlockJob *job, int64_t speed,= Error **errp) =20 int64_t block_job_ratelimit_get_delay(BlockJob *job, uint64_t n) { - if (!job->speed) { - return 0; - } - return ratelimit_calculate_delay(&job->limit, n); } =20 @@ -472,12 +468,9 @@ void *block_job_create(const char *job_id, const Block= JobDriver *driver, blk_set_disable_request_queuing(blk, true); blk_set_allow_aio_context_change(blk, true); =20 - /* Only set speed when necessary to avoid NotSupported error */ - if (speed !=3D 0) { - if (!block_job_set_speed(job, speed, errp)) { - job_early_fail(&job->job); - return NULL; - } + if (!block_job_set_speed(job, speed, errp)) { + job_early_fail(&job->job); + return NULL; } =20 return job; --=20 2.30.2