From nobody Tue Feb 10 17:46:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1621318843; cv=none; d=zohomail.com; s=zohoarc; b=Je9Y1ptRoyuKvdzR9eKEpSefwWqWVuM5xAJ8TI+TRG4ChmyfxTbz2yi9hqQGoxMd+YrEL7PS66m+Z4nw6JmhLtP4XHS2JsMxNJPNgGRpp0s2yCegINDFjFjhHpxuoDS01ZGWJ08VtjqFa3Q3tDLF3pWDrU8GofCMk5E4fv6rPEQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621318843; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XkPQmmEwCuu5xUszhkBehQaiYB97BAH08iNylEntFhg=; b=LGceua6iY5oZ2uX9I38xUgR1JsP9m5J6dnnHqE7P+r/ldf72ICEdH5clRj3J8AqYSyi5SKZMGn/InHxAbHaBjKg3mdKBnH1RJyL3qLDSUKNUvj25znn9/ynspzfAHqDqxWS4SeF1lhdaYr1IuItwly0f3LtnAiB5vWqT1T6IDiE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621318843917439.0285629431298; Mon, 17 May 2021 23:20:43 -0700 (PDT) Received: from localhost ([::1]:45304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lit5u-0003jP-UZ for importer@patchew.org; Tue, 18 May 2021 02:20:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lisKw-000877-Oj for qemu-devel@nongnu.org; Tue, 18 May 2021 01:32:10 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:51025) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lisKn-0007AR-3U for qemu-devel@nongnu.org; Tue, 18 May 2021 01:32:10 -0400 Received: from quad ([82.142.31.78]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mxpqo-1lYUcf1HJ8-00zHEG; Tue, 18 May 2021 07:31:55 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 43/59] linux-user/s390x: Add stub sigframe argument for last_break Date: Tue, 18 May 2021 07:31:15 +0200 Message-Id: <20210518053131.87212-44-laurent@vivier.eu> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210518053131.87212-1-laurent@vivier.eu> References: <20210518053131.87212-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:B8zeYb7QC5D25AedDnZGj3hnzb78tZEt7lAbrOmCnRPEQSK9stM emmiELAKRCIuyVoBtVEzmc65Jj52ja+a+ghh6CON2agri1UwS0FQa3UTykWE9fjZtXYd83h q0btGR5FYNHnIv6rwlGBtYriq/9uNqgH33B9elLL9R7pJpW6PwFq10yTM3YOjbQZmcVdkLK 2vqJ2XYYjTAqsXVwQE1hw== X-UI-Out-Filterresults: notjunk:1;V03:K0:5/s0C1ENJAA=:7Dx1dVOPKk/tYKzABMX/ii Qr1Xxe0FYTKpjY6iEoRm9oBHtgilSuAAFoNBtWis1MxFme5Kd7l46yM9hIhHSev67kT7rvE9V r3BXZVF6Jhc2ssG6Smg1YeKxRe49KbtsYTmlRXsVYr2gYoPdKfLYJbo06/wYvOJk3zyAQ0zZa zZ38+f7FkJrCE+ZWopLruNtuKU90RmmuIaeo7ep/F3MiQMav95Mn/kL9Vlk55kwSjKsZ/J6O7 xIrJW1e9X/Mki9HZBAyW8Yq+4rf/aNlc4UwihaWILW9/RRLigK0AdR89SUzeesTtS3PVlZkXJ Idjd2QlEU7bfZjqY8bEiR5d93iqSVYkhK7hbmz/s460VCqz6RgCYHId1uf+7Q4nWfeWSRnW7Z tkJmFhmEBD3BSGxMX36RQbvGCNPWHhS5M/Ooo07yGyLH3dYlar1lqwGjRnuO3blf8gatBWF1b hF9LlkRPUbTGa7/2dXD2dhy7dC7qPXJZjqyO+KzLBelCkb3zzu4N3xH8dhvpNqzRw6rJYLAoi f7bJ3qmYQLNoBZTjqTodJc= Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=212.227.126.133; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , Laurent Vivier , David Hildenbrand Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Richard Henderson In order to properly present these arguments, we need to add code to target/s390x to record LowCore parameters for user-only. But in the meantime, at least zero the missing last_break argument, and fixup the comment style in the vicinity. Signed-off-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20210428193408.233706-12-richard.henderson@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/s390x/signal.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index 17f617c65581..bc41b01c5deb 100644 --- a/linux-user/s390x/signal.c +++ b/linux-user/s390x/signal.c @@ -167,13 +167,16 @@ void setup_frame(int sig, struct target_sigaction *ka, | (env->psw.mask & ~PSW_MASK_ASC); env->psw.addr =3D ka->_sa_handler; =20 - env->regs[2] =3D sig; //map_signal(sig); + env->regs[2] =3D sig; env->regs[3] =3D frame_addr +=3D offsetof(typeof(*frame), sc); =20 - /* We forgot to include these in the sigcontext. - To avoid breaking binary compatibility, they are passed as args. */ - env->regs[4] =3D 0; // FIXME: no clue... current->thread.trap_no; - env->regs[5] =3D 0; // FIXME: no clue... current->thread.prot_addr; + /* + * We forgot to include these in the sigcontext. + * To avoid breaking binary compatibility, they are passed as args. + */ + env->regs[4] =3D 0; /* FIXME: regs->int_code & 127 */ + env->regs[5] =3D 0; /* FIXME: regs->int_parm_long */ + env->regs[6] =3D 0; /* FIXME: current->thread.last_break */ =20 /* Place signal number on stack to allow backtrace from handler. */ __put_user(env->regs[2], &frame->signo); @@ -223,9 +226,10 @@ void setup_rt_frame(int sig, struct target_sigaction *= ka, | (env->psw.mask & ~PSW_MASK_ASC); env->psw.addr =3D ka->_sa_handler; =20 - env->regs[2] =3D sig; //map_signal(sig); + env->regs[2] =3D sig; env->regs[3] =3D frame_addr + offsetof(typeof(*frame), info); env->regs[4] =3D frame_addr + offsetof(typeof(*frame), uc); + env->regs[5] =3D 0; /* FIXME: current->thread.last_break */ } =20 static void restore_sigregs(CPUS390XState *env, target_sigregs *sc) --=20 2.31.1