From nobody Mon Feb 9 23:39:44 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1621281294; cv=none; d=zohomail.com; s=zohoarc; b=AUeVZBROXS1iZ8qyrkkAHvwPDQZQ/BFKkCpQZKLQT/oikIdfNMkz8RqPIhGdv3zN7BWrkb9ahb2pVWeSDN9LRzjHiKADEusg+wXt0AHZmwqZHpA/ucHF5cwi9jKvMhvRYTwSVX2I42doWKgFYJ5dBuuOWfEgXcbX8GCLzZA5bZA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621281294; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=gFTr412t6i7g+lJzWG/hnSboeO/MBJ70oO1XqZquEb8=; b=ZvkrtiL39H/8d55vvbFNvHR5+h4tq/R3YAAYvd8Embrx+ijMhG6+ZnuWg44LI6joIRaIQm8uofU3STEi1frjL3E41rSG/sIdkqtQisuBzehm8x7TJb+fbpBdayiipp4tqKfEFt31K+9QlZfQYtlVJm8Rcc5rl/Yk8qn+fJfD56g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16212812942131013.579500818365; Mon, 17 May 2021 12:54:54 -0700 (PDT) Received: from localhost ([::1]:48560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lijKH-0001WY-9e for importer@patchew.org; Mon, 17 May 2021 15:54:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lijBr-0005Uv-1Z for qemu-devel@nongnu.org; Mon, 17 May 2021 15:46:11 -0400 Received: from mailout02.t-online.de ([194.25.134.17]:47152) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lijBp-0000LO-As for qemu-devel@nongnu.org; Mon, 17 May 2021 15:46:10 -0400 Received: from fwd09.aul.t-online.de (fwd09.aul.t-online.de [172.20.27.151]) by mailout02.t-online.de (Postfix) with SMTP id F20BBF164; Mon, 17 May 2021 21:46:04 +0200 (CEST) Received: from linpower.localnet (bpmarGZXohy3MCWnQZRS-xfvn6rsNBbFXGDDjCkg8w7aMmqaqfJNI1CCK1l-3sRQjX@[79.208.18.63]) by fwd09.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1lijBk-1mA0lE0; Mon, 17 May 2021 21:46:04 +0200 Received: by linpower.localnet (Postfix, from userid 1000) id 5A57E2000A0; Mon, 17 May 2021 21:46:04 +0200 (CEST) From: =?UTF-8?q?Volker=20R=C3=BCmelin?= To: Gerd Hoffmann Subject: [PATCH 1/4] alsaaudio: remove #ifdef DEBUG to avoid bit rot Date: Mon, 17 May 2021 21:46:01 +0200 Message-Id: <20210517194604.2545-1-vr_qemu@t-online.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ID: bpmarGZXohy3MCWnQZRS-xfvn6rsNBbFXGDDjCkg8w7aMmqaqfJNI1CCK1l-3sRQjX X-TOI-EXPURGATEID: 150726::1621280764-00002D5B-B3131B7A/0/0 CLEAN NORMAL X-TOI-MSGID: 36fe0ee8-93e8-4fcd-ae6c-7e298ed45b94 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: none client-ip=194.25.134.17; envelope-from=volker.ruemelin@t-online.de; helo=mailout02.t-online.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Merge the #ifdef DEBUG code with the if statement a few lines above to avoid bit rot. Suggested-by: Gerd Hoffmann Signed-off-by: Volker R=C3=BCmelin --- audio/alsaaudio.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/audio/alsaaudio.c b/audio/alsaaudio.c index fcc2f62864..2b9789e647 100644 --- a/audio/alsaaudio.c +++ b/audio/alsaaudio.c @@ -34,6 +34,8 @@ #define AUDIO_CAP "alsa" #include "audio_int.h" =20 +#define DEBUG_ALSA 0 + struct pollhlp { snd_pcm_t *handle; struct pollfd *pfds; @@ -587,16 +589,12 @@ static int alsa_open(bool in, struct alsa_params_req = *req, =20 *handlep =3D handle; =20 - if (obtfmt !=3D req->fmt || - obt->nchannels !=3D req->nchannels || - obt->freq !=3D req->freq) { + if (DEBUG_ALSA || obtfmt !=3D req->fmt || + obt->nchannels !=3D req->nchannels || obt->freq !=3D req->freq) { dolog ("Audio parameters for %s\n", typ); alsa_dump_info(req, obt, obtfmt, apdo); } =20 -#ifdef DEBUG - alsa_dump_info(req, obt, obtfmt, apdo); -#endif return 0; =20 err: --=20 2.26.2