From nobody Mon Feb 9 09:15:56 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621279494; cv=none; d=zohomail.com; s=zohoarc; b=Jy5JFNTBCO+jvN4Cis0hes9ed38zOtitpdzvZRfWc0ICiqxJDExm9LOohqWcy49yhwIBQWv9UgInp9eLz8T143wTqkFeGFVjtvsgyl/vYLTgRIP14MVWSTJwZ85Ywqst3BizgByPEnLo1H+GIMssR5kIWT5mtuS93z1EUFytO38= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621279494; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MGuqrqm51MoXkPciCqG5OPj563q/2p+OEhh+NKfsXDI=; b=UGQIXhZaW3+Oy6V/mSTfTMjcBfuPNfXm0gt+bXDSbpGUH9iyJnLVNyOJKlhAoQ+tr3ldy9KDQk9EryiAUQtN2LYlVivfYiD8tqMqG+3PUJAw2V2Nk/TSs8pgGHeuxIKX5glnSg4sTsHQB1dvJjAIuuBfEnG52xlkHBrzbbdbuHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162127949410366.74743289653998; Mon, 17 May 2021 12:24:54 -0700 (PDT) Received: from localhost ([::1]:53468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liirF-0005r5-2w for importer@patchew.org; Mon, 17 May 2021 15:24:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHx-0001K0-Fj for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31973) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHv-0006yx-UD for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:25 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-137-P7looOccNHyIeobd4AYj6Q-1; Mon, 17 May 2021 14:48:21 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B72B3107ACCD for ; Mon, 17 May 2021 18:48:20 +0000 (UTC) Received: from scv.redhat.com (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 909C319C46; Mon, 17 May 2021 18:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621277303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MGuqrqm51MoXkPciCqG5OPj563q/2p+OEhh+NKfsXDI=; b=ZEJviAuG0YKqtwVY51knDGM3rXyCWoKraCR+xpX32AYBhkHcUlPWZyPhDzf7fEcNvULdjM Vz5mF/3ctYwFUgA3e+wQG2q+ObnicSWCXyy3H9VN+QSOjYw8uz1KiUOGtiDaBkWJ/YIhcW by3yaEaJYMfw0OrIT5FZQEonSkivSZQ= X-MC-Unique: P7looOccNHyIeobd4AYj6Q-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 6/6] python/machine: disable warning for Popen in _launch() Date: Mon, 17 May 2021 14:48:08 -0400 Message-Id: <20210517184808.3562549-7-jsnow@redhat.com> In-Reply-To: <20210517184808.3562549-1-jsnow@redhat.com> References: <20210517184808.3562549-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emanuele Giuseppe Esposito , John Snow , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We handle this resource rather meticulously in shutdown/kill/wait/__exit__ et al, through the laborious mechanisms in _do_shutdown(). Quiet this pylint warning here. Signed-off-by: John Snow Reviewed-by: Cleber Rosa --- python/qemu/machine.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python/qemu/machine.py b/python/qemu/machine.py index f021127f0fc..06058d89e83 100644 --- a/python/qemu/machine.py +++ b/python/qemu/machine.py @@ -407,6 +407,9 @@ def _launch(self) -> None: self._args) ) LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args)) + + # Cleaning up of this subprocess is guaranteed by _do_shutdown. + # pylint: disable=3Dconsider-using-with self._popen =3D subprocess.Popen(self._qemu_full_args, stdin=3Dsubprocess.DEVNULL, stdout=3Dself._qemu_log_file, --=20 2.30.2