From nobody Fri May 17 03:54:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621279605; cv=none; d=zohomail.com; s=zohoarc; b=fzG8RspQZOBLEMiMeEeYUM5lo5KCcBktUfb4sVFRPucwpaSMTo4ZEhRSUSJRu1ecq81qNZ6UbIt7vGOuEkiOkPFt6BKgN1aopEeS3PnKafXPDph2au2706uuYrA4p+KTg70XOwyDOxoROaD3a4iZsFQMOijhf21E/zF1M0e4bqs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621279605; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lBD4hUv3uFfBx2PnKVfChaLnqq3xzk/SIyEr89wp+sQ=; b=Qs6psYDYO54j+DGzRMW1D9x6vQhwaZAlKCfcHq1naEuIC8eR61QcQ26t62VNwHYbaB1JqAmZZ2QrVAy+0s+906SYNiPJNc87rDaqiK52ccfA0IH7LLlzbcxoW1ZOCRpULIqD9V1iT0O5iQhboz0txzupquhMjjLIsizjTMiilq4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621279605944306.41371186364825; Mon, 17 May 2021 12:26:45 -0700 (PDT) Received: from localhost ([::1]:60264 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liit2-00025q-Fk for importer@patchew.org; Mon, 17 May 2021 15:26:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHs-0000zT-63 for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:20 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:41751) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHq-0006tj-BM for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:19 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-327-Zr1lgAAHN1KmsIGlRbgBLw-1; Mon, 17 May 2021 14:48:15 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 24AA88186E8 for ; Mon, 17 May 2021 18:48:14 +0000 (UTC) Received: from scv.redhat.com (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 37BD619C46; Mon, 17 May 2021 18:48:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621277297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lBD4hUv3uFfBx2PnKVfChaLnqq3xzk/SIyEr89wp+sQ=; b=gP8V52HhFZXmgCzt8xRiDhGdBUcGKfu1HL2fk0R/JSbC3sK+DLfWPpuSbTUbBpOqbwFN/1 Kz5C79cyNSsgayFUR3CTk4PNku26wTWFYmTCDh1O8KGTsEvJ4z+CCYMLG/y1E1qYDLoGLX 584eSYp4/19qQxYV36UTHmgmhh6F8gI= X-MC-Unique: Zr1lgAAHN1KmsIGlRbgBLw-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 1/6] python/console_socket: avoid one-letter variable Date: Mon, 17 May 2021 14:48:03 -0400 Message-Id: <20210517184808.3562549-2-jsnow@redhat.com> In-Reply-To: <20210517184808.3562549-1-jsnow@redhat.com> References: <20210517184808.3562549-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emanuele Giuseppe Esposito , Eduardo Habkost , John Snow , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Fixes pylint warnings. Signed-off-by: John Snow Reviewed-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- python/qemu/console_socket.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py index ac21130e446..87237bebef7 100644 --- a/python/qemu/console_socket.py +++ b/python/qemu/console_socket.py @@ -46,11 +46,11 @@ def __init__(self, address: str, file: Optional[str] = =3D None, self._drain_thread =3D self._thread_start() =20 def __repr__(self) -> str: - s =3D super().__repr__() - s =3D s.rstrip(">") - s =3D "%s, logfile=3D%s, drain_thread=3D%s>" % (s, self._logfile, - self._drain_thread) - return s + tmp =3D super().__repr__() + tmp =3D tmp.rstrip(">") + tmp =3D "%s, logfile=3D%s, drain_thread=3D%s>" % (tmp, self._logf= ile, + self._drain_thread) + return tmp =20 def _drain_fn(self) -> None: """Drains the socket and runs while the socket is open.""" --=20 2.30.2 From nobody Fri May 17 03:54:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621279765; cv=none; d=zohomail.com; s=zohoarc; b=F7+HxubLw/e3mthR/p3ZJ0dpkztzausmTFmWm5rF3U+an1Qo6r6vgiNbDtrSQnHUuk600xddRmEG1EcXXOUL64Mo0XDDkrfeEtp6qa5mPHvDErxGhT3S3ajc0phc8/RM/Km8g37f8l5nJuNR5+g6qo2tTQTZ2HOZhbSgk1uI7w8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621279765; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bjPSneTvTI+TkbJZNubTGkNppSr91+Xv4DZST4sCK6Q=; b=Cu+GW17eXokR7GaiEx9NfzNkxGF+5GSYBrEEQzkYDl31KcqFJrJmahXSQn0lBiLplAFS1AV+gWUZJ2SSovy5CC5Xn06HgLDQtOLO04jA/RXyPLEqBde/y2jGLTY3ANI6XYpy+D7OgGyFo5UFlMMsU1DKV6N0+4djAvvDLofzbMA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621279765102842.2531352933586; Mon, 17 May 2021 12:29:25 -0700 (PDT) Received: from localhost ([::1]:40498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liivb-0007ps-W0 for importer@patchew.org; Mon, 17 May 2021 15:29:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42750) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHt-00012Y-1F for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:35880) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHq-0006tn-DF for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:20 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-14-S6HD-GcDPmiOJVbT0KbhzQ-1; Mon, 17 May 2021 14:48:16 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 45DE28015F5 for ; Mon, 17 May 2021 18:48:15 +0000 (UTC) Received: from scv.redhat.com (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5490D19C46; Mon, 17 May 2021 18:48:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621277297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bjPSneTvTI+TkbJZNubTGkNppSr91+Xv4DZST4sCK6Q=; b=bQowQs02j8ks8r4sPNqaVPi/7pZvSS37Vi7wx5lUSUboF117Kui+gJynLq+xoS28IIBixf nvBoBfIqZkIyxNjeZ1AJskJqpUpAHzItNQIycLB8IRwL+wsemkBCWYt0tCBv1/S9Phd9yf vWBMyB2K6f9sClfW9rzaJwlVqMnJeTA= X-MC-Unique: S6HD-GcDPmiOJVbT0KbhzQ-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 2/6] python/machine: use subprocess.DEVNULL instead of open(os.path.devnull) Date: Mon, 17 May 2021 14:48:04 -0400 Message-Id: <20210517184808.3562549-3-jsnow@redhat.com> In-Reply-To: <20210517184808.3562549-1-jsnow@redhat.com> References: <20210517184808.3562549-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emanuele Giuseppe Esposito , Eduardo Habkost , John Snow , Wainer dos Santos Moschetta , Cleber Rosa , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) One less file resource to manage, and it helps quiet some pylint >=3D 2.8.0 warnings about not using a with-context manager for the open call. Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Cleber Rosa --- python/qemu/machine.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/python/qemu/machine.py b/python/qemu/machine.py index 6e44bda337e..41f51bd27d0 100644 --- a/python/qemu/machine.py +++ b/python/qemu/machine.py @@ -223,9 +223,8 @@ def send_fd_scm(self, fd: Optional[int] =3D None, assert fd is not None fd_param.append(str(fd)) =20 - devnull =3D open(os.path.devnull, 'rb') proc =3D subprocess.Popen( - fd_param, stdin=3Ddevnull, stdout=3Dsubprocess.PIPE, + fd_param, stdin=3Dsubprocess.DEVNULL, stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.STDOUT, close_fds=3DFalse ) output =3D proc.communicate()[0] @@ -393,7 +392,6 @@ def _launch(self) -> None: """ Launch the VM and establish a QMP connection """ - devnull =3D open(os.path.devnull, 'rb') self._pre_launch() self._qemu_full_args =3D tuple( chain(self._wrapper, @@ -403,7 +401,7 @@ def _launch(self) -> None: ) LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args)) self._popen =3D subprocess.Popen(self._qemu_full_args, - stdin=3Ddevnull, + stdin=3Dsubprocess.DEVNULL, stdout=3Dself._qemu_log_file, stderr=3Dsubprocess.STDOUT, shell=3DFalse, --=20 2.30.2 From nobody Fri May 17 03:54:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621279318; cv=none; d=zohomail.com; s=zohoarc; b=bUePWnxPEjsiDnMtaRbIyBf9slGu9BEY9okFPY5PnN9P4WiN4L1zvc/dCyUNVLBnt+kfaun+zSwrUF0+G5CH6HbpPbhwA6Eb+DpVBtqipHdJAx75CGIiNoC6MHuiYv6gHWWfAy8ysz6oqivRT6dHqswoq8e4xhgsPjyxlYUbmJY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621279318; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EIdjOIYQU/8dr4ot+ceebUgIw/IQfCn148/ZsV5GQUc=; b=VwcysRqxzzAGsfNIGO/pp5pOzSdck9bu5g6A5RtaDYUuGiyitrMmIVBxsBI8HsmSzTKGxxLFYW0dkpnuY/5zNupuoR/jBIcKUi0U7Zr50fAEIDT0uz1DrS6BJtqEMj26MvUYcvncQ+xjZZD4EZGM27AsIeJDO+CJPXxwCszLl8k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162127931807870.04675870743222; Mon, 17 May 2021 12:21:58 -0700 (PDT) Received: from localhost ([::1]:45070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liioP-00007i-1W for importer@patchew.org; Mon, 17 May 2021 15:21:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42772) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHu-00017s-7i for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:38854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHr-0006vM-L4 for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:21 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-T-xyvXDCNdmy8VkmRU7QTQ-1; Mon, 17 May 2021 14:48:17 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4BB36A40C5 for ; Mon, 17 May 2021 18:48:16 +0000 (UTC) Received: from scv.redhat.com (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 730771F6; Mon, 17 May 2021 18:48:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621277299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EIdjOIYQU/8dr4ot+ceebUgIw/IQfCn148/ZsV5GQUc=; b=NGm1pmly2VO5X5wKP8KoopA/LDs+wPuY00WXJQ/qGSQKFHLJpMep8AHKI05NdG+QQtGj73 CW8jK3AflJFGvIrOHzDfUNCvcqPGymvuy3IR8MewnC4wtW2bUlweDEka6alhK0p4OTxpMR Ql2OhODCbhx6jysMNH3iBrJO5XSzg5s= X-MC-Unique: T-xyvXDCNdmy8VkmRU7QTQ-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 3/6] python/machine: use subprocess.run instead of subprocess.Popen Date: Mon, 17 May 2021 14:48:05 -0400 Message-Id: <20210517184808.3562549-4-jsnow@redhat.com> In-Reply-To: <20210517184808.3562549-1-jsnow@redhat.com> References: <20210517184808.3562549-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emanuele Giuseppe Esposito , John Snow , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" use run() instead of Popen() -- to assert to pylint that we are not forgetting to close a long-running program. Signed-off-by: John Snow Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa --- python/qemu/machine.py | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/python/qemu/machine.py b/python/qemu/machine.py index 41f51bd27d0..2e55e2c8bd8 100644 --- a/python/qemu/machine.py +++ b/python/qemu/machine.py @@ -223,13 +223,16 @@ def send_fd_scm(self, fd: Optional[int] =3D None, assert fd is not None fd_param.append(str(fd)) =20 - proc =3D subprocess.Popen( - fd_param, stdin=3Dsubprocess.DEVNULL, stdout=3Dsubprocess.PIPE, - stderr=3Dsubprocess.STDOUT, close_fds=3DFalse + proc =3D subprocess.run( + fd_param, + stdin=3Dsubprocess.DEVNULL, + stdout=3Dsubprocess.PIPE, + stderr=3Dsubprocess.STDOUT, + check=3DFalse, + close_fds=3DFalse, ) - output =3D proc.communicate()[0] - if output: - LOG.debug(output) + if proc.stdout: + LOG.debug(proc.stdout) =20 return proc.returncode =20 --=20 2.30.2 From nobody Fri May 17 03:54:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621279870; cv=none; d=zohomail.com; s=zohoarc; b=ePeKZ2tsiFwQv20ZMmovJAL/zgvk5LJw4tONaUkJozfLXoquvaFZjsVqpuIgtZbSqIjm1N8vaE347UaJ/hY6k5F3OSRuVRsotC1wR+AAi49pFlS2FFftuVHXZqvuDR4e9BtxeuLeBgS1HxtVbOEO89mzFUVE9ohfN0F6kstti90= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621279870; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uBvBDPav6xvmQm82GofvgIrCGu6g8/LKkdDHgtH1lZ8=; b=ApVFjauKyUG/BUw8cjIoO2jZWTnTS4X5MHZ272/zldNd9S+vBu8IF0yd2JwtDDI3oG+hIYlgEDf0jVpLtvmRwy29fJRXAkWaSUhhOwBtuYLURfKWXHn9O/SSi4nO/vaY5nfKdpo7XmmaiByfIN43Pw0VavouXge7dCLDQWBGEkc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621279870341227.79307764100065; Mon, 17 May 2021 12:31:10 -0700 (PDT) Received: from localhost ([::1]:48932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liixJ-0005H4-8e for importer@patchew.org; Mon, 17 May 2021 15:31:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHz-0001MY-SU for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHs-0006wj-Qd for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:27 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-551-_Q_RtSHLMRy31bta7TOH7w-1; Mon, 17 May 2021 14:48:18 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 850E980006E for ; Mon, 17 May 2021 18:48:17 +0000 (UTC) Received: from scv.redhat.com (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 78E4B19C46; Mon, 17 May 2021 18:48:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621277300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uBvBDPav6xvmQm82GofvgIrCGu6g8/LKkdDHgtH1lZ8=; b=VZOolZhC0iDet/Aznp9KxjLbKwdyBrWj2+pnVzPI8oK1d863Mq/o6m+cbcVgXuS8SKvwlU VyaYRAh0Sz+qLSDxeycNChJwFvWWPAytKUMgC/bkZG91UY6zhDMf+u9Zt1tfnhiI5PauMZ j3HQi1/kZIO4CmJmEBw42Os0K6xEQ08= X-MC-Unique: _Q_RtSHLMRy31bta7TOH7w-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 4/6] python/console_socket: Add a pylint ignore Date: Mon, 17 May 2021 14:48:06 -0400 Message-Id: <20210517184808.3562549-5-jsnow@redhat.com> In-Reply-To: <20210517184808.3562549-1-jsnow@redhat.com> References: <20210517184808.3562549-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emanuele Giuseppe Esposito , John Snow , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We manage cleaning up this resource ourselves. Pylint should shush. Signed-off-by: John Snow Reviewed-by: Cleber Rosa --- python/qemu/console_socket.py | 1 + 1 file changed, 1 insertion(+) diff --git a/python/qemu/console_socket.py b/python/qemu/console_socket.py index 87237bebef7..8c4ff598ad7 100644 --- a/python/qemu/console_socket.py +++ b/python/qemu/console_socket.py @@ -39,6 +39,7 @@ def __init__(self, address: str, file: Optional[str] =3D = None, self.connect(address) self._logfile =3D None if file: + # pylint: disable=3Dconsider-using-with self._logfile =3D open(file, "bw") self._open =3D True self._drain_thread =3D None --=20 2.30.2 From nobody Fri May 17 03:54:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621278542; cv=none; d=zohomail.com; s=zohoarc; b=WZ2p7fcKK9qCo/BGCKYoS9GEMCiMhoEVNq9lRVulmqg7l3TDgfaVxE2k+UMjbjISHruAwjcLzcXhiNSR99xJmQwoo8CPshHJHIHHrho7NbaCPCqb3w+YhQrLKHboRONh18J2KJqWo1ERPv2Yaw9AX9hBYQ3GQJazBNR5VRRH9TA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621278542; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=pmnghhsnUzWbhD2nTSMoSTOwXPhtYm3cPAUtB3aZmyg=; b=G9EQR0ZgQrGFDjkprQKFTIaEVBkhENKaGDcBHpUhtjPDnd01za6+9US/ccIQ0Rrx7w7uGPKvffPFidHRYy9iwS9mcXAGNZpvXKgXguJVetdlb8RlGLWBE3U+AqDbQqVAu30sMR3S+1q6WoKh4j0T51txrhnzK8Km3XbRf7cWYK0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1621278542227822.8207521967807; Mon, 17 May 2021 12:09:02 -0700 (PDT) Received: from localhost ([::1]:39470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liibs-0002DJ-Vn for importer@patchew.org; Mon, 17 May 2021 15:09:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHw-0001H9-FT for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54147) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHu-0006yl-Mb for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:24 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-fK3u9zwHMgee4ogN3k2nKw-1; Mon, 17 May 2021 14:48:20 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 741FB1854E21 for ; Mon, 17 May 2021 18:48:19 +0000 (UTC) Received: from scv.redhat.com (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id C41EB19C46; Mon, 17 May 2021 18:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621277302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pmnghhsnUzWbhD2nTSMoSTOwXPhtYm3cPAUtB3aZmyg=; b=TeRUiZ8h7kbwSHxzL/Tg6ahc4FkT9TnAR6y+gv+HLFnpTqDOTlSrbr5K7+o553dFy27U9x f/cxTuJbYaRJq7QNZfNQzXknSceIZ0RNTwty46rUK8in/A3ADxIQrDAnkHu4Funzkln4Qb jcUtYZprpTj5toM6vYiNY9BAoSh8/n4= X-MC-Unique: fK3u9zwHMgee4ogN3k2nKw-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 5/6] python/machine: Disable pylint warning for open() in _pre_launch Date: Mon, 17 May 2021 14:48:07 -0400 Message-Id: <20210517184808.3562549-6-jsnow@redhat.com> In-Reply-To: <20210517184808.3562549-1-jsnow@redhat.com> References: <20210517184808.3562549-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emanuele Giuseppe Esposito , John Snow , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Shift the open() call later so that the pylint pragma applies *only* to that one open() call. Add a note that suggests why this is safe: the resource is unconditionally cleaned up in _post_shutdown(). _post_shutdown is called after failed launches (see launch()), and unconditionally after every call to shutdown(), and therefore also on __exit__. Signed-off-by: John Snow Reviewed-by: Wainer dos Santos Moschetta Reviewed-by: Cleber Rosa --- python/qemu/machine.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/python/qemu/machine.py b/python/qemu/machine.py index 2e55e2c8bd8..f021127f0fc 100644 --- a/python/qemu/machine.py +++ b/python/qemu/machine.py @@ -308,7 +308,6 @@ def _pre_launch(self) -> None: self._temp_dir =3D tempfile.mkdtemp(prefix=3D"qemu-machine-", dir=3Dself._test_dir) self._qemu_log_path =3D os.path.join(self._temp_dir, self._name + = ".log") - self._qemu_log_file =3D open(self._qemu_log_path, 'wb') =20 if self._console_set: self._remove_files.append(self._console_address) @@ -323,6 +322,11 @@ def _pre_launch(self) -> None: nickname=3Dself._name ) =20 + # NOTE: Make sure any opened resources are *definitely* freed in + # _post_shutdown()! + # pylint: disable=3Dconsider-using-with + self._qemu_log_file =3D open(self._qemu_log_path, 'wb') + def _post_launch(self) -> None: if self._qmp_connection: self._qmp.accept() --=20 2.30.2 From nobody Fri May 17 03:54:52 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621279494; cv=none; d=zohomail.com; s=zohoarc; b=Jy5JFNTBCO+jvN4Cis0hes9ed38zOtitpdzvZRfWc0ICiqxJDExm9LOohqWcy49yhwIBQWv9UgInp9eLz8T143wTqkFeGFVjtvsgyl/vYLTgRIP14MVWSTJwZ85Ywqst3BizgByPEnLo1H+GIMssR5kIWT5mtuS93z1EUFytO38= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621279494; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MGuqrqm51MoXkPciCqG5OPj563q/2p+OEhh+NKfsXDI=; b=UGQIXhZaW3+Oy6V/mSTfTMjcBfuPNfXm0gt+bXDSbpGUH9iyJnLVNyOJKlhAoQ+tr3ldy9KDQk9EryiAUQtN2LYlVivfYiD8tqMqG+3PUJAw2V2Nk/TSs8pgGHeuxIKX5glnSg4sTsHQB1dvJjAIuuBfEnG52xlkHBrzbbdbuHQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 162127949410366.74743289653998; Mon, 17 May 2021 12:24:54 -0700 (PDT) Received: from localhost ([::1]:53468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1liirF-0005r5-2w for importer@patchew.org; Mon, 17 May 2021 15:24:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHx-0001K0-Fj for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31973) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1liiHv-0006yx-UD for qemu-devel@nongnu.org; Mon, 17 May 2021 14:48:25 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-137-P7looOccNHyIeobd4AYj6Q-1; Mon, 17 May 2021 14:48:21 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B72B3107ACCD for ; Mon, 17 May 2021 18:48:20 +0000 (UTC) Received: from scv.redhat.com (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 909C319C46; Mon, 17 May 2021 18:48:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621277303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MGuqrqm51MoXkPciCqG5OPj563q/2p+OEhh+NKfsXDI=; b=ZEJviAuG0YKqtwVY51knDGM3rXyCWoKraCR+xpX32AYBhkHcUlPWZyPhDzf7fEcNvULdjM Vz5mF/3ctYwFUgA3e+wQG2q+ObnicSWCXyy3H9VN+QSOjYw8uz1KiUOGtiDaBkWJ/YIhcW by3yaEaJYMfw0OrIT5FZQEonSkivSZQ= X-MC-Unique: P7looOccNHyIeobd4AYj6Q-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 6/6] python/machine: disable warning for Popen in _launch() Date: Mon, 17 May 2021 14:48:08 -0400 Message-Id: <20210517184808.3562549-7-jsnow@redhat.com> In-Reply-To: <20210517184808.3562549-1-jsnow@redhat.com> References: <20210517184808.3562549-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.374, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emanuele Giuseppe Esposito , John Snow , Eduardo Habkost , Wainer dos Santos Moschetta , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" We handle this resource rather meticulously in shutdown/kill/wait/__exit__ et al, through the laborious mechanisms in _do_shutdown(). Quiet this pylint warning here. Signed-off-by: John Snow Reviewed-by: Cleber Rosa --- python/qemu/machine.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/python/qemu/machine.py b/python/qemu/machine.py index f021127f0fc..06058d89e83 100644 --- a/python/qemu/machine.py +++ b/python/qemu/machine.py @@ -407,6 +407,9 @@ def _launch(self) -> None: self._args) ) LOG.debug('VM launch command: %r', ' '.join(self._qemu_full_args)) + + # Cleaning up of this subprocess is guaranteed by _do_shutdown. + # pylint: disable=3Dconsider-using-with self._popen =3D subprocess.Popen(self._qemu_full_args, stdin=3Dsubprocess.DEVNULL, stdout=3Dself._qemu_log_file, --=20 2.30.2