From nobody Mon Feb 9 19:07:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621276809; cv=none; d=zohomail.com; s=zohoarc; b=d8/EpzI/I/ZXNdaOlZWCnKPB9rdlrt3BCO1xp5b/bV8zNrbkIdw02GpMLe7cL4x8YobZ9ly+93NvADNV5IZfkm/WMYKhxIYH3Q9//jWGDm2DpUeEzU5YpM9D+4N10bC4y95MBNGEDq5yebuiTKI9VJTYfRSyiELtBZem8vHMHEY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621276809; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=wKTvIJltaWyJ3tXssokHbyKTt2E/IQqH3Pybl80dLEU=; b=JjQK9bjZhBqEaY8I1UdV9ADsnThsRLK1m/r/fcGneuGnbof44Kt4CrJPm+/5GZYRzC59UMSSeHV32MrQOwcsfYHirBDS3id4J/IThwWqeGFtJ7csYliaYCSoUlvat6Re9NAO2o3V7CKvXwfbcdQiyiJnxOcJVNkfBWI71nSc648= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1621276809527719.185924693121; Mon, 17 May 2021 11:40:09 -0700 (PDT) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-Y3qtbC6YM3uJ4pvIXXdTnQ-1; Mon, 17 May 2021 14:40:07 -0400 Received: by mail-ed1-f69.google.com with SMTP id m6-20020aa7c4860000b029038d4e973878so236119edq.10 for ; Mon, 17 May 2021 11:40:06 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id q16sm8866603edw.87.2021.05.17.11.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 11:40:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621276808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wKTvIJltaWyJ3tXssokHbyKTt2E/IQqH3Pybl80dLEU=; b=SdTacydVFveCYVcq9sk2lp+qy0RnwGDzYWf3qdqQZBUaMSvwQiBlEoDjeXZeWuTICKO0FT UipfWUsMWLC6vC5iJTt1+yVz83hf0+k+VpLLK+NL5nqgLBnq4kuIkSX9WjtDZS534GRXdQ JlNI7sEe4a/YHyqMD3hvLe14ntgEYG8= X-MC-Unique: Y3qtbC6YM3uJ4pvIXXdTnQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wKTvIJltaWyJ3tXssokHbyKTt2E/IQqH3Pybl80dLEU=; b=Wwi5BLnqxNWjCzodfVk5UAd7e9p1ezoeBEd+E4bYROqC7AksOcnUD67V9HWexNDAHy hpV/TCatXwZy8aWkJWuzs+fklk6GIpD539D223ai1wNo5Z+A5dULi6rzE9DYK9fQxpuH 9CH1WFALxdJgaaapZ5vLrPp7EKDbPJXn40cGpJ07oCUrtfwy/5LB6kVUh9cFBghQX8ym K6z6xOGrOOd3VNF8nXgYxUmOlyXy5ZNeMEf8bZXum6HngBJQbt5S6hcI8klnovMa5hbI rkKHFGt24eD88azhI25N+3ucjEGQLH0LbnblabvrOLCSLuSdvFXhImf8otHF/qaVG8YZ STXQ== X-Gm-Message-State: AOAM530ZL5SiLa94YEIfItLMy9yS6zQg7iKCmhsoamoYc6kDmDG8NVXd GWM8DjE9m1qAIzRIQMAwUBygItU6D5VXQmgAJbSAau/va0uj1XAYeGr+2wUP4Dq+dilMWAab9OJ 7c/KxYdSa4T7Y5A== X-Received: by 2002:a05:6402:2802:: with SMTP id h2mr1605982ede.243.1621276805860; Mon, 17 May 2021 11:40:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7jyf8vGOqGKZDXd4Jwn8QOQH9iiemYyUvrD4WA2OL7N4ZpGzz+VuDBv5XjUEDWISnYUSl3w== X-Received: by 2002:a05:6402:2802:: with SMTP id h2mr1605968ede.243.1621276805693; Mon, 17 May 2021 11:40:05 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, John Snow Cc: Richard Henderson , qemu-block@nongnu.org, Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland Subject: [PATCH v4 2/9] hw/block/fdc: Replace disabled fprintf() by trace event Date: Mon, 17 May 2021 20:39:47 +0200 Message-Id: <20210517183954.1223193-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210517183954.1223193-1-philmd@redhat.com> References: <20210517183954.1223193-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Reviewed-by: John Snow Acked-by: Mark Cave-Ayland Reviewed-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/fdc.c | 7 +------ hw/block/trace-events | 1 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a825c2acbae..1d3a0473678 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -1242,12 +1242,7 @@ static void fdctrl_external_reset_isa(DeviceState *d) =20 static void fdctrl_handle_tc(void *opaque, int irq, int level) { - //FDCtrl *s =3D opaque; - - if (level) { - // XXX - FLOPPY_DPRINTF("TC pulsed\n"); - } + trace_fdctrl_tc_pulse(level); } =20 /* Change IRQ state */ diff --git a/hw/block/trace-events b/hw/block/trace-events index fa12e3a67a7..306989c193c 100644 --- a/hw/block/trace-events +++ b/hw/block/trace-events @@ -3,6 +3,7 @@ # fdc.c fdc_ioport_read(uint8_t reg, uint8_t value) "read reg 0x%02x val 0x%02x" fdc_ioport_write(uint8_t reg, uint8_t value) "write reg 0x%02x val 0x%02x" +fdctrl_tc_pulse(int level) "TC pulse: %u" =20 # pflash_cfi01.c # pflash_cfi02.c --=20 2.26.3