From nobody Mon Feb 9 17:37:40 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621276807; cv=none; d=zohomail.com; s=zohoarc; b=IKhGIvQ1g15igMwwvQW9s/FtxhVYp5iqWrjHxGbXtQGaO54WpwPLRx6GYsogcQguSnli9qaE5cVhH03z9Mu8me3sDBegdPfOxkok/WNODMjOFnJ66g1JgVjC+ZPzlUg5QxwiXCgnImW6JM+kyXVmSOwQr0FoeJYRi9G6wx7paGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621276807; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=yIx6qnixzEdCFqcaxOcBVgzeXQKdqlMaGZGGlAdFf2k=; b=besrspQRfsW8Dknsq/2rX/qdLXx7fIBcfMujLo6icUJjoFiFSQXiAo9217KoXLQaONPdvT96znEU2D13K7bp22IkYgUW866KBqAefQ54YB1uLZmOVe7OO+eUfa1H6i9hMwBM6uqe82uLN3dEihNG66ET5SKz788TpDCN0819EYw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621276807563915.6754195936113; Mon, 17 May 2021 11:40:07 -0700 (PDT) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-2DJzTRSwNjSjaoGEQF4SAg-1; Mon, 17 May 2021 14:40:02 -0400 Received: by mail-ed1-f70.google.com with SMTP id y15-20020aa7d50f0000b02903885ee98723so4375895edq.16 for ; Mon, 17 May 2021 11:40:02 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id k2sm9202779ejj.30.2021.05.17.11.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 11:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621276806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yIx6qnixzEdCFqcaxOcBVgzeXQKdqlMaGZGGlAdFf2k=; b=GePwlybGMF1g+LHs1/KelyKwsiT3Kzvvz1+Xz2y49HGrLjHGTE2jnZ0qQwYRmC/Z12rv1Y a5Z5Cj6wxgRvgaYEbr955YjS7HkNgkd6uyG8va3s9TFjQltAD5ADWeIrA+GXAt4M9z80aR zVrS0+9eGKsrPA3Q2xjaTZWngc73TG8= X-MC-Unique: 2DJzTRSwNjSjaoGEQF4SAg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yIx6qnixzEdCFqcaxOcBVgzeXQKdqlMaGZGGlAdFf2k=; b=UqVfCCtLy3AJ864IONuFZ0u4UpIr7KrI1q4zvH2QLDvj/uaE67/4qbVhrMYhUHAAky Hzh2tGY1TKfmkYu69PN55aFdhvRfsyoNI8+guv01lBFFerSFEok4U5+QxUGWZfck1e0q 6Fe5sZ+g7ZiI5wBBaSFNpOyGTRds0Kv1S1mwklohY8zSLt1JpR0CQ+tYLe57UBjI0Uuc bI0S+KOzqzd8102PZ7Fd4ytodTMVbYGA/S0dJ9Ww5ZvOY+P2fIGUhCMo6ayYqgfiRkcN kvAaWcXR6R0SOzjZKjVG8lCTvBkD+iRiOeqWtgas8P287IfU85mRYr9rR+fQWxl4JzZn /csg== X-Gm-Message-State: AOAM5334jNN8pZf2ap0itwDwHchPfIHoZxTzc40sC3ozFA9GRS1SMYjv nPVJr+/BzY0NjkCQc1NyHFKjntP/gCQMiDSbdNsqEiDV0xy0diODd/Wi6ygzkzW3OB3W/rcMdS6 3L4757UHKOgCE6A== X-Received: by 2002:a17:906:c010:: with SMTP id e16mr1403689ejz.214.1621276801215; Mon, 17 May 2021 11:40:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzLUZnW510mcSQ23kx0+z043RTUUa0WDX5e+TNnBDGkdInRzmPVm7Js7rH9h7cVsUo/WHNXXw== X-Received: by 2002:a17:906:c010:: with SMTP id e16mr1403673ejz.214.1621276801103; Mon, 17 May 2021 11:40:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, John Snow Cc: Richard Henderson , qemu-block@nongnu.org, Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 1/9] hw/isa/Kconfig: Fix missing dependency ISA_SUPERIO -> FDC Date: Mon, 17 May 2021 20:39:46 +0200 Message-Id: <20210517183954.1223193-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210517183954.1223193-1-philmd@redhat.com> References: <20210517183954.1223193-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) isa_superio_realize() calls isa_fdc_init_drives(), which is defined in hw/block/fdc.c, so ISA_SUPERIO needs to select the FDC symbol. Reported-by: John Snow Fixes: c0ff3795143 ("Introduce a CONFIG_ISA_SUPERIO switch for isa-superio.= c") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/isa/Kconfig b/hw/isa/Kconfig index 55e0003ce40..7216f66a54a 100644 --- a/hw/isa/Kconfig +++ b/hw/isa/Kconfig @@ -17,6 +17,7 @@ config ISA_SUPERIO bool select ISA_BUS select PCKBD + select FDC =20 config PC87312 bool --=20 2.26.3