From nobody Mon Feb 9 19:06:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100252; cv=none; d=zohomail.com; s=zohoarc; b=hyKgYH7+nXm8scBbIuxS4ttLPAEB5cZQWPokhQHbNpQt0CxKMqxlzsDhRSRvqhR/othT13TBZ9Gowou4zDRtSbXL8jOPtUGIFEK06PhOs5hhAABWc2E7ttoJTnPP4w61G8sjw4J6rTeiicYGwpg+4QRuMZX/Rs7rcECt/O/G1Gg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100252; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=k/10dvLOYecsAQmUGPkwxrFRTrjd5+JzocYSZHgeVfk=; b=UlqGBg0kcRc1iIQTmloZ/PKe6XkbEnnlqEoQ+WQEl+8rrNfdaEq09zOukyES0YTs3VRa5VDY5ZP/sqcbzQ0ff11bDU+HUczqKH+DmnsDtuSHTiXoo6UfrvQnO0AKCjV7xqAb9jWbSsjWwigv3FYmwM+RZ9e8hfst0SXqDGvMHig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16211002527141015.7979605323914; Sat, 15 May 2021 10:37:32 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-l41qwlrGN7CjiLhM0g826g-1; Sat, 15 May 2021 13:37:29 -0400 Received: by mail-wr1-f72.google.com with SMTP id f1-20020adf9f410000b029010e8048a0e3so1410339wrg.4 for ; Sat, 15 May 2021 10:37:29 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id q3sm8260103wrr.43.2021.05.15.10.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k/10dvLOYecsAQmUGPkwxrFRTrjd5+JzocYSZHgeVfk=; b=Ez/NEZ50nSNp3weLm451lazCKzrMGqFAyL2R27w61Q7JRBpqLa8LLAqBxSrScSt9hLgmKZ u00GK6iHKkrKmyVQa5uv4lKnJZZRLhPWEGgoNiY11YlkHXuc+OL6vjoCC5g/7ccWC6Igv+ 4vpTi7JZl4JYJJNfJfyD/IfYCB/jpp0= X-MC-Unique: l41qwlrGN7CjiLhM0g826g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k/10dvLOYecsAQmUGPkwxrFRTrjd5+JzocYSZHgeVfk=; b=NEJo+whda+3da5lT85bomCKWSH8xaG2VrWV7ZL2yGNvdCFxe1i1BDv8vMJOnyVpsQd ZWE3W5OyFqmLWHC3ScMbVviEZHdgb7pHKGMJe7ryUOkukliESPpS7An6/ERQWin0nGbj y6xd2vknwjPsn02Feh5QS67p0uf0YmX0LSGNgFU97JB/EJD51pYUfxOL2vmdpMDKRs2/ U07f2MLnKnl6r9X9JMnOfih/w2QZdgxO9sitXG3a/iuDIldQ04gaRJtjZn/86iKSnao4 rj9VPD7EJTFsT3LND9t9g5gsIU+/eWBRBrKieu6wbPBJpu1PrUvgTtbBZBoB+0QJ+Jgw +brg== X-Gm-Message-State: AOAM533m//iiLTRNsQginvz4kwRsNaaNOWpGxX4Iiy+4mQBwwhp8G0xf 1P3GnwT0LOY07tl/afMrRdCv+yLAuLRbiPLW7vks0ILGSY78apL5q2Jm2IUIsXrjEvFBtS7nx/K o9Oz0QigfV1DTnA== X-Received: by 2002:a05:600c:4eca:: with SMTP id g10mr15474334wmq.180.1621100248599; Sat, 15 May 2021 10:37:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBI/OGWHQJw95jKNSYxvduONqDOFNeiW3sAzEu0dZbev1126HPcjQkDuw1xmVEaAqMlhE2ew== X-Received: by 2002:a05:600c:4eca:: with SMTP id g10mr15474322wmq.180.1621100248461; Sat, 15 May 2021 10:37:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bin Meng , John Snow , qemu-block@nongnu.org (open list:IDE) Subject: [PATCH v2 02/12] hw/ide/Kconfig: Add missing dependency PCI -> IDE_QDEV Date: Sat, 15 May 2021 19:37:06 +0200 Message-Id: <20210515173716.358295-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd= _table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, Drive= Info *drive) include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int= unit, DriveInfo *drive); Fix the correct symbol dependency to avoid build failure when deselecting some machines: /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_d= evs': hw/ide/pci.c:491: undefined reference to `ide_create_drive' Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: John Snow --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 8e2c8934549..dd85fa3619f 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -8,7 +8,7 @@ config IDE_QDEV config IDE_PCI bool depends on PCI - select IDE_CORE + select IDE_QDEV =20 config IDE_ISA bool --=20 2.26.3