From nobody Mon Feb 9 12:26:11 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100247; cv=none; d=zohomail.com; s=zohoarc; b=Lbz8tNaNV7fbANKBqmO9cIp+yRnPs9TIV3grzfKhkh7vetSmoRh2m0+CX4wyVhOZYnx/t/6nq4HM/1tJxPAh6OV8/lTu88FdXbUbXnFnNsOhaDKcvjOYZKgv9ecEtMRfl6EVp1mJAqz5JpeG+zbN6U6c2ZUK2d3MO0McFXO6yDU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100247; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=wRNuc1gJMH1hkdyUyCI+kE/vTfEuz1keBAJWrXytcEA=; b=aQ323HfBB4DYnsKHFN2ZLQSPQn0o+9ZtSgrR4nuE7kpbzhZIZQrsDAzkIarEWTyY3PwF5CatM4gJsnuC8Qx4jUCGYb3X8rYLywNmLXZOUWbkGPoZKqpus3qBqEKeMRfwtnK88hgJOXSyFJvS7+yBwODob3l0NogkoD6QU4l/Vn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621100247745955.3449859878714; Sat, 15 May 2021 10:37:27 -0700 (PDT) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-407-9n41hozANe-GthGn41lJ_w-1; Sat, 15 May 2021 13:37:24 -0400 Received: by mail-wm1-f69.google.com with SMTP id 12-20020a1c010c0000b0290176491efde9so100058wmb.4 for ; Sat, 15 May 2021 10:37:24 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id a17sm2052985wrt.53.2021.05.15.10.37.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wRNuc1gJMH1hkdyUyCI+kE/vTfEuz1keBAJWrXytcEA=; b=d6lHMr2j3oIQOsSwOy+mdnThkPLAzy02UaCx3GNgfYG4XNHWUX+G3wwme3Zt9hEucC4XkA XTpa0AtnL9olpvAhbhHbNx4jreU2lfdEpTefdhHE2TawZi7oT5HShluPnrIAv1+8XzfRV5 z/GasMvTmd17joJzMPhiu0XZd/MRzqQ= X-MC-Unique: 9n41hozANe-GthGn41lJ_w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wRNuc1gJMH1hkdyUyCI+kE/vTfEuz1keBAJWrXytcEA=; b=Nyv8fmkJeVNwHqm3l6B3/3BPbEZfPNB1QabphgvGBMPgAvGk3PcuysSZTGppf3Hcf4 khCnkT+bNqU0DamutmcW9ouRZWPoLqTr30Zs0hZuacF8utG7/5W8plcFsdSGZNVvlw5E XaGCEnKXgfEgDj8jEUtxDBIABH9ug/cVsCTgSiAc46NtQD3ZGd0mH0LQJeajNy9zE4Ze JP9Zvg13cIHBrnEgCSL0lqbz8IyTTGMStbRKbCfWeUOXwzWgUPo7ISGSXnzoqNh+7K2K G1trATpFZc1EfdSuiR9ZumlLNTzgGRn1bwxWlXBfDLCKHBUMbG+ryroMLXebUiGoxXrp yrTw== X-Gm-Message-State: AOAM5302qsyC5cWS+ii3n3mRwfIE0CzSwnEJ5w6zHZhCGg1yFelXE+kw lcFEmZNVFnHgrujisa5Fvxc0UcDgf1o1+aHC9JuAMDXMnbGn1ZvMeY8z7FqA+V8zwzCc8n49nCn 6XjJ9BZJOdogt+A== X-Received: by 2002:a05:600c:4896:: with SMTP id j22mr14966967wmp.156.1621100243854; Sat, 15 May 2021 10:37:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyz2Ad0xL16eEWXWXC6gvEGKc994vEjz53rI4Fm7kubWnLVp0RG1vMfoeBQ+BzwAG7JYbnrQA== X-Received: by 2002:a05:600c:4896:: with SMTP id j22mr14966953wmp.156.1621100243687; Sat, 15 May 2021 10:37:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , "Michael S. Tsirkin" , Marcel Apfelbaum , Richard Henderson , Eduardo Habkost , Igor Mammedov , Greg Kurz Subject: [PATCH v2 01/12] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Date: Sat, 15 May 2021 19:37:05 +0200 Message-Id: <20210515173716.358295-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Per the kconfig.rst: A device should be listed [...] ``imply`` if (depending on the QEMU command line) the board may or may not be started without it. This is the case with the NVDIMM device (it is certainly possible to start a machine without NVDIMM) , so use the 'imply' weak reverse dependency to select the symbol. Acked-by: Paolo Bonzini Acked-by: David Gibson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Bin Meng --- default-configs/devices/ppc64-softmmu.mak | 1 - hw/arm/Kconfig | 1 + hw/i386/Kconfig | 1 + hw/mem/Kconfig | 2 -- hw/ppc/Kconfig | 1 + 5 files changed, 3 insertions(+), 3 deletions(-) diff --git a/default-configs/devices/ppc64-softmmu.mak b/default-configs/de= vices/ppc64-softmmu.mak index ae0841fa3a1..cca52665d90 100644 --- a/default-configs/devices/ppc64-softmmu.mak +++ b/default-configs/devices/ppc64-softmmu.mak @@ -8,4 +8,3 @@ CONFIG_POWERNV=3Dy =20 # For pSeries CONFIG_PSERIES=3Dy -CONFIG_NVDIMM=3Dy diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index b887f6a5b17..67723d9ea6a 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -6,6 +6,7 @@ config ARM_VIRT imply VFIO_PLATFORM imply VFIO_XGMAC imply TPM_TIS_SYSBUS + imply NVDIMM select ARM_GIC select ACPI select ARM_SMMUV3 diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 7f91f30877f..66838fa397b 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -23,6 +23,7 @@ config PC imply TPM_TIS_ISA imply VGA_PCI imply VIRTIO_VGA + imply NVDIMM select FDC select I8259 select I8254 diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig index a0ef2cf648e..8b19fdc49f1 100644 --- a/hw/mem/Kconfig +++ b/hw/mem/Kconfig @@ -7,6 +7,4 @@ config MEM_DEVICE =20 config NVDIMM bool - default y - depends on (PC || PSERIES || ARM_VIRT) select MEM_DEVICE diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index e51e0e5e5ac..66e0b15d9ef 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -3,6 +3,7 @@ config PSERIES imply PCI_DEVICES imply TEST_DEVICES imply VIRTIO_VGA + imply NVDIMM select DIMM select PCI select SPAPR_VSCSI --=20 2.26.3