From nobody Mon Feb 9 19:06:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1621100285; cv=none; d=zohomail.com; s=zohoarc; b=S3iUjHiKrkmuFBwTek/Q98EApb7A0yLBnFGeAIS2e1ZMJ4deF8moEVE3d5RZ2Dv8It7TNdtjN0REvUxxrd0rEnEBlmRCgbM5PrgXfTffbHLmjKuZHoPngLMUC+k1JL+lzq0PgwamYXhHykHThaygGOx5z+RhD/Np0ZAY0TxzW7c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1621100285; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=yMKbvRHD0VVgAl/shSsvEL3fFV0zSLsEZF6v1iEj1U8=; b=g2eQ+8v8G/YReQGzBU6q0SRZHuovkJe1VQ9XX/8JRcdEReBVkjSDeQ+av88f0HfPnpJx5hQbWpeR6et6HeS6P4y5Ze9+MEL8Fhiq/+gc+dhjqTRRkzpG5vLYN1FeCfL/bvlqzyH4/FLEkyar1lAFcI4QAG3nLWNvqe47rZ4m78s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1621100285804993.6918827245881; Sat, 15 May 2021 10:38:05 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-419-Nq-U2C9sO7a8LULJOwtuog-1; Sat, 15 May 2021 13:38:02 -0400 Received: by mail-wm1-f72.google.com with SMTP id 12-20020a1c010c0000b0290176491efde9so100683wmb.4 for ; Sat, 15 May 2021 10:38:02 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id k6sm14457835wmi.42.2021.05.15.10.38.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 May 2021 10:38:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621100284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yMKbvRHD0VVgAl/shSsvEL3fFV0zSLsEZF6v1iEj1U8=; b=GecnskS1W4y3lxaZnmGbTFOL6jTM6nh82s3mCtmZdDsqUbd2gITQWaCVDGBGkTbPs9AJ8U 24ag4/DDxk5i7LByYgArbYJVRAAQrJFXWkhgG/r8atH6D8KvlNOaWwAXnhO7BxN45DQFgx qrtHygs8gP5i7QPvMaDnttY37YUFYHE= X-MC-Unique: Nq-U2C9sO7a8LULJOwtuog-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yMKbvRHD0VVgAl/shSsvEL3fFV0zSLsEZF6v1iEj1U8=; b=qFpE9uB5CQzyHue/ybIPIE/aZ2hsqQ4L7hBI3hGAwn8Y3cCyJNrUkhO02dCZ97TAmj ynACWeo6mNj0RK+aM7qgqGm7Qa1BCJUjGxKCzKJjJUXRFxsnvZO1YHSO1oTSCPN6GRTU b+0HpTietO06pAk1g+2Irw3nz0XOx1XSwcdamKDycfIbR0uwTGmBDbMjambeVf76urz+ RkCyOVNiKf3JGbyIDp3c+0ljnPe+Zn9XWqO4orJmVkU8eSM9hof3Ufl8c22UknxBxx7X uTy83WxXPz/IltO4nkQLh62LFuKAYGE3aU45OkukLEUSorz0UquhwNOSt64Ozevc5/nK SwEg== X-Gm-Message-State: AOAM531SaKyLrYFugvdwGGPlBXHeGPN3wiYG/U29IoZ3o+rQyPiXZdlN 3dihqB598/8DP1cSTdvRo1lGG3pxBNOqFC7uqExI10CqlhqEpeJoDyPrk3R8kyl3HZwWiD+b24d QHIjAZ6tVdMXZtw== X-Received: by 2002:a05:600c:4ca1:: with SMTP id g33mr19751669wmp.7.1621100281681; Sat, 15 May 2021 10:38:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzzdkdaJKsqQvEMuw/in8yhkYSzmz4ZUGj7uT9+EgpNyG/uYj5c6KEaDv2tlbB8+jf6n0nPnw== X-Received: by 2002:a05:600c:4ca1:: with SMTP id g33mr19751656wmp.7.1621100281560; Sat, 15 May 2021 10:38:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , Paolo Bonzini , qemu-riscv@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, BALATON Zoltan , David Gibson , Alistair Francis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 09/12] hw/pci-host/Kconfig: Add missing dependency MV64361 -> I8259 Date: Sat, 15 May 2021 19:37:13 +0200 Message-Id: <20210515173716.358295-10-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210515173716.358295-1-philmd@redhat.com> References: <20210515173716.358295-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) From: Philippe Mathieu-Daud=C3=A9 Looking at the MV64340 model source, there is a dependency on the 8259 interrupt controller: 523 case MV64340_PCI_1_INTERRUPT_ACKNOWLEDGE_VIRTUAL_REG: 524 /* FIXME: Should this be sent via the PCI bus somehow? */ 525 if (s->gpp_int_level && (s->gpp_value & BIT(31))) { 526 ret =3D pic_read_irq(isa_pic); 527 } 528 break; Add it to Kconfig to avoid the following build failure: /usr/bin/ld: libcommon.fa.p/hw_pci-host_mv64361.c.o: in function `mv64361= _read': hw/pci-host/mv64361.c:526: undefined reference to `isa_pic' /usr/bin/ld: hw/pci-host/mv64361.c:526: undefined reference to `pic_read_= irq' Fixes: dcdf98a9015 ("hw/pci-host: Add emulation of Marvell MV64361 PPC syst= em controller") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson Reviewed-by: BALATON Zoltan Reviewed-by: Bin Meng --- hw/pci-host/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig index 79c20bf28bb..9dc0d761815 100644 --- a/hw/pci-host/Kconfig +++ b/hw/pci-host/Kconfig @@ -76,3 +76,4 @@ config SH_PCI config MV64361 bool select PCI + select I8259 --=20 2.26.3