From nobody Mon May 13 17:38:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.54 as permitted sender) client-ip=209.85.208.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1620925968; cv=none; d=zohomail.com; s=zohoarc; b=es4Zlm+AWaRiZl3jpXNWEgBK1hzsY5Li6v1DlPKTBfJuFCE5yKx8wmAkiZO/Zl9vZxP0O65LVpGdP0rcJZNeYFXr44yOETZPJ/y0gV14S3F8R+YF0fXKZxTNAZjoLmuc/E2tPOnfbnsYij25+c1c32yCHLf4/tDTaBs4/JSqMjA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620925968; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=/l1vSGEiJ7pZLCdjOLk0Fo0Jde9DV8raYEKhS8kK0n4=; b=S4bhd1GsRJhM9VNLSJD/LSJX6cTldwmcBwyLiNeQrHmEQRmpEL9CH+YDomGvCc6JDLMJ9LFT8k4bb+ovd6SYOShBu73hI1eti+eiMvCnoqtSoaywrNCCf6oNbtl3C1ajHrOyrnnzTtm7wGAWqXlY1IbVCQyrIgCRq7keqJqRDOg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by mx.zohomail.com with SMTPS id 162092596899357.40093162065159; Thu, 13 May 2021 10:12:48 -0700 (PDT) Received: by mail-ed1-f54.google.com with SMTP id t15so4112500edr.11 for ; Thu, 13 May 2021 10:12:47 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id bw26sm2116597ejb.119.2021.05.13.10.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 10:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/l1vSGEiJ7pZLCdjOLk0Fo0Jde9DV8raYEKhS8kK0n4=; b=UCuXATJrpEf6Tqty49vUtWYai1jZMQx1i2smCXijmf7FkPCd3aZf/vG8Hvana7MNI3 aZxYPJYac0jgNDZaeIzIKZRXk2Zjccq5slRFK9DAW7uGrUk3Mv3JMJ7DfD1y6mpDOf9+ YqSPNIX4tcq7IFslmcVsh0GHcTmWW15croSSJHEqHFNbUiI8xieThjnzxFIvTDXQWQ93 us6kMR/DPArmPn0egiBYo+YoEzkJHY+dc0ocB90WQYqKT42GxY/fKIf7Ksfc+RKAZiGu UcW48BmZ0oCdl11S0LUbRgjvBMBX+ibdVthCcusp/McaZb6eaDMg6lnz6aOP7TljO7RE opEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=/l1vSGEiJ7pZLCdjOLk0Fo0Jde9DV8raYEKhS8kK0n4=; b=ias5uyh3JZiCdgI8LuxL4enKgSFNAt3CGNFFhQTocRFxqG37B6LhqsiktaG2RVX1kK 8xYxpWXzJoAKEBbsB+uhoRCsXzHpTmUYnN+VxA5L4Tv8iroAgs33LpF2RIWcJAnKywfJ n6Tf25EWJBIyzTK+THZmb1YBYF4bF03oeYWdi7qb1PR7eQOicgBha1FrefnnQUFGIRyW JKQSZui1Llo5DPHRHzW83aUv7FVZn3snIkkmalMenJEvOUsZP2NHy3OsDd+n8dkGkFJt KuuATOvyJyK58S8yzpMlEMT4Oo5/fFRWt3Y1W5rUWb0vAMJnUnSMhnT6k/hbLxuFRdF2 3Bbg== X-Gm-Message-State: AOAM533uh0ckwTUxCHDjygZbKdTO7mn2zOc6bMmW89fGEjXSiVyME6nY NtpQy0Cz1XW2RRmxmsL3Yyk= X-Google-Smtp-Source: ABdhPJysbxDRCUlTUBLPmSlsj+lOMRGc/o3fzkjAiNDuRH6wO6lg5aAGZL2IFNzm2XMypzrdEXFr4w== X-Received: by 2002:aa7:d9ca:: with SMTP id v10mr52277751eds.272.1620925966650; Thu, 13 May 2021 10:12:46 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Volker=20R=C3=BCmelin?= Subject: [PATCH] hw/input/ps2: Use ps2_raise_irq() instead of open coding it Date: Thu, 13 May 2021 19:12:44 +0200 Message-Id: <20210513171244.3940519-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Inspired-by: Volker R=C3=BCmelin Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Bin Meng Reviewed-by: Volker R=C3=BCmelin --- hw/input/ps2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index 72cdb80ae1c..02d7e5da723 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -213,7 +213,7 @@ void ps2_raise_irq(PS2State *s) void ps2_queue(PS2State *s, int b) { ps2_queue_noirq(s, b); - s->update_irq(s->update_arg, 1); + ps2_raise_irq(s); } =20 void ps2_queue_2(PS2State *s, int b1, int b2) @@ -224,7 +224,7 @@ void ps2_queue_2(PS2State *s, int b1, int b2) =20 ps2_queue_noirq(s, b1); ps2_queue_noirq(s, b2); - s->update_irq(s->update_arg, 1); + ps2_raise_irq(s); } =20 void ps2_queue_3(PS2State *s, int b1, int b2, int b3) @@ -236,7 +236,7 @@ void ps2_queue_3(PS2State *s, int b1, int b2, int b3) ps2_queue_noirq(s, b1); ps2_queue_noirq(s, b2); ps2_queue_noirq(s, b3); - s->update_irq(s->update_arg, 1); + ps2_raise_irq(s); } =20 void ps2_queue_4(PS2State *s, int b1, int b2, int b3, int b4) @@ -249,7 +249,7 @@ void ps2_queue_4(PS2State *s, int b1, int b2, int b3, i= nt b4) ps2_queue_noirq(s, b2); ps2_queue_noirq(s, b3); ps2_queue_noirq(s, b4); - s->update_irq(s->update_arg, 1); + ps2_raise_irq(s); } =20 /* keycode is the untranslated scancode in the current scancode set. */ --=20 2.26.3