From nobody Mon Feb 9 15:46:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923956; cv=none; d=zohomail.com; s=zohoarc; b=JvB3lCaxJ3H7UMkaaz64rJxnaojmBII4B7jtOpT5qmoTTEQax1WpNrwXBhU2ebgkHBdFiyyBmRXQ9LuaATHmhAVsxu1AGlmL5Vkapsr0jB6qfvSDcn8+ehk4v/twnuFN/b9G7dEoP6KcKGYB2w24Y/rwP7GEOff6TL40CnvC94A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923956; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=AxShTGrcm0lCnGiPY3RzzM+dKnnNrIC7Yq1nhtJfzAd2i3Xx1sy9mNOvXAoA6wAwhgeinUqbV5szqNv7Jn1CmdPq9PFTwlEIA2YqaLPIm3qUVEEvylsARDImU7JMUjTmFE5l0LOI/Y8jdNIzIiTv2zPILfij6RMug8HFu3gRjso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620923956231226.97297529338437; Thu, 13 May 2021 09:39:16 -0700 (PDT) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-P76RiKB-M_K9P5CRyWMkOA-1; Thu, 13 May 2021 12:39:11 -0400 Received: by mail-ed1-f71.google.com with SMTP id x3-20020a50ba830000b029038caed0dd2eso3817135ede.7 for ; Thu, 13 May 2021 09:39:10 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id di7sm2695781edb.34.2021.05.13.09.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=Nal+SZgylXCcjTvMJuZvEAJQUvMDmi0JK5SvNMcsDOLxo/YvIk8OiLAtsl11M6LfTbSQBM aMi8Ir+FXTgMqQV1Xdo70kBp16M0r7bpP+mw0VzAdi9uoTL+ptXWKd3YtWzHEF/f0CIZVM EMVwYbnNRO9WQ8Q8PyAAt8UYSEMWrX4= X-MC-Unique: P76RiKB-M_K9P5CRyWMkOA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=Y5KlL+V08CrZijm8panfwgv8knkm7jjXCvMCYdFf+gsSRuQ/33u07RHtCbPj8Uxi2u lZajCMJTvb9xRocUdO9clZGgz1haMIGLbdBvev+cDu2YlGIX+p17Ty/qqVcWAVVgd+N6 P2KQFdrPhe6/Tl1C+729fHNiqaqn+S9nmntk9S4+5emsDEloNtJtjPTGEwSD9v8M4uqH snFqNMXNHzo0SCOET0/2EDn4ixRtscXGpe1SYayf2VWqC+MKsTLXZa05IrMk8vUpi/PN gUKi9PVLaRgWSJnzonZFFd318hL6/E8UFFzSGsOQ842K/9jdXEdec7x7OOpHtUSHw8Fq 5NIQ== X-Gm-Message-State: AOAM530ZSU970D9mmFYYi5ZuBpIzbog8TqZfY0PlTTjYkB50agJiBEN6 AKEFTiUHCL3DYfiVO2oqXqCgVGILt8x7CCdfWeYG/5AbRoH0+/+/CRolAWt27f9DMy7RF4d6equ frYevghaAX6ve/w== X-Received: by 2002:a17:906:fcdc:: with SMTP id qx28mr12659187ejb.375.1620923949779; Thu, 13 May 2021 09:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3rRwCF9pZ71vFd93cXhzmvhSqn1g1AzCJRzfmiTLGOhSM/2mbCl5wEmp1SgZQMcoMTUp6Wg== X-Received: by 2002:a17:906:fcdc:: with SMTP id qx28mr12659173ejb.375.1620923949646; Thu, 13 May 2021 09:39:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , John Snow , qemu-block@nongnu.org (open list:IDE) Subject: [PATCH 02/10] hw/ide/Kconfig: Add missing dependency PCI -> QDEV Date: Thu, 13 May 2021 18:38:50 +0200 Message-Id: <20210513163858.3928976-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd= _table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, Drive= Info *drive) include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int= unit, DriveInfo *drive); Fix the correct symbol dependency to avoid build failure when deselecting some machines: /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_d= evs': hw/ide/pci.c:491: undefined reference to `ide_create_drive' Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Bin Meng --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 8e2c8934549..dd85fa3619f 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -8,7 +8,7 @@ config IDE_QDEV config IDE_PCI bool depends on PCI - select IDE_CORE + select IDE_QDEV =20 config IDE_ISA bool --=20 2.26.3