From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923949; cv=none; d=zohomail.com; s=zohoarc; b=HzwmT1GgjKjqQXGkp0c+yFkRYbCyZiSddah2xGlvJouBD0Py1Z2W5udOwuJ/xSkU2a6EYRODPtnfAemmZ3sVX3MOxbMsl/7enQflCCUT7jLJ6owjlmLXI5s55JTl84DnGUquMLLPVdWmEXaRmAIwan4DKS50es9cmCkPPfI7rug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923949; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=bW5gbIH0gVW0SIl2TNyDBPbRck/tAvlYokCEWuHZkDo=; b=db7BYAF4ppPHnunCv6I4X82RqKG9BJOEb6WG3AcI+5lWcOBNxxn6HCNQ4moCDZfJoGx5/P42sBAOu26bKoblnh5MbD3o5LRERM4gt+Ms4r9oEpln7jk7Z6lRoJbbS7tHv5OMIjqm3EtP6O3+dRugvRSioceslQSUfL8xQoBA1kE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620923949700165.86010703513125; Thu, 13 May 2021 09:39:09 -0700 (PDT) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-Hrk3gaNcNqijG8L6oujJOQ-1; Thu, 13 May 2021 12:39:06 -0400 Received: by mail-ed1-f70.google.com with SMTP id g17-20020aa7dd910000b029038843570b67so14939959edv.9 for ; Thu, 13 May 2021 09:39:06 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id y11sm2539673edd.91.2021.05.13.09.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923948; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bW5gbIH0gVW0SIl2TNyDBPbRck/tAvlYokCEWuHZkDo=; b=fdjxPtCI/EOD0nFmFxjk5AxN+IqgfnxFImNt2iknZeYY/3pkhUuiQ0Cho8OTcJ66YMaE0S tipqzrYAj5J06vfgOHTLvYOIKE/AXX7+gRjN+gV2tq9Vn6LmzQmPgl2wpQzOCf4ElrktjY VswI/szN2bp3cOwUNn/Z9JH9ankmqoQ= X-MC-Unique: Hrk3gaNcNqijG8L6oujJOQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bW5gbIH0gVW0SIl2TNyDBPbRck/tAvlYokCEWuHZkDo=; b=oVm1AXWs8rJkTR0beARWpq4zYDrXsoXbQNbuqVzPBG+Op29GMyPgI2tFK0ahcB0o4W nbRSYiIO2oUxFtcJCYS5Am/b+DQ6NWR775fMZl/YhfDnAsAXnpq344KWrUKOoO0yBHTl riW3Vu1n8l6G9WEH5uyexSraBMIfKiyKM+gX9+8uAKRBuoiIvrQywskX02kinqFMMwMq gB/vglFygz9QIdRnPchim89X1VMp090Ao6XvoGXtXZ2Mp387AmGfPjWvgv9R6r8G2o+q OX/TNatrZs1dtYRB4/3XzcrFyqZQHzXstg40pq23UYyPHN1SGnBouBi4+EjFCNs5g+hJ LJTg== X-Gm-Message-State: AOAM533nHjzmVyi2jSXREHxm9G37yBeCd2LmDjiQODE0yt1ocaFwFTzO PGaq5kQuwNSI5UUOSlRz3sWTteGgxEyHT0Gu01Uc8gKMoecm2PvHPA8rjSBwzRj832u0dEhQdXd tWO3QEVSjw9Yv7w== X-Received: by 2002:a17:906:5917:: with SMTP id h23mr4105821ejq.457.1620923945087; Thu, 13 May 2021 09:39:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrXzw29CRvct8vgvUH19mfvMTnZDWe4CE76WQl44rPKgdBUG1b223i/h7qZhPzWi3i9CoEyQ== X-Received: by 2002:a17:906:5917:: with SMTP id h23mr4105802ejq.457.1620923944909; Thu, 13 May 2021 09:39:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Igor Mammedov , David Gibson , Greg Kurz , qemu-arm@nongnu.org (open list:ARM TCG CPUs), qemu-ppc@nongnu.org (open list:PowerPC TCG CPUs) Subject: [PATCH 01/10] hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Date: Thu, 13 May 2021 18:38:49 +0200 Message-Id: <20210513163858.3928976-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Per the kconfig.rst: A device should be listed [...] ``imply`` if (depending on the QEMU command line) the board may or may not be started without it. This is the case with the NVDIMM device (it is certainly possible to start a machine without NVDIMM) , so use the 'imply' weak reverse dependency to select the symbol. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson Acked-by: Paolo Bonzini Reviewed-by: Bin Meng --- default-configs/devices/ppc64-softmmu.mak | 1 - hw/arm/Kconfig | 1 + hw/i386/Kconfig | 1 + hw/mem/Kconfig | 2 -- hw/ppc/Kconfig | 1 + 5 files changed, 3 insertions(+), 3 deletions(-) diff --git a/default-configs/devices/ppc64-softmmu.mak b/default-configs/de= vices/ppc64-softmmu.mak index ae0841fa3a1..cca52665d90 100644 --- a/default-configs/devices/ppc64-softmmu.mak +++ b/default-configs/devices/ppc64-softmmu.mak @@ -8,4 +8,3 @@ CONFIG_POWERNV=3Dy =20 # For pSeries CONFIG_PSERIES=3Dy -CONFIG_NVDIMM=3Dy diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index b887f6a5b17..67723d9ea6a 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -6,6 +6,7 @@ config ARM_VIRT imply VFIO_PLATFORM imply VFIO_XGMAC imply TPM_TIS_SYSBUS + imply NVDIMM select ARM_GIC select ACPI select ARM_SMMUV3 diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 7f91f30877f..66838fa397b 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -23,6 +23,7 @@ config PC imply TPM_TIS_ISA imply VGA_PCI imply VIRTIO_VGA + imply NVDIMM select FDC select I8259 select I8254 diff --git a/hw/mem/Kconfig b/hw/mem/Kconfig index a0ef2cf648e..8b19fdc49f1 100644 --- a/hw/mem/Kconfig +++ b/hw/mem/Kconfig @@ -7,6 +7,4 @@ config MEM_DEVICE =20 config NVDIMM bool - default y - depends on (PC || PSERIES || ARM_VIRT) select MEM_DEVICE diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index e51e0e5e5ac..66e0b15d9ef 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -3,6 +3,7 @@ config PSERIES imply PCI_DEVICES imply TEST_DEVICES imply VIRTIO_VGA + imply NVDIMM select DIMM select PCI select SPAPR_VSCSI --=20 2.26.3 From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923956; cv=none; d=zohomail.com; s=zohoarc; b=JvB3lCaxJ3H7UMkaaz64rJxnaojmBII4B7jtOpT5qmoTTEQax1WpNrwXBhU2ebgkHBdFiyyBmRXQ9LuaATHmhAVsxu1AGlmL5Vkapsr0jB6qfvSDcn8+ehk4v/twnuFN/b9G7dEoP6KcKGYB2w24Y/rwP7GEOff6TL40CnvC94A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923956; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=AxShTGrcm0lCnGiPY3RzzM+dKnnNrIC7Yq1nhtJfzAd2i3Xx1sy9mNOvXAoA6wAwhgeinUqbV5szqNv7Jn1CmdPq9PFTwlEIA2YqaLPIm3qUVEEvylsARDImU7JMUjTmFE5l0LOI/Y8jdNIzIiTv2zPILfij6RMug8HFu3gRjso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620923956231226.97297529338437; Thu, 13 May 2021 09:39:16 -0700 (PDT) Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-60-P76RiKB-M_K9P5CRyWMkOA-1; Thu, 13 May 2021 12:39:11 -0400 Received: by mail-ed1-f71.google.com with SMTP id x3-20020a50ba830000b029038caed0dd2eso3817135ede.7 for ; Thu, 13 May 2021 09:39:10 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id di7sm2695781edb.34.2021.05.13.09.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=Nal+SZgylXCcjTvMJuZvEAJQUvMDmi0JK5SvNMcsDOLxo/YvIk8OiLAtsl11M6LfTbSQBM aMi8Ir+FXTgMqQV1Xdo70kBp16M0r7bpP+mw0VzAdi9uoTL+ptXWKd3YtWzHEF/f0CIZVM EMVwYbnNRO9WQ8Q8PyAAt8UYSEMWrX4= X-MC-Unique: P76RiKB-M_K9P5CRyWMkOA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r8h55nhD/ysCnYrCCWZsGnnR6GqqPc9b4n86eMj2C40=; b=Y5KlL+V08CrZijm8panfwgv8knkm7jjXCvMCYdFf+gsSRuQ/33u07RHtCbPj8Uxi2u lZajCMJTvb9xRocUdO9clZGgz1haMIGLbdBvev+cDu2YlGIX+p17Ty/qqVcWAVVgd+N6 P2KQFdrPhe6/Tl1C+729fHNiqaqn+S9nmntk9S4+5emsDEloNtJtjPTGEwSD9v8M4uqH snFqNMXNHzo0SCOET0/2EDn4ixRtscXGpe1SYayf2VWqC+MKsTLXZa05IrMk8vUpi/PN gUKi9PVLaRgWSJnzonZFFd318hL6/E8UFFzSGsOQ842K/9jdXEdec7x7OOpHtUSHw8Fq 5NIQ== X-Gm-Message-State: AOAM530ZSU970D9mmFYYi5ZuBpIzbog8TqZfY0PlTTjYkB50agJiBEN6 AKEFTiUHCL3DYfiVO2oqXqCgVGILt8x7CCdfWeYG/5AbRoH0+/+/CRolAWt27f9DMy7RF4d6equ frYevghaAX6ve/w== X-Received: by 2002:a17:906:fcdc:: with SMTP id qx28mr12659187ejb.375.1620923949779; Thu, 13 May 2021 09:39:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw3rRwCF9pZ71vFd93cXhzmvhSqn1g1AzCJRzfmiTLGOhSM/2mbCl5wEmp1SgZQMcoMTUp6Wg== X-Received: by 2002:a17:906:fcdc:: with SMTP id qx28mr12659173ejb.375.1620923949646; Thu, 13 May 2021 09:39:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , John Snow , qemu-block@nongnu.org (open list:IDE) Subject: [PATCH 02/10] hw/ide/Kconfig: Add missing dependency PCI -> QDEV Date: Thu, 13 May 2021 18:38:50 +0200 Message-Id: <20210513163858.3928976-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The pci_ide_create_devs() function is declared i hw/ide/qdev.c: $ git grep ide_create_drive hw/ide/pci.c:491: ide_create_drive(d->bus + bus[i], unit[i], hd= _table[i]); hw/ide/qdev.c:127:IDEDevice *ide_create_drive(IDEBus *bus, int unit, Drive= Info *drive) include/hw/ide/internal.h:653:IDEDevice *ide_create_drive(IDEBus *bus, int= unit, DriveInfo *drive); Fix the correct symbol dependency to avoid build failure when deselecting some machines: /usr/bin/ld: libcommon.fa.p/hw_ide_pci.c.o: in function `pci_ide_create_d= evs': hw/ide/pci.c:491: undefined reference to `ide_create_drive' Fixes: 8f01b41e109 ("ide: express dependencies with Kconfig") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini Reviewed-by: Bin Meng --- hw/ide/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/Kconfig b/hw/ide/Kconfig index 8e2c8934549..dd85fa3619f 100644 --- a/hw/ide/Kconfig +++ b/hw/ide/Kconfig @@ -8,7 +8,7 @@ config IDE_QDEV config IDE_PCI bool depends on PCI - select IDE_CORE + select IDE_QDEV =20 config IDE_ISA bool --=20 2.26.3 From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923958; cv=none; d=zohomail.com; s=zohoarc; b=nqHIMp6Wdzw7xeg7+iTpAF4i8OCFlvEhFkOv3DgwqY1gckg7HB0YB4aCgwBC1rwkEh82ByJ8HopEwWiGaqhMIxT0ja/jFHMOQDUv2vLM9X5/F9xZZVKhCUPhPKMlibV8pmxx8Azs7KKYOSugrJzmcwGD6zyn1oBkeNs/WUb5GGI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923958; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=RxjBXIiwUsk+hse5zMCnX9XGKfKUwyxRJGBY/GxWjoA=; b=ZfB+sAflQJENVxpb3rx67mQZlO3WoEP3GF8cta9t81ZV2V4gBtTVFExy9slH1uavJUHbXe+HawGjETycrCns1jA3P3A9jzFsM7fxzET/q82oBM/zRioxr/p9cfo+73AB3RHKRl1tnvw3Snh0Oa0p5hQZrJTJCf2JoW1rGJSTBNM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 162092395875728.831157193115132; Thu, 13 May 2021 09:39:18 -0700 (PDT) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-q-QueJqAMgqZVmrXX-0cZA-1; Thu, 13 May 2021 12:39:15 -0400 Received: by mail-ed1-f72.google.com with SMTP id w20-20020aa7dcd40000b02903886b9b0013so14969129edu.22 for ; Thu, 13 May 2021 09:39:15 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id s2sm2635684edu.89.2021.05.13.09.39.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RxjBXIiwUsk+hse5zMCnX9XGKfKUwyxRJGBY/GxWjoA=; b=ihe0UXYCM5DU+mJjrX8qZButbAckOV/WqZOrZ/ZGEH7JpmW3UoXc/IZ9rlYb3LgFDgzKK/ G5qy+BILDgEOcMDRYpDBBHTrWZYOLgur9GtMBYOwLDcGUVAENgYH77uNnS4hyMBsC0ASF0 LlIO9wnYPr937+gTdXnVUvfKUJF63pE= X-MC-Unique: q-QueJqAMgqZVmrXX-0cZA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RxjBXIiwUsk+hse5zMCnX9XGKfKUwyxRJGBY/GxWjoA=; b=tog9nk9l3cajMxrVyHR+AaFHhsPIGJ/toan8heZPtyJx2f54t8tKPpMoFDxN6EPWzs u+Q4DpjyG0+30wzQGmKeOnxXuKH1iGO/yjLEFGaL47mz+WIAqn0VrOjdKwzjbaK/1sTn ETzPHD3diGqd8hMKGFqmPDMhVhnQvjst7mL3h3oAUtyq9qcoIZnrvPzlrX3oobq3j2F4 S1NNi65txzULvsOH/Fx1Tx8vOivhQEdq1YcF5nprstMJMANZiOqDnSmv+giN/hgIemTR BxeX/DuBcGqKG9gs+5dHSahyDlXM48MTHGS2rTNBaku9Xb9pZyBHI47CO2/BuZljtk2u b1ig== X-Gm-Message-State: AOAM533ZV64pGlfy4vEkHmZvjR3puP7i/UkNEbTbAYgJpO1fGJUenCY2 sC67FilBGgb0oLEDbsXLdyGf5zIW+XfjgOFU3be+OK4yctUm7G1+4PqEwTnz9zK9MpvTnz8Q6WM aJgflCipvFKGv9w== X-Received: by 2002:aa7:d955:: with SMTP id l21mr50910793eds.118.1620923954734; Thu, 13 May 2021 09:39:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+qSalJJDt2JNg9zn0iZ+C/qHcv7Yl0RzDuccxLeSdACCCZgMRwF1QO1hCLOiH+aqf5ul2pw== X-Received: by 2002:aa7:d955:: with SMTP id l21mr50910783eds.118.1620923954636; Thu, 13 May 2021 09:39:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Doug Evans , Hao Wu , Tyrong Ting , Corey Minyard , Peter Maydell , qemu-arm@nongnu.org (open list:ARM TCG CPUs) Subject: [PATCH 03/10] hw/arm/Kconfig: Add missing dependency NPCM7XX -> SMBUS Date: Thu, 13 May 2021 18:38:51 +0200 Message-Id: <20210513163858.3928976-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The TYPE_NPCM7XX_SMBUS device model exposes an SMBus, but this isn't advertised with proper Kconfig symbol, leading to an early build failure when building NPCM7XX machines standalone: The following clauses were found for AT24C config AT24C depends on I2C select AT24C if NPCM7XX Fix by adding SMBUS to NPCM7XX. Fixes: 94e77879395 ("hw/i2c: Implement NPCM7XX SMBus Module Single Mode") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini Reviewed-by: Bin Meng Reviewed-by: Hao Wu --- Cc: Doug Evans Cc: Hao Wu Cc: Tyrong Ting Cc: Corey Minyard --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 67723d9ea6a..85c6a1a088c 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -373,6 +373,7 @@ config NPCM7XX bool select A9MPCORE select ARM_GIC + select SMBUS select AT24C # EEPROM select PL310 # cache controller select SERIAL --=20 2.26.3 From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923963; cv=none; d=zohomail.com; s=zohoarc; b=Wk4zP+DQYO4sG1u89PmBp2N1WDDus5SMbK3OE0HJFsiUNdUm7fkchZgyjhTv6R4/6oEirDyDR1zeyNOgZFc+zjSMTXDALuXDbcxX6TlG7f22kc+A7iRFLJ8V0L53qFLFB5le9+JpQazpYaDbKbhKBP+SQ88SU4d/06x4YPPc0rU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923963; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=6C7WWutrNcOZs1K+Kika/F95HGC7AnV8YKzuCNwKf5Q=; b=d/BJFsKxIbRJXzcHMtBw815vjNlmlWBGMAYcrjoO+Qd6fwwFx1oxgNh2Ma1PYW44W7UgJ90jz1oVadaNT+SzlfDnskSaRWXA3JxHeVbe736hHQhNIzxaO8j5ZxmaaK84h0PtIzY9ebossc3XoZr8lFNNxl8DMv5hamXBMcyVYKQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620923963971152.48915071501438; Thu, 13 May 2021 09:39:23 -0700 (PDT) Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-306-tVDLaOLiP0SOYnwNwbhbDg-1; Thu, 13 May 2021 12:39:20 -0400 Received: by mail-ed1-f69.google.com with SMTP id q18-20020a0564025192b02903888712212fso14907608edd.19 for ; Thu, 13 May 2021 09:39:20 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id cr21sm2011294ejc.2.2021.05.13.09.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6C7WWutrNcOZs1K+Kika/F95HGC7AnV8YKzuCNwKf5Q=; b=cHjH+1Wrtrrxr1ADsrJIyujftM0sNPI+4zE3zxTDxyFcrqqHzCP2IJ+FFDoNV44CBtlXFX FBIqh7pETVjQpHM+NSJUISKdRyctMT1pzb2pTGlpMot6XTx7PQ2qa6f55bKxMA8iPyw8sf 7Q51o/FxlgaVMz2/mSTEs6enEvy/DeE= X-MC-Unique: tVDLaOLiP0SOYnwNwbhbDg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6C7WWutrNcOZs1K+Kika/F95HGC7AnV8YKzuCNwKf5Q=; b=kFZvFnF8iVs6Uado7XCvqwLXrTzrv3ibGHHAQTDDliv3m4i93/jvu2J8ehuf5PY29g HCr4DRqwfMBfh47P0Xc1ovqPZcN+S+8qrP+yals7LzUr6LE8+z2xG20CvJ8/CuP9HIax c1TlGw9kJveCWHchZk2tvt6hL6yrTP2QKAbKIUXljHVKlZcoO42O1+jWAYFBJ8hqMsxo Fna/V22n+uHbnxFP+e368Ir6qWMGDVweyLuCe9PSW/09/fUtaiPDGNMRdPCxxCXRNKl1 t+BVeU+n/wkZSCic1jotAVccLZk1QjWNmd+RZIBn33k5YQA+K1FNumjPtZYjAjM1jBo/ wwFQ== X-Gm-Message-State: AOAM532OKmVPfdUIYV6l3VwEeVqi7OzaK1Iy+7uSMbM9Th4tZMNNX2zJ SzvbcocvAc5V6kGK7oPIKzM2Ur1hnP66v7bsc1PW3VIN+VGD9sibePzXpAzUporCq44FPptfVFq QxQqktwaB2taEUA== X-Received: by 2002:a17:906:c14c:: with SMTP id dp12mr44642602ejc.312.1620923959546; Thu, 13 May 2021 09:39:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9XaXQidoNghPAg+0dwQ1tb5c/B6aem8zKmtpGmOCyf9a7Lfrws4EmmpEpaGgvsrxIOpWzsQ== X-Received: by 2002:a17:906:c14c:: with SMTP id dp12mr44642592ejc.312.1620923959396; Thu, 13 May 2021 09:39:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell , qemu-arm@nongnu.org (open list:ARM TCG CPUs) Subject: [PATCH 04/10] hw/arm/Kconfig: Remove unused DS1338 symbol from i.MX25 PDK Board Date: Thu, 13 May 2021 18:38:52 +0200 Message-Id: <20210513163858.3928976-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) In commit c4f00daa5b3 ("imx25-pdk: create ds1338 for qtest inside the test") we removed the DS1338 device from the i.MX25 machine but forgot to remove it in the machine Kconfig definitions, do it now. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini Reviewed-by: Bin Meng --- hw/arm/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 85c6a1a088c..5827c092b28 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -386,7 +386,6 @@ config FSL_IMX25 select IMX_FEC select IMX_I2C select WDT_IMX2 - select DS1338 =20 config FSL_IMX31 bool --=20 2.26.3 From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923968; cv=none; d=zohomail.com; s=zohoarc; b=ZLVtsxcvxBNIIaeVCXFS0I9I2p9b354ss24D0kVs9gnet05YC+kH/R9D/1p4bygcBWRRYendK8LdhIUHVypDNA6Q6kIhM6KU6xdSBLrMbDbzgJAOz9GYsM+vNBR5HEjZNMvJ6iLiXeB3uvKhV+jT3gbEOeXTwAUd0qyUKb9Obto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923968; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=y/ktmwgutY2Wn0xDD9O8rw5tOPYKtHCv9CNEw553h8k=; b=Md2fdKY7C2FDh3UGQbEBq0G6+oyKjZ2ZTcf8g+xEacI87YjeUUwWsQN33mMvs9zgp34M5LUYhZRgPzJaAhElcUuFp8ZIX/vXzHfBhN2P5+MCbzJfjTZC3+omEC7jJWn97B499qWmSmnAYovG8Ek0XxAu/X+QwjT1URUR5VJT95c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620923968594182.084806259659; Thu, 13 May 2021 09:39:28 -0700 (PDT) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-556-QDaGLBN_Mu-qySGflBr6gw-1; Thu, 13 May 2021 12:39:25 -0400 Received: by mail-ed1-f70.google.com with SMTP id g7-20020aa7c5870000b02903888f809d62so15017511edq.23 for ; Thu, 13 May 2021 09:39:25 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id x13sm1511947ejs.93.2021.05.13.09.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923967; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y/ktmwgutY2Wn0xDD9O8rw5tOPYKtHCv9CNEw553h8k=; b=Qicf9NnolEU7QtOssgKbSh9CF/B+1G7nLi7yZ2BHLzYTsmK4yIVp7079mN660bEQTe/1M9 SnHwvjFd4IefVh0QA00pb+HbmyB8JpJ1HjE+iZeLci3iVTTzJsqpFpOjzJCTYQKJy9MxPm xs6YxwGpVk3vuUI37tBLJZx7qBNqCTE= X-MC-Unique: QDaGLBN_Mu-qySGflBr6gw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=y/ktmwgutY2Wn0xDD9O8rw5tOPYKtHCv9CNEw553h8k=; b=jYuvQZ/wZOeI+cnZWA+Z/n4vVQVPAC6e3xr/P4hMSMzps2e+SamqOcnGpDuZD6t9YB dYP4OsMx8gu86LMzN7gBOHpDJV2+UxdNPs8BLRUF53gMIw9bhL59lwfZ0gN0w62BXTYk kmt10RFUAztRsvS8eWBEY9OSS+UwEBKmhS05rfSqIjRfYwfiq6K7qSKgRysTI4zOVGCF RgDsmTk4bruOIAnsn5XpSGnh4sMsOjgSfDbTLs3bFqVFPPdvYRITsOJLzKznxrW1+MaP 4BjQmKUESW4lGkCXFj1A47J0BgCx2GmtdxJp1f1RGu6tr7eodcLVKsKfn9nXZoDiKE6U QywA== X-Gm-Message-State: AOAM530++JmnkjqW8jNJnGZPZVVV/zqdZWjv4ocwad9M2ypQ3e/26YtN oHjrRStD1jf5+zX45Uo7Ax25hehaE7DkxiyejhsC2OPrivkpm24JHV6kxuM00PzaLyYEYtQOnZD VOSBeDfR344RT8A== X-Received: by 2002:aa7:c150:: with SMTP id r16mr50496719edp.82.1620923964295; Thu, 13 May 2021 09:39:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx2oIMAwKi64pSyQ+/EOA7l5jS4AZ6eeIr0+GVabPzXT3cRYsU1kb1XZCruo5g3CWbSvuKTcQ== X-Received: by 2002:aa7:c150:: with SMTP id r16mr50496711edp.82.1620923964198; Thu, 13 May 2021 09:39:24 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Guenter Roeck , Peter Maydell , qemu-arm@nongnu.org (open list:ARM TCG CPUs) Subject: [PATCH 05/10] hw/arm/Kconfig: Add missing SDHCI symbol to FSL_IMX25 Date: Thu, 13 May 2021 18:38:53 +0200 Message-Id: <20210513163858.3928976-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Commit bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") added a dependency on the TYPE_IMX_USDHC model, but forgot to add the Kconfig selector. Fix that to solve when built stand-alone: $ qemu-system-arm -M imx25-pdk qemu-system-arm: missing object type 'imx-usdhc' Aborted (core dumped) Fixes: bfae1772c43 ("hw/arm/fsl-imx25: Wire up eSDHC controllers") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini Reviewed-by: Bin Meng --- Cc: Guenter Roeck --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index 5827c092b28..6bb34926bb5 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -386,6 +386,7 @@ config FSL_IMX25 select IMX_FEC select IMX_I2C select WDT_IMX2 + select SDHCI =20 config FSL_IMX31 bool --=20 2.26.3 From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923973; cv=none; d=zohomail.com; s=zohoarc; b=UaujPivhMM8rVAwIe+yEA6i+COSh70FqQ5VUh9bTopiZDlvMIeSf5TyMeeeDsAaUYjI4mkcjn1S3dET9bzZLHQ2kCet3gO+0NcsTvaeS9d3fJzw7YdUJOsgJH0U0fuzgDG3QuTBcjSTBpKRN3rVxoRyVYUfjQov5dK3aOyuM90I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923973; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=XjYvOAyPTrpSNhVqdAN7BGoQLHD/mxypL8yaob15sP8=; b=ECL+7t94Jp6hX4XO4pFVzaFLlAKyvYr9U6LU5kGOqOf+lnfB1nKmHBV/Ob/7M9XYkjob8K9GkGHS7dh2UQYP6UuWeelC0EkhsB/bE6tAtb10odQJoTQaxZw028bY3yjM00UHI2pbfrzUnaxW+UfEMVRsTQlg439t5eze+8Tqslg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620923973534813.4271149813754; Thu, 13 May 2021 09:39:33 -0700 (PDT) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-NpvBpTh1MUuOPgm1lgw7VA-1; Thu, 13 May 2021 12:39:30 -0400 Received: by mail-ej1-f72.google.com with SMTP id zo1-20020a170906ff41b02903973107d7b5so8543603ejb.21 for ; Thu, 13 May 2021 09:39:30 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id w21sm2598159edq.82.2021.05.13.09.39.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XjYvOAyPTrpSNhVqdAN7BGoQLHD/mxypL8yaob15sP8=; b=d/2nrCJ+P8jf4ZmHRa21qIKT0wzxiEG8neyC0ei4N/lLFgnQKKEFLXrbldW+EEsXX9zoIt FpE+qhk+msB7HFuGSGJ+Vw52zMPZYo9P6FXMKn9Fl3eaEswinSytuDQtcQdBGjhZI9Vamt pLqHUXHvkEOGOC7iL7wl0VXbtaYnKog= X-MC-Unique: NpvBpTh1MUuOPgm1lgw7VA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XjYvOAyPTrpSNhVqdAN7BGoQLHD/mxypL8yaob15sP8=; b=UTtEJscDTwOsJNMluvOoNkNGGbsDUD25YvShT1n376Xs/qcWCGz+2Jtlng1XBfiMup XQoQahewtxssXej1Qq/hGSwBMMnbkiGSfZCjkMW93qxn9bTso8Mhwpqu1M3Pcrh8rzNG QCTlCZcEAB4FEIfiiz64uHVWgF1NNiDJtRLctkj/ZZ8WgkCOacHpZu0VePM1j/kTZzUX SDNSMwERpAQJIG1wKjomW5d7MM8qYiEtUBGCR5Wukc0DYLeR4v5/aIajyYvZa3c4nT+M lkTJBOOgKKX7zGaoqQzGQDPhXykL7mAnZ4l4jAcTbz2M+cPcSYQexRZ0HfsPXGUdnd0p Xk3Q== X-Gm-Message-State: AOAM5319WDMUp7XbmD67qzwt8QEfveBm+m/Fwu30x1enVc/2yRC40Dju Kg7mYR1CNyKuYAo5iHbKDqApCve8mvi1omlQxdeTSDwAIrYLzDHQQGUGKtw+r6An2aNNQnsQfm2 i379VVKNidZhrpQ== X-Received: by 2002:a50:eb47:: with SMTP id z7mr52056280edp.68.1620923969235; Thu, 13 May 2021 09:39:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQQR8VCvYN64Fsq/tEUlN0mpcNMtt2b6hN9PG/yK7gHSmibN4yT03uqEfFRMs0WBiaNdkRSw== X-Received: by 2002:a50:eb47:: with SMTP id z7mr52056264edp.68.1620923969072; Thu, 13 May 2021 09:39:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Bin Meng , Alistair Francis , Palmer Dabbelt , qemu-riscv@nongnu.org (open list:RISC-V TCG CPUs) Subject: [PATCH 06/10] hw/riscv/Kconfig: Add missing dependency MICROCHIP_PFSOC -> SERIAL Date: Thu, 13 May 2021 18:38:54 +0200 Message-Id: <20210513163858.3928976-7-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Commit a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") added a dependency on the SERIAL model, but forgot to add the Kconfig selector. Fix that to solve when built the MICROCHIP_PFSOC machine stand-alone: /usr/bin/ld: libcommon.fa.p/hw_char_mchp_pfsoc_mmuart.c.o: in function `m= chp_pfsoc_mmuart_create': hw/char/mchp_pfsoc_mmuart.c:79: undefined reference to `serial_mm_init' Fixes: a8fb0a500a6 ("hw/char: Add Microchip PolarFire SoC MMUART emulation") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini --- Cc: Bin Meng Cc: Alistair Francis --- hw/riscv/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig index 86957ec7b06..b72a248809e 100644 --- a/hw/riscv/Kconfig +++ b/hw/riscv/Kconfig @@ -12,6 +12,7 @@ config MICROCHIP_PFSOC select SIFIVE_CLINT select SIFIVE_PDMA select SIFIVE_PLIC + select SERIAL select UNIMP =20 config OPENTITAN --=20 2.26.3 From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923979; cv=none; d=zohomail.com; s=zohoarc; b=bdxo3rIw3EBa4M8/v6qUyxxbhR+sra+SycKiCj8lQpmNYxxnAfBnXDS8Rwjl87WrJsH57xh1QmeefPOLgSPxDjydopKUg/BnCzMTZhsrPFb5n/yhkZp6Gtw9NgRtbTOydClwpxBNs3ldeOGGIAPytktDp4lnqfcIYI3LeYgKyE0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923979; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=vt0rPlIVTA2zME2ANb52VRIm2f7ixfDlgEfuDufRLOU=; b=Dvai43JMNpoZlBCeKTLDbIYj+X4H6dTLCp5yANP0/rDVYEjs/6ku+s3B5iHQWIX2yZoe7gTKt2TW/FygPm9+FAbz4UXS9jNliSPUgI2QZMtpqut8wkZzZlRkMdQtN1eVVW3+LFcFCRnnZwppAn6bTSfGMIW/dmxYrU/QM7o3ues= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620923979846975.0145044435864; Thu, 13 May 2021 09:39:39 -0700 (PDT) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-jFpk5s7BPcqb-I3JnBu3xQ-1; Thu, 13 May 2021 12:39:36 -0400 Received: by mail-ed1-f72.google.com with SMTP id y19-20020a0564022713b029038a9f36060dso14916064edd.4 for ; Thu, 13 May 2021 09:39:36 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id r17sm2644904edt.33.2021.05.13.09.39.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vt0rPlIVTA2zME2ANb52VRIm2f7ixfDlgEfuDufRLOU=; b=IexCJojMUMYhFmnQ6W79s6+fKCdMZekTAhkI0AjCacI9tzpUXpdEvqazCDTG69WeR9KPGg SvU9zWISxCQ73Zh7mXGHe9BhSn55xc9MOCNaPzYsfwbkgiDko2QjDI5zzt8G9oeKLf857b aKkH4+jENcYfTdg+DFX7OiWJWa8SFss= X-MC-Unique: jFpk5s7BPcqb-I3JnBu3xQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vt0rPlIVTA2zME2ANb52VRIm2f7ixfDlgEfuDufRLOU=; b=hKUCP8inn7lsZETH1rXVfntbMmuQm1i+ADcmn4otiLCBmYijoetyRi+Nqp5EJoL6/C et6qyx9JpcvUBHTrgUaO+eSL+pT2XoMx9zfd+wQNErO/gFlSZ3iJBM93652DG439QNSk InmLWWTVlNAXApGG8nXEfg8Wiec0hOFxx9Sa9LrlA8gyhZMxbrRsbaTr4B88H4EsJSAd gl01euHwDsBsRhRi2IBXqtTBDKUQqNyFm5K0dGEKhLEIcQs+5trG2dxA9tBb68dhI3IY hIqZ0cHWsENM2Gt3wKl14IqLSiNR32RTTNp6t5vCgIsP6XIqQfWzsaKHN/977q3jy1G3 LeGQ== X-Gm-Message-State: AOAM530N1Aj/YwMUS2PP4nWYINL/6QOnPTXYUu5D7nczHla1Orr9AZgR q8PE07FKa/cUfvnBWB8BxprgIDne+e+XDfRen8PWK0M2KbNKyAttl3SKoktpzarQCoJhn4bbtO2 zYG7IKBhN0rJFZQ== X-Received: by 2002:a17:906:9246:: with SMTP id c6mr45279429ejx.10.1620923974108; Thu, 13 May 2021 09:39:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxE1l7ofRjRJFGt9vB7ZIomsyEQvq5BC5uZr95cBlF78n+jfrvZh5DW7F56Oa6yX27iwzRPlQ== X-Received: by 2002:a17:906:9246:: with SMTP id c6mr45279413ejx.10.1620923973899; Thu, 13 May 2021 09:39:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Palmer Dabbelt , Alistair Francis , Bin Meng , qemu-riscv@nongnu.org (open list:RISC-V TCG CPUs) Subject: [PATCH 07/10] hw/riscv/Kconfig: Restrict NUMA to Virt & Spike machines Date: Thu, 13 May 2021 18:38:55 +0200 Message-Id: <20210513163858.3928976-8-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Only the Virt and Spike machines use NUMA. Add a RISCV_NUMA Kconfig symbol and only have these machines select it. Adapt the Meson file to only built it if required. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini Reviewed-by: Bin Meng --- hw/riscv/Kconfig | 5 +++++ hw/riscv/meson.build | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/hw/riscv/Kconfig b/hw/riscv/Kconfig index b72a248809e..b22736169c1 100644 --- a/hw/riscv/Kconfig +++ b/hw/riscv/Kconfig @@ -1,3 +1,6 @@ +config RISCV_NUMA + bool + config IBEX bool =20 @@ -35,6 +38,7 @@ config RISCV_VIRT imply PCI_DEVICES imply VIRTIO_VGA imply TEST_DEVICES + select RISCV_NUMA select GOLDFISH_RTC select MSI_NONBROKEN select PCI @@ -75,6 +79,7 @@ config SIFIVE_U =20 config SPIKE bool + select RISCV_NUMA select HTIF select MSI_NONBROKEN select SIFIVE_CLINT diff --git a/hw/riscv/meson.build b/hw/riscv/meson.build index a97454661c0..ab6cae57eae 100644 --- a/hw/riscv/meson.build +++ b/hw/riscv/meson.build @@ -1,6 +1,6 @@ riscv_ss =3D ss.source_set() riscv_ss.add(files('boot.c'), fdt) -riscv_ss.add(files('numa.c')) +riscv_ss.add(when: 'CONFIG_RISCV_NUMA', if_true: files('numa.c')) riscv_ss.add(files('riscv_hart.c')) riscv_ss.add(when: 'CONFIG_OPENTITAN', if_true: files('opentitan.c')) riscv_ss.add(when: 'CONFIG_RISCV_VIRT', if_true: files('virt.c')) --=20 2.26.3 From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923983; cv=none; d=zohomail.com; s=zohoarc; b=Z+qHHRhl6L3EOX8hwiACS1YZIU7wbsnRrUgUa3bGyZMYQb5osc2DUJuhDh4oIEZuapYUZO/i8y2+u+9t2wjmu+JbY7qd14E4Lsud/xz1B2C0E0ZCw0RJp458C6Vs8kW+hwwVmitRMpGAXqSRxVseuYatmZFmVozlHr180fB2T2s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923983; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=9162a9gsiDm6q5lv1tLX3hofqR6ZQKlarxc+XT9y4us=; b=NEW9LdM0XnMy0sAFBexs3YF57OJuo0ivBEI4AR6j41/3o2JthAC9VR02VF/0FGpkz74WwOljWAeF7eVLsI6BzECQkFeaFkhA7enk9DzNxxqFXYVG2sgJph81BLuhijpem3fkSFsOxKBUHJj0ZPBrJxx5IR9u3uhEPn0aGt8BBcA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620923983054773.5364804758827; Thu, 13 May 2021 09:39:43 -0700 (PDT) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-A03h0VGON2q-O8Vi4NGkMw-1; Thu, 13 May 2021 12:39:40 -0400 Received: by mail-ed1-f70.google.com with SMTP id i3-20020aa7dd030000b029038ce772ffe4so536117edv.12 for ; Thu, 13 May 2021 09:39:39 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id i6sm2713664eds.83.2021.05.13.09.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9162a9gsiDm6q5lv1tLX3hofqR6ZQKlarxc+XT9y4us=; b=fVQDnjQ70ArC9PNqIIqFpPXf+2lRhZ8TUW1yuBySJHlIjN375yUqY2nGCoIMYZ31BOFmrd Id96KG23lQa5Q1RzLIteJHi+X2l80NP76wgN3x1MGyLEhl+2PamNIiPaF2FcPCz5QQS9G3 laDIyYnX6brw9WG1beHWQ7XlruHY/gI= X-MC-Unique: A03h0VGON2q-O8Vi4NGkMw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9162a9gsiDm6q5lv1tLX3hofqR6ZQKlarxc+XT9y4us=; b=gZp0TNNns6wI2iZdkGXxqSJdTQ5wzYtkmzbN0ZKhqQg5WSPWzzI5J+eu452oc0NknT 2wKOeopvGywAEUY/0nGv2WELiro6y5oG7FaWKj9id3hAN5V7ZN+CbYypsWEWo0FaZRIr /r80HyHjcn/oy5MBkIewuYImSGc0wjE/DG0ZMdFYJtcn+ZjhB4935jSfZerXOUYp1Jv2 /gpiSWSoCFwqdQf5UaePgwAqlyx9plpfOSfKRv67jdfeCDpHLzLuY+RmT+rYCp63lNOy xmcLUzwVBliAaZmFxzEOOz8KyNPMdutM3OaSoYVDqhgkH28+aNV13keUdp9jaRk9kHs9 gWbw== X-Gm-Message-State: AOAM5310U/V5Fqythk34Aa6c/li9V+lgMxQ+59LjIWxXWj7az/mtYg4L aYdT+3PDVelUPYm8hNycXV32dRGWAev9flkmJv6GtM0JXybo9gIMy2v2cM72QQr21kf5SFIiX5j TbtkRlDwx7hSuVQ== X-Received: by 2002:aa7:c510:: with SMTP id o16mr51117604edq.310.1620923978878; Thu, 13 May 2021 09:39:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyAzVgm8Qwn9FiXpF/yuznqTA1YfSKUmYrD/MywIqRiF1fT01onNfI3Q+vOESyc3JUACn3t3A== X-Received: by 2002:aa7:c510:: with SMTP id o16mr51117585edq.310.1620923978688; Thu, 13 May 2021 09:39:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Amit Singh Tomar , Andrew Randrianasulu , David Gibson , Greg Kurz , qemu-ppc@nongnu.org (open list:PowerPC TCG CPUs) Subject: [PATCH 08/10] hw/ppc/Kconfig: Add missing dependency E500 -> DS1338 RTC Date: Thu, 13 May 2021 18:38:56 +0200 Message-Id: <20210513163858.3928976-9-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Commit 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC with it") added a global dependency on the DS1338 model, instead of a machine one (via Kconfig). This gives trouble when building standalone machines not exposing I2C bus: The following clauses were found for DS1338 CONFIG_DS1338=3Dy config DS1338 depends on I2C Fix by selecting the DS1338 symbol in the single machine requiring it, the E500. Fixes: 7abb479c7ab ("PPC: E500: Add FSL I2C controller and integrate RTC wi= th it") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson Acked-by: Paolo Bonzini Reviewed-by: Bin Meng --- Cc: Amit Singh Tomar Cc: Andrew Randrianasulu --- default-configs/devices/ppc-softmmu.mak | 1 - hw/ppc/Kconfig | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/default-configs/devices/ppc-softmmu.mak b/default-configs/devi= ces/ppc-softmmu.mak index c2d41198cde..5a7f99d1e45 100644 --- a/default-configs/devices/ppc-softmmu.mak +++ b/default-configs/devices/ppc-softmmu.mak @@ -1,7 +1,6 @@ # Default configuration for ppc-softmmu =20 # For embedded PPCs: -CONFIG_DS1338=3Dy CONFIG_E500=3Dy CONFIG_PPC405=3Dy CONFIG_PPC440=3Dy diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 66e0b15d9ef..2e4c56eb770 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -128,6 +128,7 @@ config E500 select SERIAL select MPC_I2C select FDT_PPC + select DS1338 =20 config VIRTEX bool --=20 2.26.3 From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923987; cv=none; d=zohomail.com; s=zohoarc; b=lhGlsZx5qc57D6/U8CQHMTSWy8FPjPvYG37LtjlkPVy7/eTB5sJ0mVslKx0lyNicy2ADFu4HQMKXFZGJrBl3Db9V8rAFMlSmwqC1UK1Pij1fXdPbJeDe8C1bzET9k6eaKPCC/g9El669HiFywEYFjp3Tm87Bp7KhtFpYPiiRrko= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923987; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=5bFMY1wPkAX0kvucte6aKA1pZ+Ccdar2/PwwvnNc5vY=; b=bsa4M33iPA3k9S8M8d8rnWr/BFpLGkNt86wOlTMW6/cXvLNTUvgMw0aUiJWVtHxnoonuL377CZOQHmp6N/wPBdBuGR/7ErpRerR9V2TsJ0owgWzTcly0vH7Nl6UJXPvr9yIY3X1IVCpGSxQpxSWYW3OWcKHJcXjVzkB/SsqVt/s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620923987790682.5206008618233; Thu, 13 May 2021 09:39:47 -0700 (PDT) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-471-RtXJWiPvNmCMHm8yM51fqQ-1; Thu, 13 May 2021 12:39:44 -0400 Received: by mail-ed1-f72.google.com with SMTP id p8-20020aa7c8880000b029038ce714c8d6so585114eds.10 for ; Thu, 13 May 2021 09:39:44 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id t22sm2705341edw.29.2021.05.13.09.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5bFMY1wPkAX0kvucte6aKA1pZ+Ccdar2/PwwvnNc5vY=; b=GOwdpDKZCt8w68mlk2jWBTa1NBLupYS93EaMx1J6aJwjUw0prnC5HEZfnH3x647WMWJqQX MDAcJd94iubbTqoWz0FN2sJFa9lIXcQ2f6uwIeVyH5FjMcuJpbCenwLmJieRSaXypGW7RW VJ/QCq7xJa5AoPgEruZto/uF4EFb8OA= X-MC-Unique: RtXJWiPvNmCMHm8yM51fqQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5bFMY1wPkAX0kvucte6aKA1pZ+Ccdar2/PwwvnNc5vY=; b=Cju1kaUK/EoStOS0Y/1K2wRyMGfnsBJiNnrLyo+0Db80qT9od94VZR9h2ypmzFAyP9 B38DRWvSQHWBR7lu7W/xYT1yaLhia1n8SHp2eWdsviSTbbMnFHxXXjKeWlIkN2bNomZ7 r0G4oWCXtHrxMgeDRlsq0weD9i8Ad7b1Bo6oeXVMw/ME6VfYxAt+OVkTZJRnvRFNUbCz hurvw/Z36sLsOwDPaSR7brgHjo5DV1h91jlQqrp6013SpGdksjk6+7z3T4sHFCyqUIFX QX01YMRoJIzlqu9nfuNMsemXAUsGwEGK1jrI/e+CapKLzz+X6DXyZqMKgSMMla54dDsd L3Bw== X-Gm-Message-State: AOAM5334o+Q1UZ5H35Y6feRXBhz+OL8DU0svVrHMoSaGOcOUTKLGIph9 ehanRb0xRkB3ie4rdn1dbH+kNA8yQeNfMNY0kAXhZdAjR10TvL+PsuGJR0I/2Dpx+nE6d1sKwhS qfDNQwhXh2VVPcQ== X-Received: by 2002:aa7:cc98:: with SMTP id p24mr26599595edt.353.1620923983574; Thu, 13 May 2021 09:39:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9Yfa+X1wXqN++Raq2r/eiE8AApNA1VgBUQC+GklA6Tu6xOGbOboIOElrzIapP3GjQzgAk9A== X-Received: by 2002:aa7:cc98:: with SMTP id p24mr26599584edt.353.1620923983459; Thu, 13 May 2021 09:39:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 09/10] default-configs/devices: Remove implicy SEMIHOSTING config Date: Thu, 13 May 2021 18:38:57 +0200 Message-Id: <20210513163858.3928976-10-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Cmmit 56b5170c87e ("semihosting: Move ARM semihosting code to shared directories"), added the ARM_COMPATIBLE_SEMIHOSTING symbol which selects SEMIHOSTING. Since the ARM/RISC-V targets select ARM_COMPATIBLE_SEMIHOSTING, they don't need to select SEMIHOSTING manually. Simplify. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini Reviewed-by: Bin Meng --- default-configs/devices/arm-softmmu.mak | 1 - default-configs/devices/riscv32-softmmu.mak | 1 - default-configs/devices/riscv64-softmmu.mak | 1 - 3 files changed, 3 deletions(-) diff --git a/default-configs/devices/arm-softmmu.mak b/default-configs/devi= ces/arm-softmmu.mak index 0500156a0c7..341d439de6f 100644 --- a/default-configs/devices/arm-softmmu.mak +++ b/default-configs/devices/arm-softmmu.mak @@ -41,6 +41,5 @@ CONFIG_MICROBIT=3Dy CONFIG_FSL_IMX25=3Dy CONFIG_FSL_IMX7=3Dy CONFIG_FSL_IMX6UL=3Dy -CONFIG_SEMIHOSTING=3Dy CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy CONFIG_ALLWINNER_H3=3Dy diff --git a/default-configs/devices/riscv32-softmmu.mak b/default-configs/= devices/riscv32-softmmu.mak index d847bd5692e..5c9ad2590ef 100644 --- a/default-configs/devices/riscv32-softmmu.mak +++ b/default-configs/devices/riscv32-softmmu.mak @@ -3,7 +3,6 @@ # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=3Dn -CONFIG_SEMIHOSTING=3Dy CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy =20 # Boards: diff --git a/default-configs/devices/riscv64-softmmu.mak b/default-configs/= devices/riscv64-softmmu.mak index bc69301fa4a..8a92f0a2c74 100644 --- a/default-configs/devices/riscv64-softmmu.mak +++ b/default-configs/devices/riscv64-softmmu.mak @@ -3,7 +3,6 @@ # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=3Dn -CONFIG_SEMIHOSTING=3Dy CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy =20 # Boards: --=20 2.26.3 From nobody Sat May 11 15:14:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620924007; cv=none; d=zohomail.com; s=zohoarc; b=QcbHtkSekYejWtdgWU4txWXZ6ohIufa3/izhGrWyU6fckcwQtV0C5r5/2nacqTTRLz7UFP6dXSJKOR3A5d45WRpxUCpLpP9cHy/Sm3uNvRO0R6EuxLgOIhm1ncK+OABL6BG99El3k/ku+sItOgav8A6UeIn40XSCHrlzHbTDahE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620924007; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=3WadOX/ZSMqkQkMfPHC0fuGiD0zW0hwXcxoICsAvYPk=; b=h+3Wzgqy9v0ytDlXbsfyitWJOneNSwoahn0fUjX341H9HNTH298CWV8xuHbrj8G5FxBTa75EBAac/cOAeqMfdECcViBtSGWJIgDtdrAbzY0gCcgbMtDlNOA6oVrVSh2bA44rJWwfSdUs8i2ieZ5VZFjv8Nwjpx5XJFNdeoyJ6Qw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620924007774838.5654768329964; Thu, 13 May 2021 09:40:07 -0700 (PDT) Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-315-p3CPzjj2MMKGnw9mjnnZOQ-1; Thu, 13 May 2021 12:39:49 -0400 Received: by mail-ed1-f70.google.com with SMTP id y19-20020a0564022713b029038a9f36060dso14916384edd.4 for ; Thu, 13 May 2021 09:39:49 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (31.red-83-51-215.dynamicip.rima-tde.net. [83.51.215.31]) by smtp.gmail.com with ESMTPSA id h9sm2661538ede.93.2021.05.13.09.39.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 May 2021 09:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620924006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3WadOX/ZSMqkQkMfPHC0fuGiD0zW0hwXcxoICsAvYPk=; b=NT1NVt+MOghqAvXBHP+ugPe8xEnsIUn43GfMu42SGqyTzzF6Gb8m+wKYzddfCEV4oXcAGL taRnOL9E5LjhepkdglSfQJaJajgOAj9dFtuWeHnS7Icy8RKCrU5Us7GZh5SBheHF1gGoLL gPIMVQq11K+ZlZYfJd4h6ipBbBeMH+c= X-MC-Unique: p3CPzjj2MMKGnw9mjnnZOQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3WadOX/ZSMqkQkMfPHC0fuGiD0zW0hwXcxoICsAvYPk=; b=RuaF2TyhItec1RqcVO4kV2kdvmcwwCKoErySlOyYynKHoJn3fK5TWDDuNdwbMLM/1u ONbPLQfdR0u7rc1yMYjFbdLGCTK7oVq6U66ObXUrxjCqJgpjVAPGxF9wDXUyJzQ7nWSg J5UkpD0IGBa6q59bxAFVlmoNQR8UQVzawZ0088K7Y36UJefFRbzvIvUUInc4n3TiiJ+/ QPDCqPDhxBPhtH8UnyKfGhGXo6nCVb/5rjxKsNYOnPM9ss/CfKZ33y700rG3/LE3y88u Vcb6yMFl9nF/LBHG5vqckFGI/cvqlgE6zWIG7g/uiSRvm7L83NOFnCjO4IDzUrje6qoB xVtg== X-Gm-Message-State: AOAM533i/UsLRnAyl/fdXqLgqt9yWrhFxOaSMqK8kb+Jbcf0lv38i8Jq ShBr4oKR6Vzvv0JnQ8RtpehMRwydnfoEqvlBAV9I3BjwY3iAGNNRvqqO97bWaIjS088NNTaMdiA miALBK1ycuYTfHA== X-Received: by 2002:a17:906:a20b:: with SMTP id r11mr44939265ejy.323.1620923988217; Thu, 13 May 2021 09:39:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMJ6G/mXyzvazrhxsdibSvEBgHlW+rXnAT9XNGvaw1X6w45ziPOwXYaDQ3/XElNOsKdyU9Iw== X-Received: by 2002:a17:906:a20b:: with SMTP id r11mr44939248ejy.323.1620923988073; Thu, 13 May 2021 09:39:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 10/10] default-configs/devices: Clarify ARM_COMPATIBLE_SEMIHOSTING is required Date: Thu, 13 May 2021 18:38:58 +0200 Message-Id: <20210513163858.3928976-11-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210513163858.3928976-1-philmd@redhat.com> References: <20210513163858.3928976-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) ARM_COMPATIBLE_SEMIHOSTING is not optional on these targets. Move the variable assignment out of the block documented with "Uncomment the following lines to disable these optional devices". Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Paolo Bonzini --- default-configs/devices/arm-softmmu.mak | 4 +++- default-configs/devices/riscv32-softmmu.mak | 4 +++- default-configs/devices/riscv64-softmmu.mak | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/default-configs/devices/arm-softmmu.mak b/default-configs/devi= ces/arm-softmmu.mak index 341d439de6f..2713e5e9eb7 100644 --- a/default-configs/devices/arm-softmmu.mak +++ b/default-configs/devices/arm-softmmu.mak @@ -1,5 +1,8 @@ # Default configuration for arm-softmmu =20 +# TODO: semihosting is always required - move to default-configs/targets/ +CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy + # TODO: ARM_V7M is currently always required - make this more flexible! CONFIG_ARM_V7M=3Dy =20 @@ -41,5 +44,4 @@ CONFIG_MICROBIT=3Dy CONFIG_FSL_IMX25=3Dy CONFIG_FSL_IMX7=3Dy CONFIG_FSL_IMX6UL=3Dy -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy CONFIG_ALLWINNER_H3=3Dy diff --git a/default-configs/devices/riscv32-softmmu.mak b/default-configs/= devices/riscv32-softmmu.mak index 5c9ad2590ef..7219f9749ad 100644 --- a/default-configs/devices/riscv32-softmmu.mak +++ b/default-configs/devices/riscv32-softmmu.mak @@ -1,9 +1,11 @@ # Default configuration for riscv32-softmmu =20 +# TODO: semihosting is always required - move to default-configs/targets/ +CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy + # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=3Dn -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy =20 # Boards: # diff --git a/default-configs/devices/riscv64-softmmu.mak b/default-configs/= devices/riscv64-softmmu.mak index 8a92f0a2c74..1d1b8bb9f68 100644 --- a/default-configs/devices/riscv64-softmmu.mak +++ b/default-configs/devices/riscv64-softmmu.mak @@ -1,9 +1,11 @@ # Default configuration for riscv64-softmmu =20 +# TODO: semihosting is always required - move to default-configs/targets/ +CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy + # Uncomment the following lines to disable these optional devices: # #CONFIG_PCI_DEVICES=3Dn -CONFIG_ARM_COMPATIBLE_SEMIHOSTING=3Dy =20 # Boards: # --=20 2.26.3