From nobody Tue Feb 10 00:23:14 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620923674; cv=none; d=zohomail.com; s=zohoarc; b=O9P8wsBgsWvXGmkQ5mKIPQIlCI3RzSwbPkiRWzqhWU5UTipt1QPbD/4dzSGZvCB5fluy2G8O5vX8W0ikgDUv6aGNLES7EWRh2j6DQBZMtdTLu59D2ZTmCJ78vo0fSG3XsvoRMXPd+Z+pMcZcKLigvkTxUtdvZoYLfpvRmg/wYUc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620923674; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5+1H2gGtRtAZDG0VpRdXHhbd0wUiC91qkBw+/1V6wv8=; b=n5TQK03H1x5m4c13ZvzhqWHJ3HiUCIxNw7fWWITqs6bovcC9NQrFkw8xz+dU5XcS9YMnj5XDp/oabVzNWX+aiLPLiSPpESSluviTHlS4YgJLfP/LrzljJtQSPOVyXkDawmk17lTEbgLZOH0wGl+pGkwQi3WRELkRRZHpo0cDjVE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620923674410600.2888840698662; Thu, 13 May 2021 09:34:34 -0700 (PDT) Received: from localhost ([::1]:33070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lhEIC-0002T5-Gr for importer@patchew.org; Thu, 13 May 2021 12:34:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhEDK-0002YR-L8 for qemu-devel@nongnu.org; Thu, 13 May 2021 12:29:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:38617) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lhED8-0003V7-1e for qemu-devel@nongnu.org; Thu, 13 May 2021 12:29:30 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-27-VYTMDIdINgqF4ji7VANMyg-1; Thu, 13 May 2021 12:29:14 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DDFD31005D4E; Thu, 13 May 2021 16:29:13 +0000 (UTC) Received: from virtlab701.virt.lab.eng.bos.redhat.com (virtlab701.virt.lab.eng.bos.redhat.com [10.19.152.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E276BA6F; Thu, 13 May 2021 16:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620923356; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+1H2gGtRtAZDG0VpRdXHhbd0wUiC91qkBw+/1V6wv8=; b=a5G3o/AU+Xn/7bTcBa5QcyjeDHtL1JRvJKB5ekBJNa+yEgqO2AiPVy9CBQUCgfK7bZvlpN nPfLWhsIa88/HFhNTmnlTu96YzPai8DxiTd9jKP1wg3eiEhUwnKKG9N53nxRiwme0Pdj7t ejw6DruIcdtR+PAF2ile4SCLLos64zg= X-MC-Unique: VYTMDIdINgqF4ji7VANMyg-1 From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH 13/14] machine: reject -smp dies!=1 for non-PC machines Date: Thu, 13 May 2021 12:29:00 -0400 Message-Id: <20210513162901.1310239-14-pbonzini@redhat.com> In-Reply-To: <20210513162901.1310239-1-pbonzini@redhat.com> References: <20210513162901.1310239-1-pbonzini@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yang.zhong@intel.com, berrange@redhat.com, ehabkost@redhat.com, armbru@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Paolo Bonzini --- hw/core/machine.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/core/machine.c b/hw/core/machine.c index 7daca0b86a..55e878fc3e 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -745,6 +745,10 @@ static void smp_parse(MachineState *ms, SMPConfigurati= on *config, Error **errp) unsigned cores =3D config->has_cores ? config->cores : 0; unsigned threads =3D config->has_threads ? config->threads : 0; =20 + if (config->has_dies && config->dies !=3D 0 && config->dies !=3D 1) { + error_setg(errp, "dies not supported by this machine's CPU topolog= y"); + } + /* compute missing values, prefer sockets over cores over threads */ if (cpus =3D=3D 0 || sockets =3D=3D 0) { cores =3D cores > 0 ? cores : 1; --=20 2.26.2