From nobody Mon Feb 9 16:19:28 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620771020; cv=none; d=zohomail.com; s=zohoarc; b=Oo0JkGxxVPpgkdnfF1ISmVJuW5dUbE7xBXOM8FPu/sroly3ubScLeMEpmDUiljYIaax5w64eXj9b0c5znAz+zeZznm+afg2AYJoVj+tr+DXfuQEhMrLxhlQjMAjoDt+MvEojkVmjvCtkYNCvjFv4g7SBxiTaE71bkCWYruvIhEA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620771020; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Z4guPBVDf8grv06qt3sxGquVrp6UojkYqZbZmCbkODc=; b=VJHF84Yx0tyz5oAn3HqqbEeqzhu5VwqMxd4RTUv6t2l/jnYxCUmfZxf5tghxttMs7RpNZ0yrkmBrOm7BX4pEp5I59DvO9LoAWFAmS6zGkg+UNthh2DNnyJFWYy0L6X1/BgsrYoO4dttx13Goo8kg2kaw6eL87a3ILpDUS9VUmpc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620771020000503.8920246768288; Tue, 11 May 2021 15:10:20 -0700 (PDT) Received: from localhost ([::1]:53246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgaa2-0007YT-P3 for importer@patchew.org; Tue, 11 May 2021 18:10:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgaW4-0007M4-Lc for qemu-devel@nongnu.org; Tue, 11 May 2021 18:06:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgaW1-0006Ni-Rv for qemu-devel@nongnu.org; Tue, 11 May 2021 18:06:12 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-TSdUsqT9MMK540AvssFdVw-1; Tue, 11 May 2021 18:06:07 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A481D800FF0; Tue, 11 May 2021 22:06:06 +0000 (UTC) Received: from scv.redhat.com (ovpn-117-64.rdu2.redhat.com [10.10.117.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id DE29560CC9; Tue, 11 May 2021 22:06:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620770769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z4guPBVDf8grv06qt3sxGquVrp6UojkYqZbZmCbkODc=; b=OZsVGFD6tItbziVucvj9/soLvXrhdV4BFxjw4q7GMGOF681bfXA+rXCu1uDwihezipDm7m q+9bKubcJ9GEwBSL6j/Mrrx8KBV1UBDeLqSK6TVN6XNQs91LpRWippS7PkKVNhzDkjoVfQ Hz8seyTM7ELBS+dZQiWGEEk9P+77kdE= X-MC-Unique: TSdUsqT9MMK540AvssFdVw-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v2 05/21] qapi/parser: Assert lexer value is a string Date: Tue, 11 May 2021 18:05:45 -0400 Message-Id: <20210511220601.2110055-6-jsnow@redhat.com> In-Reply-To: <20210511220601.2110055-1-jsnow@redhat.com> References: <20210511220601.2110055-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , John Snow , Eduardo Habkost , Markus Armbruster , Cleber Rosa Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The type checker can't narrow the type of the token value to string, because it's only loosely correlated with the return token. We know that a token of '#' should always have a "str" value. Add an assertion. Signed-off-by: John Snow --- scripts/qapi/parser.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py index d620706fffb..ba17f1357ad 100644 --- a/scripts/qapi/parser.py +++ b/scripts/qapi/parser.py @@ -304,6 +304,7 @@ def get_doc(self, info): cur_doc =3D QAPIDoc(self, info) self.accept(False) while self.tok =3D=3D '#': + assert isinstance(self.val, str) # comment token MUST have st= r val if self.val.startswith('##'): # End of doc comment if self.val !=3D '##': --=20 2.30.2