From nobody Mon Feb 9 12:26:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620769170; cv=none; d=zohomail.com; s=zohoarc; b=g5DasZXqLe3pdlCHyoO93J3yrw9l7KPeWwwUNDC3vqwPjOSDAUV7dlDX0b9aNuhHZz+m9D5lDOYrCf+O6guun/L+40lPX7La3OSxCk3GTi7RbiDPrdbQEcwSAqnG1qkvdzZ4iA2LR2yGRHq2o26rxh4FuSUh5qNB33qp1kukjiE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620769170; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PCqw1KRSIxu8BfBco+eNjqr0c/L/FZCMOAxIgy9bAyY=; b=FQEQwBHh8Rwzll6tKnrUN2T21DE9WIW2PGJUnE6L+G4aHslFTpi16eo7r1T2i2zidodg7OLWFSSSEwj8966BmXunvruurqzXsBIb6f2eRPGgjGuDnnT/g1aOA3Q+y6RbnbYLVe96bil+TV4uiPPl+9regJJGjwqoEkK/+UCoNnE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620769170618443.05645424782335; Tue, 11 May 2021 14:39:30 -0700 (PDT) Received: from localhost ([::1]:50004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lga6D-0001Zy-A2 for importer@patchew.org; Tue, 11 May 2021 17:39:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lga4f-0007MS-Qr for qemu-devel@nongnu.org; Tue, 11 May 2021 17:37:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lga4d-0005tA-BM for qemu-devel@nongnu.org; Tue, 11 May 2021 17:37:53 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-524-eLd8P5EwM2G2daKmD3s5cw-1; Tue, 11 May 2021 17:37:47 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 34E5E107ACE3 for ; Tue, 11 May 2021 21:37:47 +0000 (UTC) Received: from horse.redhat.com (ovpn-115-221.rdu2.redhat.com [10.10.115.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id C570718024; Tue, 11 May 2021 21:37:43 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 47009225FCF; Tue, 11 May 2021 17:37:43 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620769069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PCqw1KRSIxu8BfBco+eNjqr0c/L/FZCMOAxIgy9bAyY=; b=MiHu5OYNzduXtnen4d6VamgYFEItzIIyXoGM2fwvdqQnFaWXrhPkE7VwxXBLchPAI7NoAX gtQN66OTyix/I8lgh8io9o8pS80U1OQaycAE0MucGxFq4v+qX24PKlav2MAFIyiIFuDjYp lxulAdeUJEh6nh20BirLFgchFvjR8d0= X-MC-Unique: eLd8P5EwM2G2daKmD3s5cw-1 From: Vivek Goyal To: qemu-devel@nongnu.org, virtio-fs@redhat.com Subject: [PATCH 3/7] virtiofsd: Use iov_discard_front() to skip bytes Date: Tue, 11 May 2021 17:37:32 -0400 Message-Id: <20210511213736.281016-4-vgoyal@redhat.com> In-Reply-To: <20210511213736.281016-1-vgoyal@redhat.com> References: <20210511213736.281016-1-vgoyal@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=vgoyal@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=vgoyal@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dgilbert@redhat.com, vgoyal@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" There are places where we need to skip few bytes from front of the iovec array. We have our own custom code for that. Looks like iov_discard_front() can do same thing. So use that helper instead. Signed-off-by: Vivek Goyal Reviewed-by: Dr. David Alan Gilbert --- tools/virtiofsd/fuse_virtio.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c index 5dcd08fccb..d56b225800 100644 --- a/tools/virtiofsd/fuse_virtio.c +++ b/tools/virtiofsd/fuse_virtio.c @@ -389,23 +389,15 @@ int virtio_send_data_iov(struct fuse_session *se, str= uct fuse_chan *ch, memcpy(in_sg_cpy, in_sg, sizeof(struct iovec) * in_num); /* These get updated as we skip */ struct iovec *in_sg_ptr =3D in_sg_cpy; - int in_sg_cpy_count =3D in_num; + unsigned int in_sg_cpy_count =3D in_num; =20 /* skip over parts of in_sg that contained the header iov */ size_t skip_size =3D iov_len; =20 size_t in_sg_left =3D 0; do { - while (skip_size !=3D 0 && in_sg_cpy_count) { - if (skip_size >=3D in_sg_ptr[0].iov_len) { - skip_size -=3D in_sg_ptr[0].iov_len; - in_sg_ptr++; - in_sg_cpy_count--; - } else { - in_sg_ptr[0].iov_len -=3D skip_size; - in_sg_ptr[0].iov_base +=3D skip_size; - break; - } + if (skip_size !=3D 0) { + iov_discard_front(&in_sg_ptr, &in_sg_cpy_count, skip_size); } =20 int i; --=20 2.25.4