From nobody Sat May 18 21:45:43 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620748634; cv=none; d=zohomail.com; s=zohoarc; b=Vec2R9QBfn8B3JWjGMYNl6s2QHe3fMD1tenQwBOBDdBtdnX+5pREFP4ttq6BgCU40mUJhlaro6wstrYVfD3P/PSiqICnU7EmZsGSOjiWk+GsfQ8Zt03XRC5lhH9kU+zD0y+Z6TW3XU3pCfPENuOOEYHT+wX7bg9gQ5Lc3dwHO28= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620748634; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=uH9oZ89gvWoYRdRll+1JTa/YDb5VPJzxnFVJfT2wFN4=; b=Daf6MFhmSqALnkhLoAYkJEtOLN0ieO5+hsOQSpaW+cWLJKFF1dvv5DU0HE+Nm1XHNOXMG1gGbjpLvK8aRd09CURLGbm+cQeNFJwmX5KOHkH3aZl06AM3ad+GajYqPEw12+wDqbgGIar9oNhRELcdgrNqeK2K8NJ5CX4Yi0gkw9Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620748634631370.4279830329908; Tue, 11 May 2021 08:57:14 -0700 (PDT) Received: from localhost ([::1]:36248 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgUky-0008ES-T5 for importer@patchew.org; Tue, 11 May 2021 11:57:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgUiC-0005CI-A0 for qemu-devel@nongnu.org; Tue, 11 May 2021 11:54:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:52706) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgUi7-0001Qy-Mf for qemu-devel@nongnu.org; Tue, 11 May 2021 11:54:19 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-307-zNgkQEQPPkyjQRJIYjPomQ-1; Tue, 11 May 2021 11:54:10 -0400 Received: by mail-wr1-f70.google.com with SMTP id 36-20020adf91a70000b029010ec34b3f27so727073wri.10 for ; Tue, 11 May 2021 08:54:10 -0700 (PDT) Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id u8sm3665961wmq.29.2021.05.11.08.54.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 May 2021 08:54:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620748453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uH9oZ89gvWoYRdRll+1JTa/YDb5VPJzxnFVJfT2wFN4=; b=guq6tEPiiiayC08O0+lGIur8D8nBYA3mG7IJdtJ1tZdz5/fFNovi7OZsjYVDJbEba4Bevd 8e59hP0rOsMiuUm7Otb0qXXbiLgoV9cRiePb4lV/275Jlx1sF4WIzpPsX8Y7Nmru/G7UTq PCOW7PamYPIwl7Ay0+Gavsce2DKYfN4= X-MC-Unique: zNgkQEQPPkyjQRJIYjPomQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=uH9oZ89gvWoYRdRll+1JTa/YDb5VPJzxnFVJfT2wFN4=; b=Bsau2PNrmTNPzY7KHb19dPEt7pzG0x2HrTXU+Cntc9QA6yOp+uk/i791UBga+c8kFB EyKv0wnpwjt/ehLqSG2LKcZiKubo5iESkJ2X9LUkW3lofPBqULh7x9PnKNMv56j99cEh 9Ir3lV8+eCPHuluG+8hqAVdccDllCvzThosyz7KYuItK3VijKQps5oM3GFO3eFCfAfco L+CaD93DnSosa9pzVdNWgKjAafsiqJ3QFS/YhhFpC6EI9PJLXEZC8Ko++k4kwD83GkRZ K93m9i0QvXGPN8G912KFYKMSQU2s3RN8oh8NyOvmga4aT8nftiTdXfgUblNRQh5FJC7P ZZbQ== X-Gm-Message-State: AOAM531RU990F3sJ1LWMjpZNP+MTykf4L5a4/ZzLdoc00Lh85xTKytvA UU34KsL6DthyaIWUCUpT91qoGuOGB20T36FjHrPFSWjTUsnynuOBdZyTUH89Fh3E7OvxGNTqNO4 /QVvFe/CPQ1/JDiE8rR0lXR1aYY4o6Q6YXcVpOw6JuJpHJyXZ9DgP90aeJkPqOGco X-Received: by 2002:a5d:47a9:: with SMTP id 9mr39155873wrb.298.1620748447999; Tue, 11 May 2021 08:54:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyq2zzJ+fkfSXW3iPHupw14zdOeY2d6riQs8R4dzdXgmDf3uscdF51vxAyQaZtwAIyddEFxOQ== X-Received: by 2002:a5d:47a9:: with SMTP id 9mr39155846wrb.298.1620748447727; Tue, 11 May 2021 08:54:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [RFC PATCH 0/5] buildsys: Do not use internal fdt library when asked for the system one Date: Tue, 11 May 2021 17:53:49 +0200 Message-Id: <20210511155354.3069141-1-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Alexey Kardashevskiy , Greg Kurz , qemu-ppc@nongnu.org, John Paul Adrian Glaubitz , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Attempt to fix the issue reported by John when building with an outdated libfdt. For now it changes: hw/ppc/spapr_hcall.c: In function =3DE2=3D80=3D98h_update_dt=3DE2=3D80=3D= 99: hw/ppc/spapr_hcall.c:1966:9: warning: implicit declaration of function = =3DE2=3D =3D80=3D98fdt_check_full=3DE2=3D80=3D99; did you mean =3DE2=3D80=3D98fdt_ch= eck_header=3DE2=3D80=3D =3D99? [-Wimplicit-function-declaration] 1966 | if (fdt_check_full(fdt, cb)) { | ^~~~~~~~~~~~~~ | fdt_check_header hw/ppc/spapr_hcall.c:1966:9: warning: nested extern declaration of =3DE2= =3D80=3D =3D98fdt_check_full=3DE2=3D80=3D99 [-Wnested-externs] [...] /usr/bin/ld: libqemu-ppc64-softmmu.fa.p/hw_ppc_spapr_hcall.c.o: in functi= on=3D `h_update_dt': hw/ppc/spapr_hcall.c:1966: undefined reference to `fdt_check_full' collect2: error: ld returned 1 exit status by: qemu/meson.build:1352:4: ERROR: Running configure command failed. The following clauses were found for PSERIES CONFIG_PSERIES=3D3Dy config PSERIES depends on FDT which is not better, but one step at a time... John said: https://gitlab.com/qemu-project/qemu/-/issues/255#note_572421108 Distributions usually don't used embedded copies of libraries, so the configure script should require the correct minimum version. Personally I'd rather allow users to build the most of QEMU with what is available, that is all possible machines except pSeries, making pSeries machine selected by default and deselected if not possible, with this change: -- >8 -- diff --git a/default-configs/devices/ppc64-softmmu.mak b/default-configs/de= vi=3D ces/ppc64-softmmu.mak index cca52665d90..62339661fca 100644 --- a/default-configs/devices/ppc64-softmmu.mak +++ b/default-configs/devices/ppc64-softmmu.mak @@ -5,6 +5,3 @@ include ppc-softmmu.mak # For PowerNV CONFIG_POWERNV=3D3Dy - -# For pSeries -CONFIG_PSERIES=3D3Dy diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig index 3935b73456f..706debd4fee 100644 --- a/hw/ppc/Kconfig +++ b/hw/ppc/Kconfig @@ -1,5 +1,6 @@ config PSERIES bool + default y depends on FDT imply PCI_DEVICES imply TEST_DEVICES --- But I suppose it breaks user expectations. Thoughts? Regards, Phil. Philippe Mathieu-Daud=3DC3=3DA9 (5): hw/mem/nvdimm: Use Kconfig 'imply' instead of 'depends on' Kconfig: Declare 'FDT' host symbol hw/ppc: Have pSeries depends on libfdt (via host Kconfig FDT symbol) hw/ppc/fdt: Drop dependency on libfdt meson: Do not use internal fdt library if user asked for the system one default-configs/devices/ppc64-softmmu.mak | 1 - meson.build | 2 +- Kconfig.host | 3 +++ hw/arm/Kconfig | 1 + hw/i386/Kconfig | 1 + hw/mem/Kconfig | 2 -- hw/ppc/Kconfig | 2 ++ hw/ppc/meson.build | 8 ++++---- 8 files changed, 12 insertions(+), 8 deletions(-) --=3D20 2.26.3