From nobody Mon Feb 9 11:39:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1620656127; cv=none; d=zohomail.com; s=zohoarc; b=Ly6wE+lSQCYjQgQ2fVKIzFi84SimnZ+9fxFM/e08RWo2rwOtMOu+zcac1Gm59eRpb0KNB5uhsVgBC6CHh8A/39JnVf23uTyuqpSnqYJ7+Vd1wpY02RAnQvRPrnWlvyt4sge0cy5GWUj/CyhSpiX3ZcP6IQUXmGRYccUKE3DI7xU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620656127; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=e45WEoByRlwYVI/iUZ0gEoaTPjvnork4kAHZ0YtyklE=; b=mve8+379qK3XH97OjHrsB7y5txN9OZSXl3BfZHlTrz8Kh7bgw1nJskXPaqKXO63G+pSR9iyjS9It6UMfI/mrxPyLAnM/sKsdgTPTe6EtHgBs/ojUgVkXiwdkH/kLEcP281ynbAhqAtWi77lv7RMXDOgkUvnEx5fmeJ4Fan42FrA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620656127091174.69981946586472; Mon, 10 May 2021 07:15:27 -0700 (PDT) Received: from localhost ([::1]:54554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lg6gt-0004tW-W0 for importer@patchew.org; Mon, 10 May 2021 10:15:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33872) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg6fv-0003hk-KK for qemu-devel@nongnu.org; Mon, 10 May 2021 10:14:23 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg6ft-00028D-2c for qemu-devel@nongnu.org; Mon, 10 May 2021 10:14:23 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Ff2zR73Yjz1BHqh for ; Mon, 10 May 2021 22:11:31 +0800 (CST) Received: from huawei.com (10.175.124.27) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 22:14:01 +0800 From: Jie Wang To: Subject: [PATCH v2] util: fix fd leak in qemu_write_pidfile() Date: Mon, 10 May 2021 22:11:48 +0800 Message-ID: <20210510141148.3138904-1-wangjie88@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.190; envelope-from=wangjie88@huawei.com; helo=szxga04-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangxinxin.wang@huawei.com, wangjie88@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" if execute qemu_open success, have no branch to free the fd, so unlink it inadvance, let it free by process exit. Signed-off-by: Jie Wang --- util/oslib-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 36820fec16..fa881f2ee8 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -131,6 +131,7 @@ bool qemu_write_pidfile(const char *path, Error **errp) error_setg_errno(errp, errno, "Cannot open pid file"); return false; } + unlink(path); =20 if (fstat(fd, &b) < 0) { error_setg_errno(errp, errno, "Cannot stat file"); --=20 2.23.0