From nobody Sat Feb 7 02:56:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1620641005; cv=none; d=zohomail.com; s=zohoarc; b=dqtuiIIA8KVhKiyxEiZfZZNRtU2D6EFvBa7vuMVFwBP0IVsGGX41iYGQiw6SB3PdaXm9znTi4Qgla2690Ply+fjsPT0VED85dWY27+5qgylT05X9JcraeZu9qYLa0uUgIBsdQOiK+1AJR3G+XJifzzJXNSDXJPAGUbNZnRP1Mg4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620641005; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=TxDb/PNs9Z7TqUy01ijkBYRLWSoF5bU7wxJ5rK180z8=; b=Mc0LRWzslpxU4dIwrbrd0SSd1tBwfIKMh+bfmbZoGG7yMrM12xXSdQhkK/1JlbsgpiTf4/r3Cdb7wRW2E0vYCpspzn29mzC9qbayMaOnlQAp2Kb4dDxpJVxGuFdnD9i3vU4cawstw2MD4xQI8ttUhXqp2ppk4yXPEUjUwKLVZhg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620641005937917.0781820351831; Mon, 10 May 2021 03:03:25 -0700 (PDT) Received: from localhost ([::1]:48290 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lg2l2-0001uN-Az for importer@patchew.org; Mon, 10 May 2021 06:03:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg2hV-0005NI-RI for qemu-devel@nongnu.org; Mon, 10 May 2021 05:59:45 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:2606) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lg2hT-0008G7-3o for qemu-devel@nongnu.org; Mon, 10 May 2021 05:59:45 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FdxKh0W4GzCr7P for ; Mon, 10 May 2021 17:56:56 +0800 (CST) Received: from huawei.com (10.175.124.27) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Mon, 10 May 2021 17:59:27 +0800 From: Jie Wang To: Subject: [PATCH] util: fix fd leak in qemu_write_pidfile() Date: Mon, 10 May 2021 17:57:08 +0800 Message-ID: <20210510095708.950474-1-wangjie88@huawei.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.175.124.27] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.35; envelope-from=wangjie88@huawei.com; helo=szxga07-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wangxinxin.wang@huawei.com, wangjie88@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" if execute qemu_open success, have no branch to free the fd, so unlink it inadvance, let it free by process exit. Signed-off-by: Jie Wang --- util/oslib-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 36820fec16..30bf39bf4f 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -131,6 +131,7 @@ bool qemu_write_pidfile(const char *path, Error **errp) error_setg_errno(errp, errno, "Cannot open pid file"); return false; } + unlink(path); =20 if (fstat(fd, &b) < 0) { error_setg_errno(errp, errno, "Cannot stat file"); --=20 2.23.0