From nobody Wed Feb 11 02:57:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620249080; cv=none; d=zohomail.com; s=zohoarc; b=bxjnMO41ePYjy+keqYtQE2j7mhleXjpKh06ZY0slIetHzf7AVcJgCj0OnvVwCzbpgRGgKTbLHymtJD9X1Avt1FeEaLo2Fh+Pt+z+uLzysmk+o1uLk9EMJcsGf+35L/Ath6RRHRb5rkO1LiVYvkeOsEQ2X0u/l7e7jZFHgJaU0sI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620249080; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=8XsKwZNupJ+4f3H9PdgeWNChZDELAQClzri8f7pUD+M=; b=frF/Us+UMBsORe1KKc1LB6HSHvflcNUTF+WGFOWPXibO4hVbnBsbDvqAN3nTAazEybH7fxGjktGGZ6/pCMBR0a4HBIZ90hY/KGm2wNg5AwgYlOakhS6+sVYAWGfU5fG8W0EWrmrSzkEqLLpreaLWgqlAtbn/7MXJv2tLDL0YMj4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620249080515338.66738930618817; Wed, 5 May 2021 14:11:20 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-555-YVtMglimOK2Z5ESH8AHgTQ-1; Wed, 05 May 2021 17:11:17 -0400 Received: by mail-wr1-f71.google.com with SMTP id 4-20020adf80040000b029010cab735fdeso1207458wrk.14 for ; Wed, 05 May 2021 14:11:17 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id h14sm814414wrq.45.2021.05.05.14.11.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 14:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620249079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8XsKwZNupJ+4f3H9PdgeWNChZDELAQClzri8f7pUD+M=; b=Nj2zWNu42JRoqzySuk9CxLKBUbbFBVbf/StLmNHTHMRAgtQ70xBtQGaNKQ8ziQIEXtvJ5v twesmA+kDs+jgLNk01dPwg1HzpdYSt46TRc9b1l+CKSJgdRFkI3+jhyKNgAOJGZf8I31Tb Y8S8cQchgeSZ+628lGue/p69LkpvsOQ= X-MC-Unique: YVtMglimOK2Z5ESH8AHgTQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8XsKwZNupJ+4f3H9PdgeWNChZDELAQClzri8f7pUD+M=; b=h7c7/arvm6bhzMv/5pcIxRKsrXG1EArjB9iFG+yksJq4hG4OeryCaTqHbx1FNuwEra eZuzWgkS+o65jSIn6hs+PPzCQn5FmIMcq+k66wugwunqtIGsfMdZM0r3nFBFVhNnvvII yxucN1RJB1H0gHptVcDRpyj7Zz9DqcykD0iHf4FDC2jvurn358osYtlLwSljGQhWh5tQ snay+FVt4AsZ8wxgw0j6NM5vYGAh/weL6n3kCZmKVAjJ/qR8k4NfWPjmjQFEXGoLjynM izTYPFMM/izE/hnOAqDhE70ZjirrZRYLI+ZoBTGPkx+Xlwg/k93O51sRMtaEBGu2CAFp b+qg== X-Gm-Message-State: AOAM533xZYC6qaCpe/spLMfvC6icq4Z1KzxNI/Ies+VDFKtW4gXtgg2j fXlTqIvtcWnb5w1P6JIsu1I2IKxza4Q2EUQy9EBg3AtH5g+pvvNLl3Of6+fq/GiWwSYwivpp+rO xXyepw6lv/7zmYg== X-Received: by 2002:adf:e5cd:: with SMTP id a13mr1000815wrn.303.1620249076647; Wed, 05 May 2021 14:11:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHHkV8frGxn8o8BSzf/TM9ljlb72+T/9RYIbN9zU07xxuIRtGSed2exRv5kWaKaBCsAaiysA== X-Received: by 2002:adf:e5cd:: with SMTP id a13mr1000803wrn.303.1620249076541; Wed, 05 May 2021 14:11:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org, Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 05/23] io/channel-websock: Replace strlen(const_str) by sizeof(const_str) - 1 Date: Wed, 5 May 2021 23:10:29 +0200 Message-Id: <20210505211047.1496765-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210505211047.1496765-1-philmd@redhat.com> References: <20210505211047.1496765-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The combined_key[... QIO_CHANNEL_WEBSOCK_GUID_LEN ...] array in qio_channel_websock_handshake_send_res_ok() expands to a call to strlen(QIO_CHANNEL_WEBSOCK_GUID), and the compiler doesn't realize the string is const, so consider combined_key[] being a variable-length array. To remove the variable-length array, we provide it a hint to the compiler by using sizeof() - 1 instead of strlen(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- io/channel-websock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index 03c1f7cb62f..cd7bba6bde7 100644 --- a/io/channel-websock.c +++ b/io/channel-websock.c @@ -32,7 +32,7 @@ =20 #define QIO_CHANNEL_WEBSOCK_CLIENT_KEY_LEN 24 #define QIO_CHANNEL_WEBSOCK_GUID "258EAFA5-E914-47DA-95CA-C5AB0DC85B11" -#define QIO_CHANNEL_WEBSOCK_GUID_LEN strlen(QIO_CHANNEL_WEBSOCK_GUID) +#define QIO_CHANNEL_WEBSOCK_GUID_LEN (sizeof(QIO_CHANNEL_WEBSOCK_GUID) - 1) =20 #define QIO_CHANNEL_WEBSOCK_HEADER_PROTOCOL "sec-websocket-protocol" #define QIO_CHANNEL_WEBSOCK_HEADER_VERSION "sec-websocket-version" --=20 2.26.3