From nobody Mon Feb 9 13:54:07 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620249075; cv=none; d=zohomail.com; s=zohoarc; b=It6YeHf1J6QaeGVcfWq0co4yQhXugbxWgo9ierTWlRpf5J0+BbKTQck486kCVLXi3Zf/DG7y7Q8zvR1DtarnV7CLUVUIoIuBEYVmI+8JKRa6hbWm/PfdVSC/HgSA5DCdJAwugHuja4unlQIb/RoT+9mNrh08FuTJW8/ug4F+YjM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620249075; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Jsw0hjQgHEh8fe+V8icgihsn1Zo56TzjPc95CU2mxS0=; b=e7cUGl0RUTabFBFmKtwGWTkHTsQ3kNtRhQtrqfP8o8w0/pc+E7T3eOwfLI5Xo0AYdpMwdUCyZGoO7AoByXxT7Ad78Nl6Bw3xYdhmAIjG/YD5je+MnhOotAoumdgZgFO7psP/l9ZpXun71WHHBN06ehNp6H0mdhDtrc4FyuD6n84= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620249075470716.7879379843074; Wed, 5 May 2021 14:11:15 -0700 (PDT) Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-wIs0kaLqOdqjZqvOo92ltQ-1; Wed, 05 May 2021 17:11:10 -0400 Received: by mail-wr1-f72.google.com with SMTP id 93-20020adf93e60000b029010d9bb1923eso1219538wrp.4 for ; Wed, 05 May 2021 14:11:10 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id m6sm761402wrp.29.2021.05.05.14.11.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 14:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620249074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jsw0hjQgHEh8fe+V8icgihsn1Zo56TzjPc95CU2mxS0=; b=iJYLh8lkFwIDjTIpoOgB2F/8grBvVei5TU0///P3gou2FnwOtsvKfD1HCIB3IKy1TEyMSk dH0i0tbOBHl3StH9NX6FyrpjlTP144AV+HXLJxsvmQ55mLd34KMOJm5HI4H9QKw7ccd6ZD vY7gbMYC8o/36TQAAUseh/clb5E7cto= X-MC-Unique: wIs0kaLqOdqjZqvOo92ltQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Jsw0hjQgHEh8fe+V8icgihsn1Zo56TzjPc95CU2mxS0=; b=aB6dt8vPugZ2nInp23wtyhwgZHLxU/oGkkWkNEGaOoKQ5lM2CavPygoKrZFu34OKep m+J6NNc+WD/t5jmE2NCuAHYMQwa+3NUj9BAiGk6z5jrt3Qn8dX6zR5jlH19PKS3cle9M e6ND9VeIuxvsefvmTnY/9KZiz95LOfrEIdgWbd6gJnbGd7H3xGvhE2ehWnhdS+/3Yv4s PT1sUlY9is/jG/fa+Yui00rSlblWQ8ulTc2Ufz6magiiNk5Y5TU+IZ3rlNg3nR/IkIHk 0mWni/pRE3ioVmJ8HPt+OCIIqrrheXdHul/XhNyj3wkQQ3Bitp4U+khUnpCh7gET2cOv AH7A== X-Gm-Message-State: AOAM531yMhhSLRIS2QdPzPha/l5DYpcCyWOOBYW7WzZPNXz3mLsmW8ub C/g+/y4qzxUJ4kn4zJEfGZgGBIk2u0F4hfsBxS+bpLnqRb8Z+aSIgGzWcIC5kvFElaRTHMZpazM 7+mAWe+Rfcitnyg== X-Received: by 2002:a05:600c:2d42:: with SMTP id a2mr11900711wmg.99.1620249069601; Wed, 05 May 2021 14:11:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFx12/Cfj5SAGn1R6ueiw6IPzEuQQsz5cieDZOJJF77UKfykeNTFXuTfy86XJg4oIqT3Aung== X-Received: by 2002:a05:600c:2d42:: with SMTP id a2mr11900694wmg.99.1620249069425; Wed, 05 May 2021 14:11:09 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , qemu-ppc@nongnu.org, Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Samuel Thibault Subject: [PATCH 04/23] chardev/baum: Avoid dynamic stack allocation Date: Wed, 5 May 2021 23:10:28 +0200 Message-Id: <20210505211047.1496765-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210505211047.1496765-1-philmd@redhat.com> References: <20210505211047.1496765-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Use autofree heap allocation instead of variable-length array on the stack. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Samuel Thibault --- chardev/baum.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/chardev/baum.c b/chardev/baum.c index 0822e9ed5f3..bc09cda3471 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -299,7 +299,8 @@ static void baum_chr_accept_input(struct Chardev *chr) static void baum_write_packet(BaumChardev *baum, const uint8_t *buf, int l= en) { Chardev *chr =3D CHARDEV(baum); - uint8_t io_buf[1 + 2 * len], *cur =3D io_buf; + g_autofree uint8_t *io_buf =3D g_malloc(1 + 2 * len); + uint8_t *cur =3D io_buf; int room; *cur++ =3D ESC; while (len--) --=20 2.26.3