From nobody Mon Feb 9 16:18:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620234087; cv=none; d=zohomail.com; s=zohoarc; b=AYzzb64iSs61v56Fyhws42AnOKBMKQfYHubIILcDI5MQHjO0b/yMAPIAKjKhP/kWi2gek/ntrAv1sHUORpYFlw//vBYCyF4NglW2+r7B9lG9CDGZNpzMxG/uttgeRQ61hXgCBKl76owqzyycfJzimtNeWkrpmT5YeTaRcleEH/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620234087; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=7g2k8F+O24ILX6i9wlywTWqxuX2ak4LnZOnLn8IJqNY=; b=CXItrq85+oFn+lVrhgpO5O7aLezz7fq7pR59woCbMvVjzstQ7aWi5kNZDqGirxyq2T+IoOamfEt05ZNypnAvT0Uq7sC/WWI/nU2Y4QqY4FLYrHYYSZyH/4CpsZU5TQG2gKI6vFblgBvXRQbufz64+l5y9mvk7TRnK9DlwU5xji0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620234087208931.7896708131002; Wed, 5 May 2021 10:01:27 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-liQlKAOqM-OV02B-33Mnow-1; Wed, 05 May 2021 13:01:23 -0400 Received: by mail-wr1-f71.google.com with SMTP id a7-20020adfc4470000b029010d875c66edso932530wrg.23 for ; Wed, 05 May 2021 10:01:22 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id q10sm15824317wre.92.2021.05.05.10.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 10:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620234084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7g2k8F+O24ILX6i9wlywTWqxuX2ak4LnZOnLn8IJqNY=; b=I0Acs7JkAFBGnjbE8cg/Ed4v4TpGNX+hKW6gXg9rfrvLDEC5VUREMhdQjZ11yJ1YkugWBi PNs0IC4b/N6wY7U30ZRX7LqayFAnVQQUiNY6rxqw9Dg3UQVnedQp1IXEzV0VwIVEeeTGVY FhdC/d24D/bVmKtiwbVOhFWn6hH8/HU= X-MC-Unique: liQlKAOqM-OV02B-33Mnow-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7g2k8F+O24ILX6i9wlywTWqxuX2ak4LnZOnLn8IJqNY=; b=VmuIpZsg31HgYZIWdlwe7juIXKBshDT4mANBXPu3X1vFqPG2Dc9D1oeyP0hCCtAlf0 XY/HeFiOa8Jxg2edzX1j/9pyHlQIFJEUSM+R3lP5OvqP3zS6KcGhnJRLt6uzmcZ3q6YG BuZMH19KKJnfhdIjcht3ZHjpGZfbe9Wp3UUfLgS6FeYQwPZ3alBc25tne91fD3MucWqy DYrxDX52h9PUc44QCENrFwQRkA/UA8T2Evnhnjo/36vrPJCi+V8UKoLppXVCsK1/SN7Z PQms5WtsxX3/sHQAh3fz5bumO26+jzYtBSmqqXmSye/9p3nzfrB/svU+ppkeqGUQK1Dk P/cA== X-Gm-Message-State: AOAM533jad63t/jMust7oxIHiW7a20ZbCaNWUYuL64IcZbnb0VCOlJ8D YuEPv7VNiZJ81goICwqiNhzNTO5LhAkmysEKF8EUsUhpGxb0/e+LWvCZFQnpu1gj/K7GHyVjNA+ oRQQ4W4IoodpjlA== X-Received: by 2002:a1c:1d50:: with SMTP id d77mr11295076wmd.114.1620234081692; Wed, 05 May 2021 10:01:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmgH4JwP3i9dHZjwwiWSGdQcazy8feE/fCrd6Xa/tz3JD28tBwB4MYsNyH0CmUS+lyRxh2hg== X-Received: by 2002:a1c:1d50:: with SMTP id d77mr11295057wmd.114.1620234081584; Wed, 05 May 2021 10:01:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson , Paolo Bonzini , Warner Losh , Kyle Evans , Greg Kurz , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-ppc@nongnu.org (open list:PowerPC TCG CPUs), kvm@vger.kernel.org (open list:Overall KVM CPUs) Subject: [PATCH 5/5] target/ppc/kvm: Replace alloca() by g_malloc() Date: Wed, 5 May 2021 19:00:55 +0200 Message-Id: <20210505170055.1415360-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210505170055.1415360-1-philmd@redhat.com> References: <20210505170055.1415360-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The ALLOCA(3) man-page mentions its "use is discouraged". Replace it by a g_malloc() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson --- target/ppc/kvm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 104a308abb5..ae62daddf7d 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2698,11 +2698,11 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bu= fsize, int64_t max_ns) int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index, uint16_t n_valid, uint16_t n_invalid, Error **e= rrp) { - struct kvm_get_htab_header *buf; - size_t chunksize =3D sizeof(*buf) + n_valid * HASH_PTE_SIZE_64; + size_t chunksize =3D sizeof(struct kvm_get_htab_header) + + n_valid * HASH_PTE_SIZE_64; ssize_t rc; + g_autofree struct kvm_get_htab_header *buf =3D g_malloc(chunksize); =20 - buf =3D alloca(chunksize); buf->index =3D index; buf->n_valid =3D n_valid; buf->n_invalid =3D n_invalid; @@ -2741,10 +2741,10 @@ void kvmppc_read_hptes(ppc_hash_pte64_t *hptes, hwa= ddr ptex, int n) i =3D 0; while (i < n) { struct kvm_get_htab_header *hdr; + char buf[sizeof(*hdr) + HPTES_PER_GROUP * HASH_PTE_SIZE_64]; int m =3D n < HPTES_PER_GROUP ? n : HPTES_PER_GROUP; - char buf[sizeof(*hdr) + m * HASH_PTE_SIZE_64]; =20 - rc =3D read(fd, buf, sizeof(buf)); + rc =3D read(fd, buf, sizeof(*hdr) + m * HASH_PTE_SIZE_64); if (rc < 0) { hw_error("kvmppc_read_hptes: Unable to read HPTEs"); } --=20 2.26.3