From nobody Mon May 6 15:06:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620234551; cv=none; d=zohomail.com; s=zohoarc; b=ana0olwQWahPvD0Mg+t6Dv1jWzSHU7u21bnBPY7iavbCcCi8wKIENu5HAGTk9/17hkfMS1KlF9gz0eZEcuhnth9wwX1h+E4x7eY5XHCPMpo0jKX6U4M/iwvtcXpbbHQYA3PBx2NZqqr4dKQM3pi1hHaehFlxDh0ke0n3ttbmJVo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620234551; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dXiqUMGNseF8aEoCidrrmNydk4TNmOpI8OAZgIN0M9M=; b=ZarK+z4DjsIfOZUFafHRFFTi9SiEEm2D/XlCs3R31gGNP+eU/Heue6p56dGwIeADTVzSQsAFyrNgA60UDVTpcV8tah0MxeaRK4fmE3ScozEsk9IyjiwvoLcx/LUDVIdvRN6hXqeWibmT4bdlGEIExHNgiqsfqlzxx7/Q1sJddIo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620234551016578.7657959265982; Wed, 5 May 2021 10:09:11 -0700 (PDT) Received: from localhost ([::1]:52914 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leL1J-0004ik-Oh for importer@patchew.org; Wed, 05 May 2021 13:09:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47694) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leKtl-00066S-Fc for qemu-devel@nongnu.org; Wed, 05 May 2021 13:01:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37230) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leKte-0002O1-Sj for qemu-devel@nongnu.org; Wed, 05 May 2021 13:01:21 -0400 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-ezFrNEcSPjK7kd1QlTiEaA-1; Wed, 05 May 2021 13:01:03 -0400 Received: by mail-wm1-f69.google.com with SMTP id y184-20020a1ce1c10000b0290143299f39d7so1805648wmg.4 for ; Wed, 05 May 2021 10:01:03 -0700 (PDT) Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id m7sm6814316wrv.35.2021.05.05.10.01.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 10:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620234065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dXiqUMGNseF8aEoCidrrmNydk4TNmOpI8OAZgIN0M9M=; b=Jfx94TRaZx2tQ3JCTyLTQ76Ipo6yOxEu0Sewfzwu+Qw41d0ZEURG6tn2HwpJ3sSc3b8/JZ Nspz9qN9mYfJTsB+pHHC1/l+xPU2cTQsmKju11jVhS7W3xo26F7GMZfN6y/2X4G9giOGoy ndIZfI91axfoHN8jNYhcOFOEyJIFMoc= X-MC-Unique: ezFrNEcSPjK7kd1QlTiEaA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dXiqUMGNseF8aEoCidrrmNydk4TNmOpI8OAZgIN0M9M=; b=ViH/2f48A5kqWoVxlGSWWqMoWAheDWVT0z03cFzO0iPk6HgLzTUL9NUVUHDg2RxKdC 5ZMvnQnAvhfkCagI6JLdQDdLO7mEJW1RYyuzod2Dl5zz1tzo7+7seOzgGuERb5pIEhY4 SIuwaNvAFKCp5fvh3bZPACu5SSJqSBM2v7GfZBi1nDHITJogdqpDeWHeHDZujVeJEpMl XMhGgMw69R/Nayvehn8vA2J2O8w48ETbys3mjo1vNtAaKeNu7o8SepmSV0nnmqvDv/eP o3b76oylWDckxfDOx+1+Os6FgToHpu7Gnwd4gYN3qQTiBV/K5VLLhHxL7aqxS401/QPK ih+w== X-Gm-Message-State: AOAM53034jFGjfuWCGOs7dc5G5/3JJAQaoPnbDg91Y1OWYG424GMhzSV AqUbtHLtxUcetNBwnmv0Q4eHcfnPQqGnGczDXIQ6RIDRfM0fO5ILLQ0gbuGbY/Imdta9TUyc8pa mzNWdNnX/4pAkUOo3UvEhb/d47DUN3GRUc7eOaaiI+2YLL/6aBUmQYT/RkJIWbwhh X-Received: by 2002:a7b:c248:: with SMTP id b8mr11424875wmj.150.1620234062147; Wed, 05 May 2021 10:01:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxE9b3pj/YxZNlRHG2GkXBUvD3WDR/aewpjObwARt5wff69Kml4yF8lCFHOeEDahXzD3Sem3A== X-Received: by 2002:a7b:c248:: with SMTP id b8mr11424837wmj.150.1620234061759; Wed, 05 May 2021 10:01:01 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/5] bsd-user/syscall: Replace alloca() by g_new() Date: Wed, 5 May 2021 19:00:51 +0200 Message-Id: <20210505170055.1415360-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210505170055.1415360-1-philmd@redhat.com> References: <20210505170055.1415360-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.693, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kyle Evans , Greg Kurz , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Warner Losh , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The ALLOCA(3) man-page mentions its "use is discouraged". Replace it by a g_new() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- bsd-user/syscall.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bsd-user/syscall.c b/bsd-user/syscall.c index 4abff796c76..dbee0385ceb 100644 --- a/bsd-user/syscall.c +++ b/bsd-user/syscall.c @@ -355,9 +355,8 @@ abi_long do_freebsd_syscall(void *cpu_env, int num, abi= _long arg1, case TARGET_FREEBSD_NR_writev: { int count =3D arg3; - struct iovec *vec; + g_autofree struct iovec *vec =3D g_new(struct iovec, count); =20 - vec =3D alloca(count * sizeof(struct iovec)); if (lock_iovec(VERIFY_READ, vec, arg2, count, 1) < 0) goto efault; ret =3D get_errno(writev(arg1, vec, count)); --=20 2.26.3 From nobody Mon May 6 15:06:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620234073; cv=none; d=zohomail.com; s=zohoarc; b=Tg53SD3sH9B6TJLNukq5GoYKTDohK9y8r369BD7mFT4unwZFibHUEXiECaREsw1PTBhSuoPuqxPkGjcdSsS9pwH15Tg9ZeoB1R/rrgnI3eU1u2+mu2yHZsCgnkaNDNT3Rv3wFwOIdkO9wLcbqSWfAVyPxcH1tyNhW/f2mamPiR0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620234073; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=KVr/YKk8ykCSG/NDL+d/fpooQDX6C5X50bcflqdu8o0=; b=EGaa95kvkDbLrnbKoDlFlFFlG9L4g/HB3ECFP9gzixKjVIK1r2zwq7WMIZpsLDn1gu/T928dhTRsMSXXhDhFMxqLhocX3KBcDCVbub3jmc73Zsnmhb6/tqsjTV39OONwDqM+I/4J/e+PkW4S0yg7lEPSBRp42E1+fSFiUlGYIR0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620234072984230.82158263291774; Wed, 5 May 2021 10:01:12 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-453-LReV1x7AMieXYY3k031M4A-1; Wed, 05 May 2021 13:01:08 -0400 Received: by mail-wr1-f69.google.com with SMTP id 65-20020adf82c70000b0290107593a42c3so953587wrc.5 for ; Wed, 05 May 2021 10:01:08 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id l12sm20040231wrm.76.2021.05.05.10.01.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 10:01:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620234069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KVr/YKk8ykCSG/NDL+d/fpooQDX6C5X50bcflqdu8o0=; b=NkH4sznyjhY6jbd6wYGYt1MY6HWmi/hfbdS5iQAuvbzq4m669gkm79fhIk14xNSdQi6WZy UWJbEe+6V/aZx4RB7GqzOJ1xvEFe4tLtcBpu2yACzSt+AsgYeSY/SqqNJk09XJvWdCJld6 wrz+7NvMsyh3Osu9rU5Ezh/pUGbIvWw= X-MC-Unique: LReV1x7AMieXYY3k031M4A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KVr/YKk8ykCSG/NDL+d/fpooQDX6C5X50bcflqdu8o0=; b=F2oZ635bsJXgwyl59l5qibhkdM2644S/DWHO9w222Hw1dzPP/Rd81pVsYuvvLpAJQP UXsMmUOi9NjyYqtN/WEJSZ0kPPlP3ByBCsrSSRAshuws0XMmENwWAyCyBXOPWFAd+Dqq 16V7F/fih9t/hxf+u6Z9ZrkA3R2heiyi7YIm/PfXP2aWa7lvR31WOtnLIt3f80nN7vgE r/CFRYpVdEl95UGDUQ+MeVAjoNf8B+0Em1bFyLgVfek0mwFIFUkiL5+UHHTsPr7byUYf 3AeJSYoI4Cd3Mrg7K2rhUE6wSzr+3JTZqc8Sh0M9fw3v6lRRqDJMGtf/gpVYMttDCjiV EQfg== X-Gm-Message-State: AOAM530smdN+7BC4/N8cAY5rsxA5rZGUt0s8EBewDfbelDyJMsM/UWQr bq1EmCRIJDBZUtjuPrHFG4A2lbPBfEhAIjamE/atR8pK18Q3Llqe9ls8XcvcU1N6eC3YrRYU+L8 rCDHxfundw72dAg== X-Received: by 2002:a7b:c4c9:: with SMTP id g9mr10881018wmk.90.1620234066985; Wed, 05 May 2021 10:01:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMNW3ne0tCY2PAFqneUiO3IIV1h5h3tf9MgcewGFxLZtCnjm1YBJggkTc+aanCQig7UykaUg== X-Received: by 2002:a7b:c4c9:: with SMTP id g9mr10880998wmk.90.1620234066819; Wed, 05 May 2021 10:01:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson , Paolo Bonzini , Warner Losh , Kyle Evans , Greg Kurz , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 2/5] gdbstub: Constify GdbCmdParseEntry Date: Wed, 5 May 2021 19:00:52 +0200 Message-Id: <20210505170055.1415360-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210505170055.1415360-1-philmd@redhat.com> References: <20210505170055.1415360-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e --- gdbstub.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 054665e93ea..6f663cbd8dd 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1982,7 +1982,7 @@ static void handle_v_kill(GdbCmdContext *gdb_ctx, voi= d *user_ctx) exit(0); } =20 -static GdbCmdParseEntry gdb_v_commands_table[] =3D { +static const GdbCmdParseEntry gdb_v_commands_table[] =3D { /* Order is important if has same prefix */ { .handler =3D handle_v_cont_query, @@ -2325,7 +2325,7 @@ static void handle_set_qemu_phy_mem_mode(GdbCmdContex= t *gdb_ctx, void *user_ctx) } #endif =20 -static GdbCmdParseEntry gdb_gen_query_set_common_table[] =3D { +static const GdbCmdParseEntry gdb_gen_query_set_common_table[] =3D { /* Order is important if has same prefix */ { .handler =3D handle_query_qemu_sstepbits, @@ -2343,7 +2343,7 @@ static GdbCmdParseEntry gdb_gen_query_set_common_tabl= e[] =3D { }, }; =20 -static GdbCmdParseEntry gdb_gen_query_table[] =3D { +static const GdbCmdParseEntry gdb_gen_query_table[] =3D { { .handler =3D handle_query_curr_tid, .cmd =3D "C", @@ -2421,7 +2421,7 @@ static GdbCmdParseEntry gdb_gen_query_table[] =3D { #endif }; =20 -static GdbCmdParseEntry gdb_gen_set_table[] =3D { +static const GdbCmdParseEntry gdb_gen_set_table[] =3D { /* Order is important if has same prefix */ { .handler =3D handle_set_qemu_sstep, --=20 2.26.3 From nobody Mon May 6 15:06:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620234077; cv=none; d=zohomail.com; s=zohoarc; b=bdfgo1DYaZ0no4Fspg657MOB80jxmyH7Cwmmj+i8mGpyU6Stdb1w4fcBHFX+Mf7YOGr1c0mW+/eiNiLD4FOJ8GSEOrf9Pj54+UVz3FWhMBTJlS0hRCZniT8tkJaeVIBXtmagzBtoPuGSFrXSFiJOMl2Pn7nBfw1jKX0xpaMfPO0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620234077; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=v6dDjUUr1jX0kd69bV9ZwwKe4Jn9sJZazvtpBwyg5KA=; b=XdHCRuuedJ0TeXfT8QN2v0Ivd3+W5Zjlrvy95qeThOwe3OAnSz89PC1f28WkXD4FEkWFQRVf96QdLbsUvPGaYymkegSpSdNvWLdkzwTXuui8iUp4E+F0iq779KsVgI/lpgWHkHBmXxbvXTyH7MbN+VKnkm7wh2gdsMO2HY80qlg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620234077362581.6713859656356; Wed, 5 May 2021 10:01:17 -0700 (PDT) Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-RICAxLchNhe99C7Ktuw3PQ-1; Wed, 05 May 2021 13:01:13 -0400 Received: by mail-wm1-f71.google.com with SMTP id v2-20020a7bcb420000b0290146b609814dso541289wmj.0 for ; Wed, 05 May 2021 10:01:12 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id n5sm16047652wrx.31.2021.05.05.10.01.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 10:01:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620234074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v6dDjUUr1jX0kd69bV9ZwwKe4Jn9sJZazvtpBwyg5KA=; b=BQn4g5Y1gTRMSnjY74nDP4/QPWughTAtUjFUNYgKzov/nALJHxjVSr7c9uuZ4/60beNIGt +Tx2lyVCTSRr+xYtCTNx9n2aVRDU4WxDIGZp2ztd5UssmbLux6TGMuQyy2Kqhg6i+105CS h5sugk4p0g1dOX3cS/BBrc3kqgK7fxg= X-MC-Unique: RICAxLchNhe99C7Ktuw3PQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v6dDjUUr1jX0kd69bV9ZwwKe4Jn9sJZazvtpBwyg5KA=; b=kZqFX/BAzO6mjYdigTjhtUNwm8ZuTvWMRDPnU7trsTXAg8PbFvFWNRPXBU1WOSjvbV 7VQvJbPNU3uvJVFye94Ng/PBPokMu0sSp6sFmC7QgxVZLKyPDHQbzHhyNknLrwKy8tax unabQD36/Kg9ypxy/z4cwT+eytLumI8iz4GmgO+0tzu4Si6qzHqE5DqGupXspJQUb5sL /BZ83cyK3S/Pp0FeiB9vICr4t2uSzCUvjhz+2zylr574tdvdbm8GoLSdXk9ms1zkgLgt t26HBxttD2O/QkZNj3DdGc2b/f55HoJhOye087jXdyRW1BQMTH/5JZ2nHSGlMLeiDuQr Jl7Q== X-Gm-Message-State: AOAM531v57nsIokdPEOXHSxm+Ynv2edPfJ3Q8LlZvxLb1caKsQWpOhOR NEsq/avL5i/Tk5VqEuzQKJ3F8Q2+1i6Lb5lB+6CNoTA+/ovP0UNQmxK987DerFoiAZ0jZVG8w4W n7cJuWlBDJvQb7w== X-Received: by 2002:a5d:4cce:: with SMTP id c14mr12191wrt.29.1620234071863; Wed, 05 May 2021 10:01:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwUVOp3pO1Wn/Eg12ZEK46NsmpT3zPU6R7yIqJ0Q6XmSE4diSFvuXPe8REXrt2tEMJBnmTrMA== X-Received: by 2002:a5d:4cce:: with SMTP id c14mr12167wrt.29.1620234071681; Wed, 05 May 2021 10:01:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson , Paolo Bonzini , Warner Losh , Kyle Evans , Greg Kurz , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 3/5] gdbstub: Use fixed-size array in GdbCmdParseEntry instead of pointer Date: Wed, 5 May 2021 19:00:53 +0200 Message-Id: <20210505170055.1415360-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210505170055.1415360-1-philmd@redhat.com> References: <20210505170055.1415360-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) GdbCmdParseEntry should have enough room with 20 chars for the command string, and 8 for the schema. Add the GDB_CMD_PARSE_ENTRY_CMD_SIZE and GDB_CMD_PARSE_ENTRY_SCHEMA_SIZE definitions. Do not use pointer to string of unknown length, but array of fixed size. Having constant size will help use to remove the alloca() call in process_string_cmd() in the next commit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 6f663cbd8dd..0d5569ee539 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1457,11 +1457,13 @@ typedef void (*GdbCmdHandler)(GdbCmdContext *gdb_ct= x, void *user_ctx); * '.' -> Skip 1 char unless reached "\0" * Any other value is treated as the delimiter value itself */ +#define GDB_CMD_PARSE_ENTRY_CMD_SIZE 20 +#define GDB_CMD_PARSE_ENTRY_SCHEMA_SIZE 8 typedef struct GdbCmdParseEntry { GdbCmdHandler handler; - const char *cmd; + const char cmd[GDB_CMD_PARSE_ENTRY_CMD_SIZE]; bool cmd_startswith; - const char *schema; + const char schema[GDB_CMD_PARSE_ENTRY_SCHEMA_SIZE]; } GdbCmdParseEntry; =20 static inline int startswith(const char *string, const char *pattern) @@ -1481,14 +1483,14 @@ static int process_string_cmd(void *user_ctx, const= char *data, =20 for (i =3D 0; i < num_cmds; i++) { const GdbCmdParseEntry *cmd =3D &cmds[i]; - g_assert(cmd->handler && cmd->cmd); + g_assert(cmd->handler && *cmd->cmd); =20 if ((cmd->cmd_startswith && !startswith(data, cmd->cmd)) || (!cmd->cmd_startswith && strcmp(cmd->cmd, data))) { continue; } =20 - if (cmd->schema) { + if (*cmd->schema) { schema_len =3D strlen(cmd->schema); if (schema_len % 2) { return -2; --=20 2.26.3 From nobody Mon May 6 15:06:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620234083; cv=none; d=zohomail.com; s=zohoarc; b=gFI9K9Egvs7wtMsX+3z00OLaMqlIAgkFWblW3AIPHScJmrxuS2RuqkSyeXK51IFy0FL+KaYnyeitXhE44OnRMkJ3RgOFZmWNddl1nAA+VvCAP1f4zSBbkPNa6mVy7eotL13GOR4yPq7wstHearX70mzBiTOiRUt82Tmhm24EwKc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620234083; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=HTcbf9xflzHTyoKg03h2p2pH+wnGCXbbU65n0yQBFMc=; b=XxFxP2HXDCCjZLJf1feWDIHqr0hJQ45CPcWnHL9nCTOuwKCeOvtDwaDCAzWuprTVZz4Dqou2wDpKgwUylBqT8yKutokg1lesCbJq69fCtI0Zlx6ePieAsmKMbstgHip31ptQNbjAKlAVx4XM4KvvfXRnonQMTgkOlLQOyZIQLRU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1620234083767371.7532286569085; Wed, 5 May 2021 10:01:23 -0700 (PDT) Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-333-QpcZCxBgP82tJozEs9Mwsg-1; Wed, 05 May 2021 13:01:17 -0400 Received: by mail-wm1-f70.google.com with SMTP id d9-20020a1cb4090000b02901494f55f719so669374wmf.9 for ; Wed, 05 May 2021 10:01:17 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id v18sm24213571wro.18.2021.05.05.10.01.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 10:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620234081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HTcbf9xflzHTyoKg03h2p2pH+wnGCXbbU65n0yQBFMc=; b=K8gKFmu9yTBrosTAimskoQ/uu6E+3r6SbzMgst8EWal2HU4mKhhJuEGg58kKyGiGTxxSTs g/jNuOj9jv/Mbu+pMwCacXV0QCmLWdO+y8dxs8ktfNSUO4pKVL+X6F9CN++wz+bAen6+GJ fAimuBzMzwVfLrvaCCfNNoes8/iy0Ng= X-MC-Unique: QpcZCxBgP82tJozEs9Mwsg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HTcbf9xflzHTyoKg03h2p2pH+wnGCXbbU65n0yQBFMc=; b=gevyt6ZJbCnY7c12bpHNwpyqVJPIWod5al3q2gjhpcsHca10HOLAwuQ4gdtQnqtOlI 456Zuej+h6uBeHFcsiOtFEV/ZiEDmI3ivTQXm76HKGhl8otXA/IrHS/+IiBm46LnHIqM MKoz4oHH9UsrPncRGyKtPZXNVvKitLU49/Cul//u6/fTHjynAb4UI3Le9MPcvNAMhE8V cdwpBH6PWinpGsRcFTqB59dU3Gu7BtSfkHwZqJY0Bc+EcxEJT2rX21N+MsE4NF4l5KKD U6+6pXtqMTAHu9SvRiLRbasZiSFz75thkXuetu4BTMRRR8TU7omnjWR/rD/E+vB3jZIF URiA== X-Gm-Message-State: AOAM533NEhhmtVV2FOQ6iZxUNSqRGYQ7+lgld2GnepbeuTmMtV6o12PV 9pTFS3BW3mbpGzQKU9K7WcXiR56bI9gh/oFLF/LvH8UGPlvNIeXxQQgh2HFdOPDt2E/EXM0fg69 1H593tWlGfUZuew== X-Received: by 2002:a05:6000:1789:: with SMTP id e9mr46343wrg.110.1620234076803; Wed, 05 May 2021 10:01:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVNOl9XyhslOnr9Z5qwwLZOpH94LvB1BxuuJ5+7dkBrOMXzT4/nk0o52wVuxUxBRv/bIV84Q== X-Received: by 2002:a05:6000:1789:: with SMTP id e9mr46326wrg.110.1620234076675; Wed, 05 May 2021 10:01:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson , Paolo Bonzini , Warner Losh , Kyle Evans , Greg Kurz , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH 4/5] gdbstub: Replace alloca() by g_new() Date: Wed, 5 May 2021 19:00:54 +0200 Message-Id: <20210505170055.1415360-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210505170055.1415360-1-philmd@redhat.com> References: <20210505170055.1415360-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The ALLOCA(3) man-page mentions its "use is discouraged". Replace it by a g_new() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 0d5569ee539..72b4be89c7b 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1475,7 +1475,9 @@ static int process_string_cmd(void *user_ctx, const c= har *data, const GdbCmdParseEntry *cmds, int num_cmds) { int i, schema_len, max_num_params =3D 0; - GdbCmdContext gdb_ctx; + g_autofree GdbCmdVariant *params =3D g_new(GdbCmdVariant, + GDB_CMD_PARSE_ENTRY_SCHEMA_SIZE / = 2); + GdbCmdContext gdb_ctx =3D { .params =3D params }; =20 if (!cmds) { return -1; @@ -1499,8 +1501,6 @@ static int process_string_cmd(void *user_ctx, const c= har *data, max_num_params =3D schema_len / 2; } =20 - gdb_ctx.params =3D - (GdbCmdVariant *)alloca(sizeof(*gdb_ctx.params) * max_num_para= ms); memset(gdb_ctx.params, 0, sizeof(*gdb_ctx.params) * max_num_params= ); =20 if (cmd_parse_params(&data[strlen(cmd->cmd)], cmd->schema, --=20 2.26.3 From nobody Mon May 6 15:06:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620234087; cv=none; d=zohomail.com; s=zohoarc; b=AYzzb64iSs61v56Fyhws42AnOKBMKQfYHubIILcDI5MQHjO0b/yMAPIAKjKhP/kWi2gek/ntrAv1sHUORpYFlw//vBYCyF4NglW2+r7B9lG9CDGZNpzMxG/uttgeRQ61hXgCBKl76owqzyycfJzimtNeWkrpmT5YeTaRcleEH/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620234087; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=7g2k8F+O24ILX6i9wlywTWqxuX2ak4LnZOnLn8IJqNY=; b=CXItrq85+oFn+lVrhgpO5O7aLezz7fq7pR59woCbMvVjzstQ7aWi5kNZDqGirxyq2T+IoOamfEt05ZNypnAvT0Uq7sC/WWI/nU2Y4QqY4FLYrHYYSZyH/4CpsZU5TQG2gKI6vFblgBvXRQbufz64+l5y9mvk7TRnK9DlwU5xji0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620234087208931.7896708131002; Wed, 5 May 2021 10:01:27 -0700 (PDT) Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-liQlKAOqM-OV02B-33Mnow-1; Wed, 05 May 2021 13:01:23 -0400 Received: by mail-wr1-f71.google.com with SMTP id a7-20020adfc4470000b029010d875c66edso932530wrg.23 for ; Wed, 05 May 2021 10:01:22 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id q10sm15824317wre.92.2021.05.05.10.01.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 10:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620234084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7g2k8F+O24ILX6i9wlywTWqxuX2ak4LnZOnLn8IJqNY=; b=I0Acs7JkAFBGnjbE8cg/Ed4v4TpGNX+hKW6gXg9rfrvLDEC5VUREMhdQjZ11yJ1YkugWBi PNs0IC4b/N6wY7U30ZRX7LqayFAnVQQUiNY6rxqw9Dg3UQVnedQp1IXEzV0VwIVEeeTGVY FhdC/d24D/bVmKtiwbVOhFWn6hH8/HU= X-MC-Unique: liQlKAOqM-OV02B-33Mnow-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7g2k8F+O24ILX6i9wlywTWqxuX2ak4LnZOnLn8IJqNY=; b=VmuIpZsg31HgYZIWdlwe7juIXKBshDT4mANBXPu3X1vFqPG2Dc9D1oeyP0hCCtAlf0 XY/HeFiOa8Jxg2edzX1j/9pyHlQIFJEUSM+R3lP5OvqP3zS6KcGhnJRLt6uzmcZ3q6YG BuZMH19KKJnfhdIjcht3ZHjpGZfbe9Wp3UUfLgS6FeYQwPZ3alBc25tne91fD3MucWqy DYrxDX52h9PUc44QCENrFwQRkA/UA8T2Evnhnjo/36vrPJCi+V8UKoLppXVCsK1/SN7Z PQms5WtsxX3/sHQAh3fz5bumO26+jzYtBSmqqXmSye/9p3nzfrB/svU+ppkeqGUQK1Dk P/cA== X-Gm-Message-State: AOAM533jad63t/jMust7oxIHiW7a20ZbCaNWUYuL64IcZbnb0VCOlJ8D YuEPv7VNiZJ81goICwqiNhzNTO5LhAkmysEKF8EUsUhpGxb0/e+LWvCZFQnpu1gj/K7GHyVjNA+ oRQQ4W4IoodpjlA== X-Received: by 2002:a1c:1d50:: with SMTP id d77mr11295076wmd.114.1620234081692; Wed, 05 May 2021 10:01:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmgH4JwP3i9dHZjwwiWSGdQcazy8feE/fCrd6Xa/tz3JD28tBwB4MYsNyH0CmUS+lyRxh2hg== X-Received: by 2002:a1c:1d50:: with SMTP id d77mr11295057wmd.114.1620234081584; Wed, 05 May 2021 10:01:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson , Paolo Bonzini , Warner Losh , Kyle Evans , Greg Kurz , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-ppc@nongnu.org (open list:PowerPC TCG CPUs), kvm@vger.kernel.org (open list:Overall KVM CPUs) Subject: [PATCH 5/5] target/ppc/kvm: Replace alloca() by g_malloc() Date: Wed, 5 May 2021 19:00:55 +0200 Message-Id: <20210505170055.1415360-6-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210505170055.1415360-1-philmd@redhat.com> References: <20210505170055.1415360-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The ALLOCA(3) man-page mentions its "use is discouraged". Replace it by a g_malloc() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson --- target/ppc/kvm.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 104a308abb5..ae62daddf7d 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2698,11 +2698,11 @@ int kvmppc_save_htab(QEMUFile *f, int fd, size_t bu= fsize, int64_t max_ns) int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index, uint16_t n_valid, uint16_t n_invalid, Error **e= rrp) { - struct kvm_get_htab_header *buf; - size_t chunksize =3D sizeof(*buf) + n_valid * HASH_PTE_SIZE_64; + size_t chunksize =3D sizeof(struct kvm_get_htab_header) + + n_valid * HASH_PTE_SIZE_64; ssize_t rc; + g_autofree struct kvm_get_htab_header *buf =3D g_malloc(chunksize); =20 - buf =3D alloca(chunksize); buf->index =3D index; buf->n_valid =3D n_valid; buf->n_invalid =3D n_invalid; @@ -2741,10 +2741,10 @@ void kvmppc_read_hptes(ppc_hash_pte64_t *hptes, hwa= ddr ptex, int n) i =3D 0; while (i < n) { struct kvm_get_htab_header *hdr; + char buf[sizeof(*hdr) + HPTES_PER_GROUP * HASH_PTE_SIZE_64]; int m =3D n < HPTES_PER_GROUP ? n : HPTES_PER_GROUP; - char buf[sizeof(*hdr) + m * HASH_PTE_SIZE_64]; =20 - rc =3D read(fd, buf, sizeof(buf)); + rc =3D read(fd, buf, sizeof(*hdr) + m * HASH_PTE_SIZE_64); if (rc < 0) { hw_error("kvmppc_read_hptes: Unable to read HPTEs"); } --=20 2.26.3