From nobody Sun May 19 00:42:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1620230630; cv=none; d=zohomail.com; s=zohoarc; b=MA8hQwQaaeIUP/3FJZcPZbT+2jfddYiaRYFs3h4UkfgIkQtKG+XoG3U0EKCa9VZ7PwHtQ50hvXhpRFWo/G+RhHrxaG64ySZFofzXSwPe7VPi2P8iiS5cfvoYKNI0i0r5C525XhRGJyMMDFGxPwEZtdmZa8853DFR3x/d6Wurwto= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620230630; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=mhLJd1wAg+mbKgDbWE9h0dMpJv6ERkP2L0spY5MQdj8=; b=bJZypui6v9ABMeRAwZLtNDiwHBYjDg0PlGimqbsUAnf95r4dYAHkY522/VB6KJyzawyQ4tsgS56yPTovB70U7pwdB39vZ+/kVhTLrczxCFh8VAnJel6ea+eaRx2UQ3cqQGkGrOMdT5Ep740qqSVzrR56rpJm9ztwjdlBKuY8w8E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 1620230629984730.0841602617577; Wed, 5 May 2021 09:03:49 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id o127so1744413wmo.4 for ; Wed, 05 May 2021 09:03:48 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id i14sm5174442wmq.1.2021.05.05.09.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 09:03:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mhLJd1wAg+mbKgDbWE9h0dMpJv6ERkP2L0spY5MQdj8=; b=vTqVgFa99EJpcAz42fb4gb9XVJs/79XtzuVMddYTb9H2rUStmovHMKjGAhHBjnbgSe t5Qg78uDhsJZt47Mj0basVbXhkx4Gf5X0TLKOiZgBlwm5cl2DPxRoTNkMgSJ1UiLVeMd bMwrYc581JD7wgrZojLjeWBw8LwLh6fnRX6VOunKChSF2Cs4h4QwqLPL2uVU0Q5MGzN1 xNry0gLIDtTHjyY87luNJnnMptv2stgjE7V2pSb5yKSrHxrCUTWCOCgNAIPoAjlsm0Cs YG7VhKpoE1iVPH3ZmYptsXRsAdXujX4TjQVf8D5pm2Y7n8+4vuVsPxaUbdN5XNhAAqpF f3Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=mhLJd1wAg+mbKgDbWE9h0dMpJv6ERkP2L0spY5MQdj8=; b=Rnz6ggOP06zHoEeC8r5R8mvcquSqrg0OG9NJVLDmoEVWMOB/b5D09Ac1gWo/Mzthzk 52ONxZC/fKA5E7EyAtnsCX4mE7Pw9JbWaQmZOsio0zWwZAqrmJoThsKWNYJ7SEtRUnEZ sOEkOefoOdpGfqurj+yZOCNs3mHtpdPtwqVNKjnGlZHgWPQfyp8BW0pBE3tyDkJWA2tf TIhtfFGXqibDUaM5+FaftwP7D5mf4SaoR5JhXJA4c/1DeZlKqq4yTjFSMx8QS4MEx6UV SPok/koYZHAiWqbtUZgy1qHcCj4UTVeo0FXDNR9ICDbG0s8zmv52Oc5O8svTBi6YXgNb vfcw== X-Gm-Message-State: AOAM5300uSZ3FB5BxAxPJqOq3v3KMioomcSFExgii2cH1cAYjIhQbx48 B1deABznTf2vwqp2DYpIlOc= X-Google-Smtp-Source: ABdhPJzXk/UvANH9PqfpkpT+BEOSEeCYb4kUOjf/9ox+kdu6Tb4Z3htxei6267iOk35HuSHt0G7c3A== X-Received: by 2002:a05:600c:4982:: with SMTP id h2mr33396090wmp.108.1620230627164; Wed, 05 May 2021 09:03:47 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] target/m68k: Remove unused variable in ABCD/SBCD memory opcodes Date: Wed, 5 May 2021 18:03:44 +0200 Message-Id: <20210505160344.1394843-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The ABCD / SBCD memory opcodes (introduced in commit fb5543d8200) don't use their "addr" variable. Remove the unused variable and pass a NULL argument instead to gen_ea_mode(). This fixes warnings generated when building with CFLAGS=3D-O3 (using GCC 10.2.1 20201125): target/m68k/translate.c: In function =E2=80=98disas_sbcd_mem=E2=80=99: target/m68k/translate.c:897:13: warning: =E2=80=98addr=E2=80=99 may be us= ed uninitialized in this function [-Wmaybe-uninitialized] 897 | delay_set_areg(s, reg0, tmp, false); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ target/m68k/translate.c:1866:21: note: =E2=80=98addr=E2=80=99 was declare= d here 1866 | TCGv src, dest, addr; | ^~~~ target/m68k/translate.c: In function =E2=80=98disas_abcd_mem=E2=80=99: target/m68k/translate.c:897:13: warning: =E2=80=98addr=E2=80=99 may be us= ed uninitialized in this function [-Wmaybe-uninitialized] 897 | delay_set_areg(s, reg0, tmp, false); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ target/m68k/translate.c:1829:21: note: =E2=80=98addr=E2=80=99 was declare= d here 1829 | TCGv src, dest, addr; | ^~~~ Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/m68k/translate.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 200018ae6a6..5cdd026a4b2 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -1826,7 +1826,7 @@ DISAS_INSN(abcd_reg) =20 DISAS_INSN(abcd_mem) { - TCGv src, dest, addr; + TCGv src, dest; =20 gen_flush_flags(s); /* !Z is sticky */ =20 @@ -1835,11 +1835,11 @@ DISAS_INSN(abcd_mem) src =3D gen_ea_mode(env, s, 4, REG(insn, 0), OS_BYTE, NULL_QREG, NULL, EA_LOADU, IS_USER(s)); dest =3D gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE, - NULL_QREG, &addr, EA_LOADU, IS_USER(s)); + NULL_QREG, NULL, EA_LOADU, IS_USER(s)); =20 bcd_add(dest, src); =20 - gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE, dest, &addr, + gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE, dest, NULL, EA_STORE, IS_USER(s)); =20 bcd_flags(dest); @@ -1863,7 +1863,7 @@ DISAS_INSN(sbcd_reg) =20 DISAS_INSN(sbcd_mem) { - TCGv src, dest, addr; + TCGv src, dest; =20 gen_flush_flags(s); /* !Z is sticky */ =20 @@ -1872,11 +1872,11 @@ DISAS_INSN(sbcd_mem) src =3D gen_ea_mode(env, s, 4, REG(insn, 0), OS_BYTE, NULL_QREG, NULL, EA_LOADU, IS_USER(s)); dest =3D gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE, - NULL_QREG, &addr, EA_LOADU, IS_USER(s)); + NULL_QREG, NULL, EA_LOADU, IS_USER(s)); =20 bcd_sub(dest, src); =20 - gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE, dest, &addr, + gen_ea_mode(env, s, 4, REG(insn, 9), OS_BYTE, dest, NULL, EA_STORE, IS_USER(s)); =20 bcd_flags(dest); --=20 2.26.3