From nobody Mon Feb 9 14:02:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620219531; cv=none; d=zohomail.com; s=zohoarc; b=kqUi3D8UAJAL5iROXCrX0egTVwtVF8qphuSLeZkOWG710PiGRBQjPJyKd/GSr0PqhlP5tYIhht/uFrRXdBX7RNkddoLDRDKoukYZK68YDhhui9jt0OwRXRTyLMESjsLkEHC866znY79rmCEU+p/b88YRP/+2UMh+UldVq3NTG9g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620219531; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=NSr0ATvoVPT94Kw0PlP2HcPHUZbWsmv1leCf95/HD08=; b=nvyO2FsoGXeoPQjjqud2KYU1/9WwDYdcR0NJe9M20m/oiBA4IHHuaOdLIjQ8lNCmTUPlIbzTXIpp/q3iQkOTNUXTVWsQdCkJHJ1cj2NfzyPkAsKVoFb3tOJo9i/sX52RzsBst+wEQuZv1FKmrlFXhv7XRlr/ffmxkC0twVfvJsM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620219531365843.4210067088719; Wed, 5 May 2021 05:58:51 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-hkfn3AL0NqW62v0aCZT0AA-1; Wed, 05 May 2021 08:58:48 -0400 Received: by mail-wr1-f69.google.com with SMTP id l2-20020adf9f020000b029010d6bb7f1cbso670621wrf.7 for ; Wed, 05 May 2021 05:58:47 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (astrasbourg-653-1-188-220.w90-13.abo.wanadoo.fr. [90.13.127.220]) by smtp.gmail.com with ESMTPSA id q10sm5767584wmc.31.2021.05.05.05.58.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 May 2021 05:58:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620219530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NSr0ATvoVPT94Kw0PlP2HcPHUZbWsmv1leCf95/HD08=; b=QnDJYMqQhJ+181dge2o6o/cbq/cJ9QWFoPa7mGw/yhlUGnv3zfigp4J9hedBqiSSNST2jc gn1Mne67kYEthmoz24Zgl0RW7nM4c2I9geyIh7ZzQ9keXlreBqWtguw1LDn+xMrz/TO6ZB qyAxpMb2t/36tE+7/M43auwAn7ocayA= X-MC-Unique: hkfn3AL0NqW62v0aCZT0AA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NSr0ATvoVPT94Kw0PlP2HcPHUZbWsmv1leCf95/HD08=; b=LvaBF5s8dC3+/XxF6T8qmtxc5+jbK9moqvsn8GP1bBapk6Iw5H/TNyE4g4QigkGDYP C0rOSi+THYdHq9rf2NgMrpPAQYTJvQ7hd6tp9jVbsAffZEt7vePB5/zHYm1IyckPjzHQ lLpiS9gwAqeyFcWk730AG2Mv3lq1IDI25R9Ebcmvk7LFWOWpzyIW9uCrbQA4G9qHuEfR 5N8RKtzNznW1TuDcxv38QH08T35Y7PEm4OsGDcX9bFONcf7jLGCQ5ztQE+HCYcg0RBoQ OF+ssU28UmbFTCN7nJBRQI8mDTIOph4i8ieF33vJivq0AS8+LS+PCABShs1UEDj6xQ1T BpPA== X-Gm-Message-State: AOAM531PfoItdWRu0JcTluDTKjJhyD3h3kmEGrvaeCKlZSiapeKMdXtr JmjFzdPGw2mb+UJ/tNqV1GC5SyB1cX7ZocdGYLg++3UjZ+8J1sJUv6ZN86OhoqfFutubO1Bn1Nk BsiUMsXcGDxK79w== X-Received: by 2002:a05:6000:1541:: with SMTP id 1mr28655004wry.364.1620219526920; Wed, 05 May 2021 05:58:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwHXii+RrJP9dv/V7ffUnivzxS+CN4t4Ydboamkb417/bhUtJSFJXBPF0ltegkqxUBv5lu4bg== X-Received: by 2002:a05:6000:1541:: with SMTP id 1mr28654987wry.364.1620219526801; Wed, 05 May 2021 05:58:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson , Greg Kurz , Cornelia Huck , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Juan Quintela , "Dr. David Alan Gilbert" , Thomas Huth , Laurent Vivier Subject: [PATCH v7 08/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64 Date: Wed, 5 May 2021 14:58:02 +0200 Message-Id: <20210505125806.1263441-9-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210505125806.1263441-1-philmd@redhat.com> References: <20210505125806.1263441-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We might have a s390x/ppc64 QEMU binary built without the KVM accelerator (configured with --disable-kvm). Checking for /dev/kvm accessibility isn't enough, also check for the accelerator in the binary. Reviewed-by: David Gibson Reviewed-by: Greg Kurz Reviewed-by: Cornelia Huck Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 3a711bb4929..c32a2aa30a2 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -1408,7 +1408,7 @@ int main(int argc, char **argv) */ if (g_str_equal(qtest_get_arch(), "ppc64") && (access("/sys/module/kvm_hv", F_OK) || - access("/dev/kvm", R_OK | W_OK))) { + access("/dev/kvm", R_OK | W_OK) || !qtest_has_accel("kvm"))) { g_test_message("Skipping test: kvm_hv not available"); return g_test_run(); } @@ -1419,7 +1419,7 @@ int main(int argc, char **argv) */ if (g_str_equal(qtest_get_arch(), "s390x")) { #if defined(HOST_S390X) - if (access("/dev/kvm", R_OK | W_OK)) { + if (access("/dev/kvm", R_OK | W_OK) || !qtest_has_accel("kvm")) { g_test_message("Skipping test: kvm not available"); return g_test_run(); } --=20 2.26.3