From nobody Mon Feb 9 23:01:24 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1620191902; cv=none; d=zohomail.com; s=zohoarc; b=axnqZ2g4hAgMYfmPUx1JqN9eLibaxoY2Rw7pATDRpLRLmjGa3XGIV/rEsBrnRALTr36aOSwjhSsE6EO1mgs4C4A/CjU2VIi69Jc85pPwL/cv0vDWIL6iP20lxQ1jE36JfycD4DQt4peo1aWw4BJZddtybI4Gj5sWFajEjB/SzJY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620191902; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qhxdp2+XuUwqK1mWfkicveCMIiNuA0bJoCb2FPc385Y=; b=GzhMkYXgP6HG4Q+MP4N7b4Abxoa8CfUpnoMHknfvWx+McvlEnbHe6pFOs1UYkzikOs038KnBD8uteLLECl9GqU98bhobdd9LTN9maivUtC7JSyBFOu0xFGc6XmDIrYQilFoDV1/+IuSMRZW4tTBMjh3JB8iMUt6UWd/qyrQdJE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620191902749247.61493736628665; Tue, 4 May 2021 22:18:22 -0700 (PDT) Received: from localhost ([::1]:42210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1le9vR-0002Am-L3 for importer@patchew.org; Wed, 05 May 2021 01:18:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le9rb-000678-Cw for qemu-devel@nongnu.org; Wed, 05 May 2021 01:14:23 -0400 Received: from m12-16.163.com ([220.181.12.16]:58179) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1le9rX-00017P-2Q for qemu-devel@nongnu.org; Wed, 05 May 2021 01:14:21 -0400 Received: from ubuntu.localdomain (unknown [36.22.237.185]) by smtp12 (Coremail) with SMTP id EMCowACXET7zJZJg8VpupQ--.18216S7; Wed, 05 May 2021 12:58:32 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=qhxdp 2+XuUwqK1mWfkicveCMIiNuA0bJoCb2FPc385Y=; b=ODwI643R+Ft663ETr1TMm OEQvmEWZgpDpb4KeDxWb3Q/OryA5/7gKiutyDuBV/oZdWJDrKJuLJ2NfAuizDkue o9iYiOH+PAfzwJYRRB/vwqFcNuuByl814uWxCRguC+KnOnCUV1Ycdh8pBblox6vK uYkjRnQryKdqgDrFn/WLYA= From: Li Qiang To: marcandre.lureau@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org Subject: [PATCH 3/7] vhost-user-gpu: fix memory leak in vg_resource_attach_backing Date: Tue, 4 May 2021 21:58:20 -0700 Message-Id: <20210505045824.33880-4-liq3ea@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210505045824.33880-1-liq3ea@163.com> References: <20210505045824.33880-1-liq3ea@163.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: EMCowACXET7zJZJg8VpupQ--.18216S7 X-Coremail-Antispam: 1Uf129KBjvdXoWruFWrKF17Xw4kuFyfXry7Wrg_yoW3Gwc_Za 1rAFs7CwsxWFyv9F4jqw15ZryayFW3Jr1xJF92kry3WFyFqwnIqw1Fyryktr48Zw4DCF1D ArWUJr48Gr12vjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8E38UUUUUU== X-Originating-IP: [36.22.237.185] X-CM-SenderInfo: 5oltjvrd6rljoofrz/xtbB8QiJbV2MZ6UWcQAAsp Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=220.181.12.16; envelope-from=liq3ea@163.com; helo=m12-16.163.com X-Spam_score_int: -1 X-Spam_score: -0.2 X-Spam_bar: / X-Spam_report: (-0.2 / 5.0 requ) BAYES_40=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , liq3ea@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @163.com) Content-Type: text/plain; charset="utf-8" Check whether the 'res' has already been attach_backing to avoid memory leak. Signed-off-by: Li Qiang --- contrib/vhost-user-gpu/vhost-user-gpu.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/contrib/vhost-user-gpu/vhost-user-gpu.c b/contrib/vhost-user-g= pu/vhost-user-gpu.c index b5e153d0d6..0437e52b64 100644 --- a/contrib/vhost-user-gpu/vhost-user-gpu.c +++ b/contrib/vhost-user-gpu/vhost-user-gpu.c @@ -489,6 +489,11 @@ vg_resource_attach_backing(VuGpu *g, return; } =20 + if (res->iov) { + cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; + return; + } + ret =3D vg_create_mapping_iov(g, &ab, cmd, &res->iov); if (ret !=3D 0) { cmd->error =3D VIRTIO_GPU_RESP_ERR_UNSPEC; --=20 2.25.1