From nobody Mon Feb 9 08:11:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620076269; cv=none; d=zohomail.com; s=zohoarc; b=cmmaIEN9BVG5YsUkp39V+ugWvIzp+votfzp+L+IzDkaR2CaomBqHHqDXcPntAJhAf7qViSEcpXXIUfvaNDUlyJALiyefhvAVlAmVdjzL7AHHLqku1WA3nFqUKJ5Opj+7jqCdmR/W5qZgLpJC8SJ/zsYb/zOyzxTDUcR7BiYO/fg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620076269; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=NSr0ATvoVPT94Kw0PlP2HcPHUZbWsmv1leCf95/HD08=; b=mmIbgDyqwblG2v/DZ3ysuNfDxI26dREQMw4YlSpTAo9u2Z2oU9S2GXhR1P9xCAO7231XObr7KTH84MCQi+i8R4wYoaDfJXRvuITtKAHdwmFQEqIsAEwLOqJf2ChwCG04aW5HZr15hI7/tslGVu17S6cQJGx8vMLlBD2OCFCNKcE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1620076269563709.4219112530075; Mon, 3 May 2021 14:11:09 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-16-LCMR4ub7PYCrbjfB1VJtmw-1; Mon, 03 May 2021 17:11:05 -0400 Received: by mail-wr1-f69.google.com with SMTP id 65-20020adf82c70000b0290107593a42c3so4667456wrc.5 for ; Mon, 03 May 2021 14:11:04 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (anancy-651-1-208-144.w109-217.abo.wanadoo.fr. [109.217.237.144]) by smtp.gmail.com with ESMTPSA id f18sm549071wmg.26.2021.05.03.14.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 14:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620076268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NSr0ATvoVPT94Kw0PlP2HcPHUZbWsmv1leCf95/HD08=; b=LVDWjrr6M4pA70l3kcvK3B7VbJ5ynwrgYg32551vVSlI4z7TOy/Z0YgcWoxpq9AAOuR4Ck XWRpTWKJXVqsIRx9kHJjFRdNU0aML+CWv5jmSPFfKmdQ3Ff0zDBAaaSv5hl6RwnBpS/YD7 oGNaU5JSoEEp5BQmfqhRcjCCGruqI0U= X-MC-Unique: LCMR4ub7PYCrbjfB1VJtmw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NSr0ATvoVPT94Kw0PlP2HcPHUZbWsmv1leCf95/HD08=; b=I4AKGABDIxLOMhn0JltLchi940/mTjLebtxsbBnY6l8pwtY+xXY/7SLvdOW7f0hT05 ooRGnYOMeXmsXuDTZCehqS7NZ0JK+K1wS8B12j6l+tMxzlGIdRi4c1SIiS2mk6TYoo+r BrNha7+//uN1Qw8M5IQpEcNLHrtf761QGP24TYiMn6MvArZva2kOxkW6Xb9ihhWAj8fk iO38NgfRE2fxUAeYoqSdRn/663ZkRciplfbkiQDmrpxD3hwbCXtmOrpaX/d8CZsqE6mK q+KPMCZDDmJBDRPz01zPDE6aL0SlhePtn49o3c3K9W50HBTdZVO28rdCbuWdxGaneeow 5sGw== X-Gm-Message-State: AOAM530Bdue6fA7SGOPvH7qVBa2ss/hFLQ1XXR/HUwqGDqSa3dSeZ5l5 86S6oxWONz9DMJ9dioln34QHcE9ZGwTF2DXgyMtIMgLNU/KHtW4WF1iaDRfBvmQ8gz3C2uwxKjx 5JwVj1ahbXpO/Ng== X-Received: by 2002:a5d:694c:: with SMTP id r12mr19922314wrw.224.1620076263875; Mon, 03 May 2021 14:11:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXk4Rp8nF47WJi79SR59M5qxQEDP2BRMqT6EjyDdtaDzjU4XNikQMnT5N9foAzrLq4441Ueg== X-Received: by 2002:a5d:694c:: with SMTP id r12mr19922293wrw.224.1620076263712; Mon, 03 May 2021 14:11:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , Thomas Huth , Markus Armbruster , Eric Blake , Paolo Bonzini , qemu-arm@nongnu.org, Igor Mammedov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson , Greg Kurz , Cornelia Huck , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Juan Quintela , "Dr. David Alan Gilbert" , Laurent Vivier Subject: [PATCH v6 08/12] qtest/migration-test: Skip tests if KVM not builtin on s390x/ppc64 Date: Mon, 3 May 2021 23:10:16 +0200 Message-Id: <20210503211020.894589-9-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210503211020.894589-1-philmd@redhat.com> References: <20210503211020.894589-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) We might have a s390x/ppc64 QEMU binary built without the KVM accelerator (configured with --disable-kvm). Checking for /dev/kvm accessibility isn't enough, also check for the accelerator in the binary. Reviewed-by: David Gibson Reviewed-by: Greg Kurz Reviewed-by: Cornelia Huck Reviewed-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/migration-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 3a711bb4929..c32a2aa30a2 100644 --- a/tests/qtest/migration-test.c +++ b/tests/qtest/migration-test.c @@ -1408,7 +1408,7 @@ int main(int argc, char **argv) */ if (g_str_equal(qtest_get_arch(), "ppc64") && (access("/sys/module/kvm_hv", F_OK) || - access("/dev/kvm", R_OK | W_OK))) { + access("/dev/kvm", R_OK | W_OK) || !qtest_has_accel("kvm"))) { g_test_message("Skipping test: kvm_hv not available"); return g_test_run(); } @@ -1419,7 +1419,7 @@ int main(int argc, char **argv) */ if (g_str_equal(qtest_get_arch(), "s390x")) { #if defined(HOST_S390X) - if (access("/dev/kvm", R_OK | W_OK)) { + if (access("/dev/kvm", R_OK | W_OK) || !qtest_has_accel("kvm")) { g_test_message("Skipping test: kvm not available"); return g_test_run(); } --=20 2.26.3