From nobody Mon Feb 9 16:45:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620048711; cv=none; d=zohomail.com; s=zohoarc; b=HRtAZ9mvG+qYsRKdb11m63usjia+b1dXEm/TP03SMASeyPaxatEbgJ4iiE+bP8C7+FIst45/0taLEzrCq3JvpDlB1SF3K/a5KmXLTHJcjePJN5A6FqvDuMtHdHxP/kZqinEXfwuByc5gKwT78z0Xeija7CTRaFmwpa6tH4HroBM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620048711; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mrdxAKjUzr/byGv5e5o5W5r22e+2bwN+g67LOvTBIYs=; b=GKn+4QWMpOwQ5VB8WEXVm87ryN6xXorf3cuto0ZxKjiFeLx3oBGjTdFw6m/uMifkweeXLaxIQJmbexhGY2BNdAp4zA63PoU7q/tVPnGjwn9tG71BW0L5DJq+2za2Iw2W1Z6EuiTva534+tvSeNX9dMhlPXsVKJmrEMYlmmRHo7g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620048711173515.0793333748001; Mon, 3 May 2021 06:31:51 -0700 (PDT) Received: from localhost ([::1]:45666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldYfs-0006mK-3m for importer@patchew.org; Mon, 03 May 2021 09:31:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldYdg-0005La-Of for qemu-devel@nongnu.org; Mon, 03 May 2021 09:29:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:45279) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldYdf-0000dr-44 for qemu-devel@nongnu.org; Mon, 03 May 2021 09:29:32 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-pI0xxGGfP4a7pPipsLP-hA-1; Mon, 03 May 2021 09:29:29 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8147F19253C0; Mon, 3 May 2021 13:29:28 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-203.ams2.redhat.com [10.36.112.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D8BDC503F0; Mon, 3 May 2021 13:29:23 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id B39F51CEC737; Mon, 3 May 2021 15:29:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620048570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mrdxAKjUzr/byGv5e5o5W5r22e+2bwN+g67LOvTBIYs=; b=dUlw7kpF4J+W/q6tLLMPFHhfZNxUVkRszJK7NoNJu6t0cik/RFM4weY+T8Jutnbvb+PEAr ND3aDiwbCdeeP4Eemm1gG1N07BIbu9v2h7B3earOc57LSoWsA6TiJbJ1M2lKEF9IZckmDB 1yJaulJRob4DDXru/O9ZTVOrq2ajoXo= X-MC-Unique: pI0xxGGfP4a7pPipsLP-hA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH v2 3/5] usb/mtp: avoid dynamic stack allocation Date: Mon, 3 May 2021 15:29:13 +0200 Message-Id: <20210503132915.2335822-4-kraxel@redhat.com> In-Reply-To: <20210503132915.2335822-1-kraxel@redhat.com> References: <20210503132915.2335822-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mcascell@redhat.com, remy.noel@blade-group.com, philmd@redhat.com, Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Use autofree heap allocation instead. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 --- hw/usb/dev-mtp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index bbb827434482..2a895a73b083 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -907,7 +907,8 @@ static MTPData *usb_mtp_get_object_handles(MTPState *s,= MTPControl *c, MTPObject *o) { MTPData *d =3D usb_mtp_data_alloc(c); - uint32_t i =3D 0, handles[o->nchildren]; + uint32_t i =3D 0; + g_autofree uint32_t *handles =3D g_new(uint32_t, o->nchildren); MTPObject *iter; =20 trace_usb_mtp_op_get_object_handles(s->dev.addr, o->handle, o->path); --=20 2.30.2