From nobody Mon Feb 9 17:36:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1620033657; cv=none; d=zohomail.com; s=zohoarc; b=cSX8D2x8LA9Z9XxrR88dTqXymk/rMUpc/B7OBqjF8YWuNkgAu+KTlvGeTW6kOCf50c1E21jPMZFqIT+AbtGTnUZXFv1s4IkjsVJPExj7FHlOS0l5GxfZnSS8uOMrNDQ78WOAVJUm6oszRiQVi2T/FfuLKBBA4V+GZ9YCbWXB6oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620033657; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=n4IuX5mGBxhSoUNBaK2iWkP/sAnynBLyfTGs307GZHs=; b=C8Z2QRFeQBxdHY7csO6lXC/tqE95HyR90Zji/ZV8vwGrD1UQgNirZCDrVhf8Rq8YelYcEHJL1JOnO/kD9JsoijieWRHqZmxhHffJH1c5CcdBit+VJV+i9f096zcHefOrzy4RESN11icbReM98uRItU0EZl2jlMmT+5FlHYzb5fQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1620033657321642.4950316821522; Mon, 3 May 2021 02:20:57 -0700 (PDT) Received: from localhost ([::1]:57304 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ldUl6-0004Qb-8l for importer@patchew.org; Mon, 03 May 2021 05:20:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60744) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldUfW-0007CO-Tf for qemu-devel@nongnu.org; Mon, 03 May 2021 05:15:12 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:58953) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ldUfU-0005yj-I2 for qemu-devel@nongnu.org; Mon, 03 May 2021 05:15:10 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-265-zlIv7IgOMSOsTGktxEsqaA-1; Mon, 03 May 2021 05:15:05 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E8484801817; Mon, 3 May 2021 09:15:04 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-112-203.ams2.redhat.com [10.36.112.203]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20B3E19C59; Mon, 3 May 2021 09:14:59 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id A57BC1800799; Mon, 3 May 2021 11:14:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620033308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n4IuX5mGBxhSoUNBaK2iWkP/sAnynBLyfTGs307GZHs=; b=TDWV+YPLtqk1OwqJ1QMG9qY6Z2Cy+JRJ8jRQb64j+gjfAQyOlqfSy1eeQZK4/szOMX/PnV B4Stx+agClKrUmlXwKU4pd1ko7Rwfr12J7PW5gDfGKUkVPtWva4G9r8rwnYokfg1gMbVHL vsofQb1GXNUZvS6yZ4DsG4v7CDL7CJQ= X-MC-Unique: zlIv7IgOMSOsTGktxEsqaA-1 From: Gerd Hoffmann To: qemu-devel@nongnu.org Subject: [PATCH 4/5] usb/xhci: sanity check packet size Date: Mon, 3 May 2021 11:14:45 +0200 Message-Id: <20210503091446.2137206-5-kraxel@redhat.com> In-Reply-To: <20210503091446.2137206-1-kraxel@redhat.com> References: <20210503091446.2137206-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.697, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mcascell@redhat.com, remy.noel@blade-group.com, Gerd Hoffmann Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Make sure the usb packet size is within the bounds of the endpoint configuration. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 46212b1e695a..7acfb8137bc9 100644 --- a/hw/usb/hcd-xhci.c +++ b/hw/usb/hcd-xhci.c @@ -1568,6 +1568,11 @@ static int xhci_setup_packet(XHCITransfer *xfer) qemu_sglist_destroy(&xfer->sgl); return -1; } + if (xfer->packet.iov.size > ep->max_packet_size) { + usb_packet_unmap(&xfer->packet, &xfer->sgl); + qemu_sglist_destroy(&xfer->sgl); + return -1; + } DPRINTF("xhci: setup packet pid 0x%x addr %d ep %d\n", xfer->packet.pid, ep->dev->addr, ep->nr); return 0; --=20 2.30.2