From nobody Sat Feb 7 06:55:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) client-ip=209.85.128.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1619987490; cv=none; d=zohomail.com; s=zohoarc; b=iTp/Jbp2clBouXqkfp671n1Uo9ll/bN/tiHcatP5iaDPCTo+jZmAwoUtFbgMzE1FuM20xxhrnnSv/pARHR7jKyEIQndNlPFdhMVPTOFZL7YcQp3wFZ4IlEy0Lvba/euxe4NaG/ECzNO1kVOslGP8PA/Nr+GyaLuO5HCSTKOD02w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619987490; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CsWZi4ds50E4Jo0anUjFufYBOCfHF4O32gPt5S3V5lE=; b=cWV4pjcr8vFosboMjIVBh1hHEJAPRHPsB79U4upaGZO2//rEvKAyGaHiHUIKQupurTzksgUWhTime2faZCIvHY3nddV4df3XeH5w96wMjH4JWlySU+JTo8m1fFudiqFyPR2UKfnFD3dtWPY/Rj8xk/4QfQSaIL9dyM3pAxmxv2w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.zohomail.com with SMTPS id 1619987490615727.2110260689932; Sun, 2 May 2021 13:31:30 -0700 (PDT) Received: by mail-wm1-f42.google.com with SMTP id 4-20020a05600c26c4b0290146e1feccd8so2351191wmv.1 for ; Sun, 02 May 2021 13:31:30 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (anancy-651-1-208-144.w109-217.abo.wanadoo.fr. [109.217.237.144]) by smtp.gmail.com with ESMTPSA id d5sm10359858wrv.43.2021.05.02.13.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 13:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CsWZi4ds50E4Jo0anUjFufYBOCfHF4O32gPt5S3V5lE=; b=S2a+xmaJzy34mwsn6r7cIGug3mlA6tjsje6sjwhkbMFNsvfZjTT1jKx+tdLiGKgAZW 9xyUAKx4/C07T+E0e7G0QVkwu0qq5pyC0bEmrTS4BwD4cfnksy+5f1WmL/Im+ZjVCYw5 TVg06qJ+iM8G1iU7hWjcYtamwIe+jWLBG/5Avg4wjiTSWrYB015SX23XYDDUUcH7aPW3 ys6Zi03ZwGyF0k+GIAl/wl0A9V3OXZafn5XrxhfIb01m6sOj7m9j/uUsGjVuJp8DcG6C hcz3R5GLilRuVbkPdHXbu5mCD+R/0bZ8y9406yfchkMoQ+eaWztR8IG6MIg7VKQmNKvg symg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=CsWZi4ds50E4Jo0anUjFufYBOCfHF4O32gPt5S3V5lE=; b=dvzGk+AnOGsAoq2gZZt9s5/++GEpowHiQnQsYwZj+w1eb25TJFDmplbIUXvnK4N0lW U8iIsm6BmyKxbOwuI9OCvDLZY72T3KQ5W+o++ZwH2M8ww5op2KboX4MXSGMXU5Y1cyFN ineV7ktXTuIQK6vBNlxXj7MouFbcejFLeOqOqds/JIqgk4g5RsAAL2E2B6n42UH02Wwa YWbVgLJoSG6VZtcYnznGAogOhTL3juekw5rgnAwPQPXUE6uwig0ZN7c6m3wZr4seGxw+ Zt0WF6kMDPsYJcuKNRNvlVZ7SBlI3681XpvYxDBWsEFE7k0hwsle8kGZLythzZZUUrRN EPlQ== X-Gm-Message-State: AOAM532eXwH+vb3Zfw7jret0SlUg4j/0ixC38rKINtFCsThERrgaZe8u runAp8caREKIB0ylg6ykUYbqCsOO6jWDhgAL X-Google-Smtp-Source: ABdhPJwqV5quI4JHldwGxJIb8B+bep04X/jcrD9m0HCJPtdhjeXHj8VtbJw0bNVfJ6AKU+EgfZLhJw== X-Received: by 2002:a1c:790f:: with SMTP id l15mr18362163wme.30.1619987488935; Sun, 02 May 2021 13:31:28 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Max Reitz , qemu-block@nongnu.org, Peter Maydell , Kevin Wolf , Mark Cave-Ayland , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/3] hw/block/nand: Register machine reset handler Date: Sun, 2 May 2021 22:31:19 +0200 Message-Id: <20210502203121.630944-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210502203121.630944-1-f4bug@amsat.org> References: <20210502203121.630944-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The TYPE_NAND device is bus-less, thus isn't reset automatically. Register a reset handler to get reset with the machine. Fixed: 7426aa72c36 ("nand: Don't inherit from Sysbus") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/nand.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/block/nand.c b/hw/block/nand.c index 8bc80e35144..8ec656659f5 100644 --- a/hw/block/nand.c +++ b/hw/block/nand.c @@ -24,6 +24,7 @@ #include "hw/qdev-properties-system.h" #include "hw/block/flash.h" #include "sysemu/block-backend.h" +#include "sysemu/reset.h" #include "migration/vmstate.h" #include "qapi/error.h" #include "qemu/error-report.h" @@ -364,6 +365,11 @@ static const VMStateDescription vmstate_nand =3D { } }; =20 +static void nand_reset_handler(void *dev) +{ + device_cold_reset(DEVICE(dev)); +} + static void nand_realize(DeviceState *dev, Error **errp) { int pagesize; @@ -423,6 +429,13 @@ static void nand_realize(DeviceState *dev, Error **err= p) } /* Give s->ioaddr a sane value in case we save state before it is used= . */ s->ioaddr =3D s->io; + + qemu_register_reset(nand_reset_handler, dev); +} + +static void nand_unrealize(DeviceState *dev) +{ + qemu_unregister_reset(nand_reset_handler, dev); } =20 static Property nand_properties[] =3D { @@ -437,6 +450,7 @@ static void nand_class_init(ObjectClass *klass, void *d= ata) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D nand_realize; + dc->unrealize =3D nand_unrealize; dc->reset =3D nand_reset; dc->vmsd =3D &vmstate_nand; device_class_set_props(dc, nand_properties); --=20 2.26.3