From nobody Fri May 17 11:05:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) client-ip=209.85.128.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1619987490; cv=none; d=zohomail.com; s=zohoarc; b=iTp/Jbp2clBouXqkfp671n1Uo9ll/bN/tiHcatP5iaDPCTo+jZmAwoUtFbgMzE1FuM20xxhrnnSv/pARHR7jKyEIQndNlPFdhMVPTOFZL7YcQp3wFZ4IlEy0Lvba/euxe4NaG/ECzNO1kVOslGP8PA/Nr+GyaLuO5HCSTKOD02w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619987490; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CsWZi4ds50E4Jo0anUjFufYBOCfHF4O32gPt5S3V5lE=; b=cWV4pjcr8vFosboMjIVBh1hHEJAPRHPsB79U4upaGZO2//rEvKAyGaHiHUIKQupurTzksgUWhTime2faZCIvHY3nddV4df3XeH5w96wMjH4JWlySU+JTo8m1fFudiqFyPR2UKfnFD3dtWPY/Rj8xk/4QfQSaIL9dyM3pAxmxv2w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mx.zohomail.com with SMTPS id 1619987490615727.2110260689932; Sun, 2 May 2021 13:31:30 -0700 (PDT) Received: by mail-wm1-f42.google.com with SMTP id 4-20020a05600c26c4b0290146e1feccd8so2351191wmv.1 for ; Sun, 02 May 2021 13:31:30 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (anancy-651-1-208-144.w109-217.abo.wanadoo.fr. [109.217.237.144]) by smtp.gmail.com with ESMTPSA id d5sm10359858wrv.43.2021.05.02.13.31.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 13:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CsWZi4ds50E4Jo0anUjFufYBOCfHF4O32gPt5S3V5lE=; b=S2a+xmaJzy34mwsn6r7cIGug3mlA6tjsje6sjwhkbMFNsvfZjTT1jKx+tdLiGKgAZW 9xyUAKx4/C07T+E0e7G0QVkwu0qq5pyC0bEmrTS4BwD4cfnksy+5f1WmL/Im+ZjVCYw5 TVg06qJ+iM8G1iU7hWjcYtamwIe+jWLBG/5Avg4wjiTSWrYB015SX23XYDDUUcH7aPW3 ys6Zi03ZwGyF0k+GIAl/wl0A9V3OXZafn5XrxhfIb01m6sOj7m9j/uUsGjVuJp8DcG6C hcz3R5GLilRuVbkPdHXbu5mCD+R/0bZ8y9406yfchkMoQ+eaWztR8IG6MIg7VKQmNKvg symg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=CsWZi4ds50E4Jo0anUjFufYBOCfHF4O32gPt5S3V5lE=; b=dvzGk+AnOGsAoq2gZZt9s5/++GEpowHiQnQsYwZj+w1eb25TJFDmplbIUXvnK4N0lW U8iIsm6BmyKxbOwuI9OCvDLZY72T3KQ5W+o++ZwH2M8ww5op2KboX4MXSGMXU5Y1cyFN ineV7ktXTuIQK6vBNlxXj7MouFbcejFLeOqOqds/JIqgk4g5RsAAL2E2B6n42UH02Wwa YWbVgLJoSG6VZtcYnznGAogOhTL3juekw5rgnAwPQPXUE6uwig0ZN7c6m3wZr4seGxw+ Zt0WF6kMDPsYJcuKNRNvlVZ7SBlI3681XpvYxDBWsEFE7k0hwsle8kGZLythzZZUUrRN EPlQ== X-Gm-Message-State: AOAM532eXwH+vb3Zfw7jret0SlUg4j/0ixC38rKINtFCsThERrgaZe8u runAp8caREKIB0ylg6ykUYbqCsOO6jWDhgAL X-Google-Smtp-Source: ABdhPJwqV5quI4JHldwGxJIb8B+bep04X/jcrD9m0HCJPtdhjeXHj8VtbJw0bNVfJ6AKU+EgfZLhJw== X-Received: by 2002:a1c:790f:: with SMTP id l15mr18362163wme.30.1619987488935; Sun, 02 May 2021 13:31:28 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Max Reitz , qemu-block@nongnu.org, Peter Maydell , Kevin Wolf , Mark Cave-Ayland , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/3] hw/block/nand: Register machine reset handler Date: Sun, 2 May 2021 22:31:19 +0200 Message-Id: <20210502203121.630944-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210502203121.630944-1-f4bug@amsat.org> References: <20210502203121.630944-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The TYPE_NAND device is bus-less, thus isn't reset automatically. Register a reset handler to get reset with the machine. Fixed: 7426aa72c36 ("nand: Don't inherit from Sysbus") Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/nand.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/hw/block/nand.c b/hw/block/nand.c index 8bc80e35144..8ec656659f5 100644 --- a/hw/block/nand.c +++ b/hw/block/nand.c @@ -24,6 +24,7 @@ #include "hw/qdev-properties-system.h" #include "hw/block/flash.h" #include "sysemu/block-backend.h" +#include "sysemu/reset.h" #include "migration/vmstate.h" #include "qapi/error.h" #include "qemu/error-report.h" @@ -364,6 +365,11 @@ static const VMStateDescription vmstate_nand =3D { } }; =20 +static void nand_reset_handler(void *dev) +{ + device_cold_reset(DEVICE(dev)); +} + static void nand_realize(DeviceState *dev, Error **errp) { int pagesize; @@ -423,6 +429,13 @@ static void nand_realize(DeviceState *dev, Error **err= p) } /* Give s->ioaddr a sane value in case we save state before it is used= . */ s->ioaddr =3D s->io; + + qemu_register_reset(nand_reset_handler, dev); +} + +static void nand_unrealize(DeviceState *dev) +{ + qemu_unregister_reset(nand_reset_handler, dev); } =20 static Property nand_properties[] =3D { @@ -437,6 +450,7 @@ static void nand_class_init(ObjectClass *klass, void *d= ata) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D nand_realize; + dc->unrealize =3D nand_unrealize; dc->reset =3D nand_reset; dc->vmsd =3D &vmstate_nand; device_class_set_props(dc, nand_properties); --=20 2.26.3 From nobody Fri May 17 11:05:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) client-ip=209.85.128.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1619987495; cv=none; d=zohomail.com; s=zohoarc; b=hJQU1omc+CY41/QTkhnZ8NbOuUtVTzgIXVy68UIr8IkrLqEfWiTi2l9+Z0UAxFK26GYu1B4ftUYtDPCQbZMEiQvH8qzEPauGMV5ZEeXdIyPuEkmvlisb7aBiSUVCf0LmQlAIzVSbfojtc//gKek+njbEUddzVcAjRyVfj0ebnPg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619987495; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mAjmyzPT3IwY2l6eFakhdO2wuhU1yMrtB6iL9Jf4M7Y=; b=dilSFumefXVH3M0I3TzbYpns2nfB4D7cAWeiAwSaC67CoEsRiUruL7oeXM3ROch/FTRjMXrh1l6HdnQ1VyZApVre0GCSp4sOq8y9iCG/xsXUW4CmcEVE55WUeCjSOrgtjITLp1HKjz14WWgHBJve3aQQUJa9XX1Xtm8ZUT3BP9Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.zohomail.com with SMTPS id 1619987495872730.5540584106235; Sun, 2 May 2021 13:31:35 -0700 (PDT) Received: by mail-wm1-f41.google.com with SMTP id l24-20020a7bc4580000b029014ac3b80020so549399wmi.1 for ; Sun, 02 May 2021 13:31:35 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (anancy-651-1-208-144.w109-217.abo.wanadoo.fr. [109.217.237.144]) by smtp.gmail.com with ESMTPSA id h8sm9067171wmq.19.2021.05.02.13.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 13:31:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mAjmyzPT3IwY2l6eFakhdO2wuhU1yMrtB6iL9Jf4M7Y=; b=o3LOVQ/dXR7NqPs2/gbNNCwcI027XTM9F3Dx++RyowbKmd0xB0P442jHmJl7qKQf4Y AUCWLWG5HGTAuMBhlxCWxPlj/xuqPwFAriCGkWAb/a5wmNbSphwwfL4ph7TQEEepCM2n q5D1Ees1yGjoLZbrJyAWRYicW88AFNFxBc0fOx1OCG6SEqO7j+xAYTzR1sK7fGpmLore /n9TUGQMWgCh5bjFtqK9rYVGfHQf6O/WnxsD5YxoP14lShs5+Y6C3i4vGmlfyQNG364j RoobFFiwrrKb2paYKvNq02ggVVEfm5CHwlTghTiIRJA/7Mcjl4uJVCKVNPivqHg+7Pf6 6xuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=mAjmyzPT3IwY2l6eFakhdO2wuhU1yMrtB6iL9Jf4M7Y=; b=UmNTbI7162LP+v2G1elv9WLzon8dN/2k74mwPtDKgaM6y7UeWEBrVgkOnfyzxOV5Zw E3d/vjgY8oafABrrJcEuJHkmaM1XcJBoiHgHmnZiq+KlStcZ/sMIx+j4w1s9W6MdLGcc cF2OfYaZ433AtAkchY+AbdfHFvCDOf70ZJW/0KlkKN1s9lutepVNUQJKDxyLV/BEEBku jWxTyRr7jcapVqsO2R7ENZoxd87HImWEtLNztKH8Z5ByHUp4EIeN4o3m+pCgRNChfgs6 W9GC7oP/aTL/j3M2nuq5AMJdIpX2s09GJ59Ca8LfZh67lvzF1prAvFYX1ATOy2xNULMV XZNg== X-Gm-Message-State: AOAM530WSkTsWiugD4OmoKtKcG9qmMWrah3b0znQ3lTuhe8JaSvmPm2n 7Ben2I3SkLCXYNlmuyloe5Q= X-Google-Smtp-Source: ABdhPJxYOC8q43NUDeUgURyyxUaisqM9NaWxbdQTiPXEyl9DAfqozIxDr/hNihSBMvQaiGqBtJlMcw== X-Received: by 2002:a05:600c:350f:: with SMTP id h15mr18171455wmq.181.1619987494214; Sun, 02 May 2021 13:31:34 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Max Reitz , qemu-block@nongnu.org, Peter Maydell , Kevin Wolf , Mark Cave-Ayland , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson , Greg Kurz Subject: [PATCH v2 2/3] hw/pci-host/raven: Manually reset the OR_IRQ device Date: Sun, 2 May 2021 22:31:20 +0200 Message-Id: <20210502203121.630944-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210502203121.630944-1-f4bug@amsat.org> References: <20210502203121.630944-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The OR_IRQ device is bus-less, thus isn't reset automatically. Add the raven_pcihost_reset() handler to manually reset the OR IRQ. Fixes: f40b83a4e31 ("40p: use OR gate to wire up raven PCI interrupts") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: David Gibson --- hw/pci-host/prep.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 0a9162fba97..7481bbf99d4 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -230,6 +230,15 @@ static void raven_change_gpio(void *opaque, int n, int= level) s->contiguous_map =3D level; } =20 +static void raven_pcihost_reset_enter(Object *obj, ResetType type) +{ + PREPPCIState *s =3D RAVEN_PCI_HOST_BRIDGE(obj); + + if (!s->is_legacy_prep) { + device_cold_reset(DEVICE(&s->or_irq)); + } +} + static void raven_pcihost_realizefn(DeviceState *d, Error **errp) { SysBusDevice *dev =3D SYS_BUS_DEVICE(d); @@ -419,11 +428,13 @@ static Property raven_pcihost_properties[] =3D { static void raven_pcihost_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); + ResettableClass *rc =3D RESETTABLE_CLASS(klass); =20 set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->realize =3D raven_pcihost_realizefn; device_class_set_props(dc, raven_pcihost_properties); dc->fw_name =3D "pci"; + rc->phases.enter =3D raven_pcihost_reset_enter; } =20 static const TypeInfo raven_pcihost_info =3D { --=20 2.26.3 From nobody Fri May 17 11:05:48 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) client-ip=209.85.128.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1619987500; cv=none; d=zohomail.com; s=zohoarc; b=FUleS+onJK+m6/L5zzk+oefM6UKaDue7T4NUmIqbPgqxSmZiUKeS2gGKxPK6UIasjuNabgMS/tYKnAm7F/ii/nvPT42B0eXvcGykdz8adc89ykCvE4rhnskGIvJcCXDQqh2sFOyaU18Onm6jdMqWcNsJXRz8k0G461OduM9ovnk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619987500; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1wLp4aTj+pbMibqvZAxrBIac9OxculfaSC45JDiLwlk=; b=NcfDtOiP8xSWgDg9xnIDJPgEFkR0fOBi6BUSfIV7GGxU39KtRIwHA+rNHQu5vfDKM38OA4Hcqcp28aBs/3vlioyawo6TUKnKJf2dnEseK2ntzDl8tdiJS4IwjTg/Hgux3V2biu3jXtElY6b4gyYeXWLJy4AC4MXkCqC5sT+UWRk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) by mx.zohomail.com with SMTPS id 1619987500717300.5917980157677; Sun, 2 May 2021 13:31:40 -0700 (PDT) Received: by mail-wm1-f50.google.com with SMTP id 4-20020a05600c26c4b0290146e1feccd8so2351312wmv.1 for ; Sun, 02 May 2021 13:31:40 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (anancy-651-1-208-144.w109-217.abo.wanadoo.fr. [109.217.237.144]) by smtp.gmail.com with ESMTPSA id f24sm20279883wmb.32.2021.05.02.13.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 May 2021 13:31:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1wLp4aTj+pbMibqvZAxrBIac9OxculfaSC45JDiLwlk=; b=EqfkNzKeaYNINFqhpz8ytQ7/WyNimPujlp9uzSdRtzVvW+jIPHvbyY1Tp9n4Y/rByc H3MaWNP+y4wKsQFSOdmjdbt5ouv+D9yOrzyiDhUEenboOnEZ1Tuzm6mQAEQ74xacWiss 0pszIBRxiEnP1ySedB11/IZDzKyrQJapci63HacFAONvjL/cAtuYhrd4efP0od5xTDiT WPNfX6q9OkdNwGwaXb2h1UDonh3Ojf6kPcepFu1EnaI+NiLFCaM0yuccM3Ecy+xEs4Dt 9DNjOKj2ZNZf1F3V8GoEBHsal9tnZZtnxL+s2tJhlOX9mQyKxhniSPUdR2MxMorYwU8F Tyzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=1wLp4aTj+pbMibqvZAxrBIac9OxculfaSC45JDiLwlk=; b=DTor4KPbokhE0l98AWnk4H2EFIzCoV0UbSIDJFrh1I+c8iXnUlf750uc4mHApPIE1d VO2Dfzo606vPA8Y2tIk8CRGWTy1nmwGOXoeR4++2Dxwojp3z95DkQsd0HS9xTvhPcFVG A4w4fhKhGd1QFYrisQuKY7/VSJj9cKTz6zTtXGJZtXZLuTzQYxb3hIlgb17CmNi99fnz HotAx20f+2fWL+c1Aw2Tb/U7+oKEvZ+DZbNMVHlQpyahKxI+o3q8yr+9sfiyG4inEKSJ kaT3FD/807wj4Ezby+s+mVN2GQUx9eQcGsP2njk6vBHNswnIGnhGawUwNkKYhuM8/TMu WNkA== X-Gm-Message-State: AOAM530NLe8Ie5Q1QpuP6wqu+ZekzLV/dRW3lXFkEbj7KJ1PL8t/jFpa 4++agRRbx1zjOZG2Vqa6kPE= X-Google-Smtp-Source: ABdhPJwVHDh7IRBsLm4nN0H+MLNeFpnsQ60AEqd5JDsxjBUgUwnwNh9wid254oLwEREWfo4lHuJp9g== X-Received: by 2002:a05:600c:3798:: with SMTP id o24mr29222522wmr.12.1619987499074; Sun, 02 May 2021 13:31:39 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Max Reitz , qemu-block@nongnu.org, Peter Maydell , Kevin Wolf , Mark Cave-Ayland , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , qemu-ppc@nongnu.org, Markus Armbruster , qemu-arm@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 3/3] hw/arm/armsse: Manually reset the OR_IRQ devices Date: Sun, 2 May 2021 22:31:21 +0200 Message-Id: <20210502203121.630944-4-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210502203121.630944-1-f4bug@amsat.org> References: <20210502203121.630944-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The OR_IRQ device is bus-less, thus isn't reset automatically. Manually reset the OR IRQs in the armsse_reset() handler. Fixes: bb75e16d5e6 ("hw/arm/iotkit: Wire up MPC interrupt lines") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell --- hw/arm/armsse.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/arm/armsse.c b/hw/arm/armsse.c index 2e5d0679e7b..a5f8e89950e 100644 --- a/hw/arm/armsse.c +++ b/hw/arm/armsse.c @@ -1668,6 +1668,10 @@ static void armsse_reset(DeviceState *dev) ARMSSE *s =3D ARM_SSE(dev); =20 s->nsccfg =3D 0; + + device_cold_reset(DEVICE(&s->mpc_irq_orgate)); + device_cold_reset(DEVICE(&s->ppc_irq_orgate)); + device_cold_reset(DEVICE(&s->sec_resp_splitter)); } =20 static void armsse_class_init(ObjectClass *klass, void *data) --=20 2.26.3