From nobody Tue Feb 10 03:22:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1619819035; cv=none; d=zohomail.com; s=zohoarc; b=VhNBhcri/Hs+P0ORp1AwvxUB6n5Ok/3xRykzb1TBM37jypluAKXbcjzjwQ4D2uwkep7QUu18u0AtsMvHfgSDP3Y+ntyLb5RZMCNR6Vjn7d0Y5fJYNqjlt2Rcy5NaQZvi0M2Va6hrO35+9Q+DAOGne3ru+xnxvwq+VCt5lBaC1I8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619819035; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=U78s1K6Mk0HaQ9NfTrza34rZqvuxpZF/YneeMMsbIUE=; b=c20/WAm9Gj8GlIrgaSK7a5A2j8K5cnG4HVOf3xLv6dc0PiCF2LBrgQsstV1khYXrOqm7g78L0tN5nGijWlkLYFtWOa6+k3/ybqxE4R+NfBuD/VLFrRGHfSp43TrUGm1mtKAC9/9j1YC2z2pQKpaEd1bG2ULMEVPJiHJOxPFyjcQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1619819034795122.54674899939573; Fri, 30 Apr 2021 14:43:54 -0700 (PDT) Received: from localhost ([::1]:53240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcavR-0001OV-MT for importer@patchew.org; Fri, 30 Apr 2021 17:43:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36862) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcaq7-00032o-GS for qemu-devel@nongnu.org; Fri, 30 Apr 2021 17:38:23 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:37335) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcapz-0002eZ-0f for qemu-devel@nongnu.org; Fri, 30 Apr 2021 17:38:23 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 52BA61DCA; Fri, 30 Apr 2021 17:38:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 30 Apr 2021 17:38:13 -0400 Received: from Gustavos-Mini.box (unknown [201.80.1.6]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Apr 2021 17:38:11 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=noronha.eti.br; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=U78s1K6Mk0 HaQ9NfTrza34rZqvuxpZF/YneeMMsbIUE=; b=MaYTZyv71NSjz2xQg8X4e7C4bp ZUOOP98oHixdddAtPR2SZTRhH12TlzQD3GE6cAzY3d0ggxXpyKPlP3kbco+K3HON JokvKVjOAEX32w+/MI6JeYRwUpbz1WWmsC9Vwj9fUC1jF7DGeY+jGGKS3IwmBbqi 0LHXXNqaqQXsT9k8s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=U78s1K6Mk0HaQ9NfTrza34rZqvuxpZF/YneeMMsbIUE=; b=bquS0joe 9ykrxxhVe/mM1nt/Yw1u9RgrBCjO7A5y8N+o0v96lY+ad6czzHe/99Q4DpTN43WY YtZ/MhdUvJ5zXmSgNtr1CgrWToHP09UuNr27IKGw8XuQ1Dm0ZWkWN3jcjglcdMKt SrujLFcxRk9+CMH0VpDHkINU2+NfcoZ4a68hb2JgGHVlKqCE2sf+BIa9gb3nHnI6 FNA0JQ2TewZBKmE5Mw1J6yCnyd+EXNQVaHrKaiRWATLJk8wnQirKY2TTQTJdVCOo ado+8rmiZAAinlhwdiHEMmHt/3q2iau02qtsrZvLBgh0W9RvayR0n1a2uT3cnNAs 1NgXPX6/WfZuow== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvjedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpehguhhsthgr vhhosehnohhrohhnhhgrrdgvthhirdgsrhenucggtffrrghtthgvrhhnpeevhfdvjeelve etiedutdfhleegleffkeffjefgtdeggfekheehledttdffvdelleenucffohhmrghinhep rghpphhlvgdrtghomhenucfkphepvddtuddrkedtrddurdeinecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhushhtrghvohesnhhorhhonhhh rgdrvghtihdrsghr X-ME-Proxy: From: gustavo@noronha.eti.br To: qemu-devel@nongnu.org Subject: [PATCH v2 1/2] ui/cocoa: capture all keys and combos when mouse is grabbed Date: Fri, 30 Apr 2021 18:38:05 -0300 Message-Id: <20210430213806.81457-2-gustavo@noronha.eti.br> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20210430213806.81457-1-gustavo@noronha.eti.br> References: <20210430213806.81457-1-gustavo@noronha.eti.br> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=64.147.123.25; envelope-from=gustavo@noronha.eti.br; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 'Peter Maydell ' , 'Markus Armbruster ' , 'Gerd Hoffmann ' Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Gustavo Noronha Silva Applications such as Gnome may use Alt-Tab and Super-Tab for different purposes, some use Ctrl-arrows so we want to allow qemu to handle everything when it captures the mouse/keyboard. However, Mac OS handles some combos like Command-Tab and Ctrl-arrows at an earlier part of the event handling chain, not letting qemu see it. We add a global Event Tap that allows qemu to see all events when the mouse is grabbed. Note that this requires additional permissions. See: https://developer.apple.com/documentation/coregraphics/1454426-cgeventtapcr= eate?language=3Dobjc#discussion https://support.apple.com/en-in/guide/mac-help/mh32356/mac Acked-by: Markus Armbruster Signed-off-by: Gustavo Noronha Silva Acked-By.=20 --- qapi/ui.json | 16 +++++++++++ qemu-options.hx | 3 ++ ui/cocoa.m | 73 +++++++++++++++++++++++++++++++++++++++++++++++-- 3 files changed, 90 insertions(+), 2 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 1052ca9c38..4ccfae4bbb 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1088,6 +1088,21 @@ { 'struct' : 'DisplayCurses', 'data' : { '*charset' : 'str' } } =20 +## +# @DisplayCocoa: +# +# Cocoa display options. +# +# @full-grab: Capture all key presses, including system combos. This +# requires accessibility permissions, since it performs +# a global grab on key events. (default: off) +# See https://support.apple.com/en-in/guide/mac-help/mh32356/m= ac +# +# Since: 6.1 +## +{ 'struct' : 'DisplayCocoa', + 'data' : { '*full-grab' : 'bool' } } + ## # @DisplayType: # @@ -1153,6 +1168,7 @@ '*gl' : 'DisplayGLMode' }, 'discriminator' : 'type', 'data' : { 'gtk' : 'DisplayGTK', + 'cocoa' : 'DisplayCocoa', 'curses' : 'DisplayCurses', 'egl-headless' : 'DisplayEGLHeadless'} } =20 diff --git a/qemu-options.hx b/qemu-options.hx index fd21002bd6..a77505241f 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1783,6 +1783,9 @@ DEF("display", HAS_ARG, QEMU_OPTION_display, #if defined(CONFIG_CURSES) "-display curses[,charset=3D]\n" #endif +#if defined(CONFIG_COCOA) + "-display cocoa[,full_grab=3Don|off]\n" +#endif #if defined(CONFIG_OPENGL) "-display egl-headless[,rendernode=3D]\n" #endif diff --git a/ui/cocoa.m b/ui/cocoa.m index 37e1fb52eb..f1e4449082 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -72,6 +72,7 @@ typedef struct { int width; int height; + bool full_grab; } QEMUScreen; =20 static void cocoa_update(DisplayChangeListener *dcl, @@ -304,11 +305,13 @@ @interface QemuCocoaView : NSView BOOL isMouseGrabbed; BOOL isFullscreen; BOOL isAbsoluteEnabled; + CFMachPortRef eventsTap; } - (void) switchSurface:(pixman_image_t *)image; - (void) grabMouse; - (void) ungrabMouse; - (void) toggleFullScreen:(id)sender; +- (void) setFullGrab:(id)sender to:(BOOL)value; - (void) handleMonitorInput:(NSEvent *)event; - (bool) handleEvent:(NSEvent *)event; - (bool) handleEventLocked:(NSEvent *)event; @@ -323,6 +326,7 @@ - (void) setAbsoluteEnabled:(BOOL)tIsAbsoluteEnabled; */ - (BOOL) isMouseGrabbed; - (BOOL) isAbsoluteEnabled; +- (BOOL) isFullGrabEnabled; - (float) cdx; - (float) cdy; - (QEMUScreen) gscreen; @@ -331,6 +335,19 @@ - (void) raiseAllKeys; =20 QemuCocoaView *cocoaView; =20 +static CGEventRef handleTapEvent(CGEventTapProxy proxy, CGEventType type, = CGEventRef cgEvent, void *userInfo) +{ + QemuCocoaView *cocoaView =3D (QemuCocoaView*) userInfo; + NSEvent* event =3D [NSEvent eventWithCGEvent:cgEvent]; + if ([cocoaView isFullGrabEnabled] && [cocoaView isMouseGrabbed] && [co= coaView handleEvent:event]) { + COCOA_DEBUG("Global events tap: qemu handled the event, capturing!= \n"); + return NULL; + } + COCOA_DEBUG("Global events tap: qemu did not handle the event, letting= it through...\n"); + + return cgEvent; +} + @implementation QemuCocoaView - (id)initWithFrame:(NSRect)frameRect { @@ -344,6 +361,32 @@ - (id)initWithFrame:(NSRect)frameRect kbd =3D qkbd_state_init(dcl.con); =20 } + + CGEventMask mask =3D CGEventMaskBit(kCGEventKeyDown) | CGEventMaskBit(= kCGEventKeyUp) | CGEventMaskBit(kCGEventFlagsChanged); + eventsTap =3D CGEventTapCreate(kCGHIDEventTap, kCGHeadInsertEventTap, = kCGEventTapOptionDefault, + mask, handleTapEvent, self); + if (!eventsTap) { + warn_report("Could not create event tap, system key combos will no= t be captured.\n"); + return self; + } else { + COCOA_DEBUG("Global events tap created! Will capture system key co= mbos.\n"); + } + + CFRunLoopRef runLoop =3D CFRunLoopGetCurrent(); + if (!runLoop) { + warn_report("Could not obtain current CF RunLoop, system key combo= s will not be captured.\n"); + return self; + } + + CFRunLoopSourceRef tapEventsSrc =3D CFMachPortCreateRunLoopSource(kCFA= llocatorDefault, eventsTap, 0); + if (!tapEventsSrc ) { + warn_report("Could not obtain current CF RunLoop, system key combo= s will not be captured.\n"); + return self; + } + + CFRunLoopAddSource(runLoop, tapEventsSrc, kCFRunLoopDefaultMode); + CFRelease(tapEventsSrc); + return self; } =20 @@ -356,6 +399,11 @@ - (void) dealloc } =20 qkbd_state_free(kbd); + + if (eventsTap) { + CFRelease(eventsTap); + } + [super dealloc]; } =20 @@ -593,6 +641,13 @@ - (void) toggleFullScreen:(id)sender } } =20 +- (void) setFullGrab:(id)sender to:(BOOL)value +{ + COCOA_DEBUG("QemuCocoaView: setFullGrab\n"); + + screen.full_grab =3D value; +} + - (void) toggleKey: (int)keycode { qkbd_state_key_event(kbd, keycode, !qkbd_state_key_get(kbd, keycode)); } @@ -1029,6 +1084,7 @@ - (void) setAbsoluteEnabled:(BOOL)tIsAbsoluteEnabled { } - (BOOL) isMouseGrabbed {return isMouseGrabbed;} - (BOOL) isAbsoluteEnabled {return isAbsoluteEnabled;} +- (BOOL) isFullGrabEnabled {return screen.full_grab;} - (float) cdx {return cdx;} - (float) cdy {return cdy;} - (QEMUScreen) gscreen {return screen;} @@ -1208,6 +1264,13 @@ - (void)toggleFullScreen:(id)sender [cocoaView toggleFullScreen:sender]; } =20 +- (void) setFullGrab:(id)sender to:(BOOL)value +{ + COCOA_DEBUG("QemuCocoaAppController: setFullGrab\n"); + + [cocoaView setFullGrab:sender to:value]; +} + /* Tries to find then open the specified filename */ - (void) openDocumentation: (NSString *) filename { @@ -1877,16 +1940,22 @@ static void cocoa_display_init(DisplayState *ds, Di= splayOptions *opts) qemu_sem_wait(&app_started_sem); COCOA_DEBUG("cocoa_display_init: app start completed\n"); =20 + QemuCocoaAppController* controller =3D (QemuCocoaAppController *)[NSAp= plication sharedApplication]; /* if fullscreen mode is to be used */ if (opts->has_full_screen && opts->full_screen) { dispatch_async(dispatch_get_main_queue(), ^{ [NSApp activateIgnoringOtherApps: YES]; - [(QemuCocoaAppController *)[[NSApplication sharedApplication] = delegate] toggleFullScreen: nil]; + [[controller delegate] toggleFullScreen: nil]; + }); + } + if (opts->u.cocoa.has_full_grab && opts->u.cocoa.full_grab) { + dispatch_async(dispatch_get_main_queue(), ^{ + [[controller delegate] setFullGrab: nil to:opts->u.cocoa.full_= grab]; }); } if (opts->has_show_cursor && opts->show_cursor) { cursor_hide =3D 0; - } + }; =20 // register vga output callbacks register_displaychangelistener(&dcl); --=20 2.24.3 (Apple Git-128) From nobody Tue Feb 10 03:22:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1619819978; cv=none; d=zohomail.com; s=zohoarc; b=gWeYEByH1ruM6VTbQ0KnVnrhJxe3VBrbRRKFOvGPHqPfxVSMm3b8eHpEiIW6LZ/dbUnNqaJCsLaVjUDkO9pqs7y0Vb9B0EGOi/qdFk8viAA8jJALsGzeXA/3Ef8lzwrZeyWPK9V8EZkH21MxGomD+f3EXr6+STcvUYkO61ztpaU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619819978; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LPwA/7llEmWjU7lVXxDWPf2hW3XmpdRVxJgT8EnSvuw=; b=d7qGZB1a3Ny7ug3AtoBeY9R4G5qZw95edloGc/hjA4/PAuuP+YnJ6gl8fvSG/4UP7LIQZMWFkWYhbJp62umXM/M/nYvaxA1ca98OIOhBwwQY5RZpltbmE9D9YyER/3MvpuiWI3a3X9ZjELDM10cCFMp0JhQjHkJ0N1FxeRdfJ7c= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1619819978373946.2849371714658; Fri, 30 Apr 2021 14:59:38 -0700 (PDT) Received: from localhost ([::1]:32908 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcbAf-0000W1-6J for importer@patchew.org; Fri, 30 Apr 2021 17:59:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36874) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcaq9-00034f-Mi for qemu-devel@nongnu.org; Fri, 30 Apr 2021 17:38:25 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:57017) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcaq1-0002ft-Vr for qemu-devel@nongnu.org; Fri, 30 Apr 2021 17:38:25 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id AEAE81DCB; Fri, 30 Apr 2021 17:38:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 30 Apr 2021 17:38:16 -0400 Received: from Gustavos-Mini.box (unknown [201.80.1.6]) by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Apr 2021 17:38:14 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=noronha.eti.br; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=mesmtp; bh=LPwA/7llEm WjU7lVXxDWPf2hW3XmpdRVxJgT8EnSvuw=; b=ShNKJQCIvj7Tv1QOQDDPi0PG66 kXhKGmjcAcYBeooWrNwx4fGTZJ8O272sbyNZ/ZAiP2UMikgYnRsA8R1xG7uXfsbn M/xePAu214vVIPozIuHQshNPDjfkKv9Fn30yDceRTEamiB1ZSf5VWImEgrprxP0V d0QMNy/uK8GFw9348= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=LPwA/7llEmWjU7lVXxDWPf2hW3XmpdRVxJgT8EnSvuw=; b=KlZubF9Q +l/JKbd+5jtBBf3xOq1LYy18JcHZ7xyssM5BpefoTGpVZh639uqY89Rn9FpJCDbv Dr0DTQzWigO69mJvK4wzOnMLxNYAMb+tqpHe4T1KEBaaIQDA6EIDsIBjM3gcbfGs MJel7UmHWKIB8ZuopGwV/RE4AeeiWxhum89JuP4An7nZQS0LlW7DcozTPA7zf/dY tzUs8/nhVSw4kgi9e8ipKrZ6Ax1/Ai+tSladNO80BalG5ryr2sa98YpobxpA45Mz 4CHe60+FXkD+fgbYvgXFwBpCB/SB/22pz6JRI8G8GTisSuiNpVXCt4A2nQNIx9BO pCUAoZXFDZo+6g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddvjedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpehguhhsthgr vhhosehnohhrohhnhhgrrdgvthhirdgsrhenucggtffrrghtthgvrhhnpeevhfdvjeelve etiedutdfhleegleffkeffjefgtdeggfekheehledttdffvdelleenucffohhmrghinhep rghpphhlvgdrtghomhenucfkphepvddtuddrkedtrddurdeinecuvehluhhsthgvrhfuih iivgepudenucfrrghrrghmpehmrghilhhfrhhomhepghhushhtrghvohesnhhorhhonhhh rgdrvghtihdrsghr X-ME-Proxy: From: gustavo@noronha.eti.br To: qemu-devel@nongnu.org Subject: [PATCH v2 2/2] ui/cocoa: add option to swap Option and Command, enable by default Date: Fri, 30 Apr 2021 18:38:06 -0300 Message-Id: <20210430213806.81457-3-gustavo@noronha.eti.br> X-Mailer: git-send-email 2.24.3 (Apple Git-128) In-Reply-To: <20210430213806.81457-1-gustavo@noronha.eti.br> References: <20210430213806.81457-1-gustavo@noronha.eti.br> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=64.147.123.25; envelope-from=gustavo@noronha.eti.br; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 'Peter Maydell ' , 'Markus Armbruster ' , 'Gerd Hoffmann ' Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Gustavo Noronha Silva On Mac OS X the Option key maps to Alt and Command to Super/Meta. This chan= ge swaps them around so that Alt is the key closer to the space bar and Meta/S= uper is between Control and Alt, like on non-Mac keyboards. It is a cocoa display option, enabled by default. Acked-by: Markus Armbruster Signed-off-by: Gustavo Noronha Silva Acked-By.=20 --- qapi/ui.json | 8 ++++++- qemu-options.hx | 3 ++- ui/cocoa.m | 64 ++++++++++++++++++++++++++++++++++++++++++------- 3 files changed, 65 insertions(+), 10 deletions(-) diff --git a/qapi/ui.json b/qapi/ui.json index 4ccfae4bbb..ffd416a474 100644 --- a/qapi/ui.json +++ b/qapi/ui.json @@ -1098,10 +1098,16 @@ # a global grab on key events. (default: off) # See https://support.apple.com/en-in/guide/mac-help/mh32356/m= ac # +# @swap-option-command: Swap the Option and Command keys so that their key +# codes match their position on non-Mac keyboards and +# you can use Meta/Super and Alt where you expect th= em. +# (default: on) +# # Since: 6.1 ## { 'struct' : 'DisplayCocoa', - 'data' : { '*full-grab' : 'bool' } } + 'data' : { '*full-grab' : 'bool', + '*swap-option-command' : 'bool' } } =20 ## # @DisplayType: diff --git a/qemu-options.hx b/qemu-options.hx index a77505241f..6fcb0b6aaa 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1784,7 +1784,8 @@ DEF("display", HAS_ARG, QEMU_OPTION_display, "-display curses[,charset=3D]\n" #endif #if defined(CONFIG_COCOA) - "-display cocoa[,full_grab=3Don|off]\n" + "-display cocoa[,full-grab=3Don|off]\n" + " [,swap-option-command=3Don|off]\n" #endif #if defined(CONFIG_OPENGL) "-display egl-headless[,rendernode=3D]\n" diff --git a/ui/cocoa.m b/ui/cocoa.m index f1e4449082..73eb5080be 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -73,6 +73,7 @@ int width; int height; bool full_grab; + bool swap_option_command; } QEMUScreen; =20 static void cocoa_update(DisplayChangeListener *dcl, @@ -327,6 +328,7 @@ - (void) setAbsoluteEnabled:(BOOL)tIsAbsoluteEnabled; - (BOOL) isMouseGrabbed; - (BOOL) isAbsoluteEnabled; - (BOOL) isFullGrabEnabled; +- (BOOL) isSwapOptionCommandEnabled; - (float) cdx; - (float) cdy; - (QEMUScreen) gscreen; @@ -648,6 +650,13 @@ - (void) setFullGrab:(id)sender to:(BOOL)value screen.full_grab =3D value; } =20 +- (void) setSwapOptionCommand:(id)sender +{ + COCOA_DEBUG("QemuCocoaView: setSwapOptionCommand\n"); + + screen.swap_option_command =3D true; +} + - (void) toggleKey: (int)keycode { qkbd_state_key_event(kbd, keycode, !qkbd_state_key_get(kbd, keycode)); } @@ -797,12 +806,22 @@ - (bool) handleEventLocked:(NSEvent *)event qkbd_state_key_event(kbd, Q_KEY_CODE_CTRL_R, false); } if (!(modifiers & NSEventModifierFlagOption)) { - qkbd_state_key_event(kbd, Q_KEY_CODE_ALT, false); - qkbd_state_key_event(kbd, Q_KEY_CODE_ALT_R, false); + if ([self isSwapOptionCommandEnabled]) { + qkbd_state_key_event(kbd, Q_KEY_CODE_META_L, false); + qkbd_state_key_event(kbd, Q_KEY_CODE_META_R, false); + } else { + qkbd_state_key_event(kbd, Q_KEY_CODE_ALT, false); + qkbd_state_key_event(kbd, Q_KEY_CODE_ALT_R, false); + } } if (!(modifiers & NSEventModifierFlagCommand)) { - qkbd_state_key_event(kbd, Q_KEY_CODE_META_L, false); - qkbd_state_key_event(kbd, Q_KEY_CODE_META_R, false); + if ([self isSwapOptionCommandEnabled]) { + qkbd_state_key_event(kbd, Q_KEY_CODE_ALT, false); + qkbd_state_key_event(kbd, Q_KEY_CODE_ALT_R, false); + } else { + qkbd_state_key_event(kbd, Q_KEY_CODE_META_L, false); + qkbd_state_key_event(kbd, Q_KEY_CODE_META_R, false); + } } =20 switch ([event type]) { @@ -834,13 +853,21 @@ - (bool) handleEventLocked:(NSEvent *)event =20 case kVK_Option: if (!!(modifiers & NSEventModifierFlagOption)) { - [self toggleKey:Q_KEY_CODE_ALT]; + if ([self isSwapOptionCommandEnabled]) { + [self toggleKey:Q_KEY_CODE_META_L]; + } else { + [self toggleKey:Q_KEY_CODE_ALT]; + } } break; =20 case kVK_RightOption: if (!!(modifiers & NSEventModifierFlagOption)) { - [self toggleKey:Q_KEY_CODE_ALT_R]; + if ([self isSwapOptionCommandEnabled]) { + [self toggleKey:Q_KEY_CODE_META_R]; + } else { + [self toggleKey:Q_KEY_CODE_ALT_R]; + } } break; =20 @@ -848,14 +875,22 @@ - (bool) handleEventLocked:(NSEvent *)event case kVK_Command: if (isMouseGrabbed && !!(modifiers & NSEventModifierFlagCommand)) { - [self toggleKey:Q_KEY_CODE_META_L]; + if ([self isSwapOptionCommandEnabled]) { + [self toggleKey:Q_KEY_CODE_ALT]; + } else { + [self toggleKey:Q_KEY_CODE_META_L]; + } } break; =20 case kVK_RightCommand: if (isMouseGrabbed && !!(modifiers & NSEventModifierFlagCommand)) { - [self toggleKey:Q_KEY_CODE_META_R]; + if ([self isSwapOptionCommandEnabled]) { + [self toggleKey:Q_KEY_CODE_ALT_R]; + } else { + [self toggleKey:Q_KEY_CODE_META_R]; + } } break; } @@ -1085,6 +1120,7 @@ - (void) setAbsoluteEnabled:(BOOL)tIsAbsoluteEnabled { - (BOOL) isMouseGrabbed {return isMouseGrabbed;} - (BOOL) isAbsoluteEnabled {return isAbsoluteEnabled;} - (BOOL) isFullGrabEnabled {return screen.full_grab;} +- (BOOL) isSwapOptionCommandEnabled {return screen.swap_option_command;} - (float) cdx {return cdx;} - (float) cdy {return cdy;} - (QEMUScreen) gscreen {return screen;} @@ -1271,6 +1307,13 @@ - (void) setFullGrab:(id)sender to:(BOOL)value [cocoaView setFullGrab:sender to:value]; } =20 +- (void) setSwapOptionCommand:(id)sender +{ + COCOA_DEBUG("QemuCocoaAppController: setSwapOptionCommand\n"); + + [cocoaView setSwapOptionCommand:sender]; +} + /* Tries to find then open the specified filename */ - (void) openDocumentation: (NSString *) filename { @@ -1953,6 +1996,11 @@ static void cocoa_display_init(DisplayState *ds, Dis= playOptions *opts) [[controller delegate] setFullGrab: nil to:opts->u.cocoa.full_= grab]; }); } + if (!opts->u.cocoa.has_swap_option_command || opts->u.cocoa.swap_optio= n_command) { + dispatch_async(dispatch_get_main_queue(), ^{ + [[controller delegate] setSwapOptionCommand: nil]; + }); + } if (opts->has_show_cursor && opts->show_cursor) { cursor_hide =3D 0; }; --=20 2.24.3 (Apple Git-128)