From nobody Mon Feb 9 01:01:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619793733; cv=none; d=zohomail.com; s=zohoarc; b=nCzBAxUutWYVAq7VDHUyxQbJ9+n4MISyUEvpbhEPEM3R1ZDmdBLtvhWEx2KyS/pZQMvcf+UHVqL5vRksTyqptIOw6nJ8P/D/qXemidmpATEGzHOXgcxg5jQLvPeZ4swzWu1dC0OCWQ2k9bUAr/OSDFpT2Uqps5UxAY7zzbGhP3w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619793733; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=v2WLra2sSAdBan1Wq22qFHiVXFhh0NizItDhHSYEjJo=; b=jEsGGghCMw09QxNGy6NkkF0vsbPx0jglbN7wyTUrf3MrcJ9IGy6HqnlIeukgxp8Wat31HfxOnj6zbsD/O0nvYb+K3mNwcu6DQCCLW0MHC5zOYhnq3oFr3e6jR8ydDIP3kFA9W9YbaAJ/dhPW4DJQPN3qU1Fhy66NTQWxalbzW9E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1619793733939133.40074511503758; Fri, 30 Apr 2021 07:42:13 -0700 (PDT) Received: from localhost ([::1]:59712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcULM-0000fR-NF for importer@patchew.org; Fri, 30 Apr 2021 10:42:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcTVX-0004EW-LI for qemu-devel@nongnu.org; Fri, 30 Apr 2021 09:48:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46058) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcTVU-0007ND-QC for qemu-devel@nongnu.org; Fri, 30 Apr 2021 09:48:38 -0400 Received: from mail-ot1-f71.google.com (mail-ot1-f71.google.com [209.85.210.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-571-h8OmO3pwMziYDIHJhST1xQ-1; Fri, 30 Apr 2021 09:48:34 -0400 Received: by mail-ot1-f71.google.com with SMTP id h22-20020a9d6f960000b029029e185197c1so19793435otq.0 for ; Fri, 30 Apr 2021 06:48:34 -0700 (PDT) Received: from redhat.redhat.com (ip68-103-222-6.ks.ok.cox.net. [68.103.222.6]) by smtp.gmail.com with ESMTPSA id p127sm799072oig.16.2021.04.30.06.48.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 06:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619790515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v2WLra2sSAdBan1Wq22qFHiVXFhh0NizItDhHSYEjJo=; b=YSs+Ru1/AcdN+M+GZshQ1wuNGqcvFvEJf+WJ2JCHmA6m9GcAxOBC6D7wdMklpCVcMDUJrd izTKfgGM3RDgU8F1tNa7SztBE/Q9/TZrIDqAd/HRrol5rM8zYf1Ynv+BkHxRCSDHzgL1U7 XlNd3qTgtD4ulzzY2dtg1DVKxKhTbV4= X-MC-Unique: h8OmO3pwMziYDIHJhST1xQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=v2WLra2sSAdBan1Wq22qFHiVXFhh0NizItDhHSYEjJo=; b=ujt6olJ1yl+bBlKUl8rjVEBc68wPyzaHI58pHTxrJi9y8N65KwGwkRUMt41vbbLqxI DfzS+pbeqEjUllGbHDjj6vmgBo8T3HeeSDjFxmM9I20JRHfngL3A/l3S74GgsOcqIXAB ez39dsTsrPndsJH+zIYCA9zYHKgO540hJRENhtE0CDWmXjRBCOQEkURKMZUTDhlzLet8 rO3ujB18GKMVdO41x9QHUUD9F5YUNBv5E/xGe/Kxk8SDuAX0iLl5htiuNdjob1sKCx67 1P+//qhHP+LrdQBnN9y6dlpioU3v+ovwXWwDbuRgthR3fuGtoYmdr3sHEuFC0AyVArfB BmJA== X-Gm-Message-State: AOAM532qx50PrZdbKkHXxDh2EM+jMVTSGCbx3sdeS0xdv1dAc/UeAt/H muTeYMmZPC6tCSb+Xzs41CYIHMKc42FgTRhZ1WyqEDBaMbiTOlyYqnTddfOR/bxvSSh685lApLt I96fxaEfbE4UIpKRlff+8Zx/e+Dovg8ZjBzuxpTkKi+s6x2XLZzixcET2VWEkheee X-Received: by 2002:aca:90b:: with SMTP id 11mr10792445oij.77.1619790513290; Fri, 30 Apr 2021 06:48:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfgsr2LmGjeQuuw0bbXIGw5q0NUy31uiqbwLV0SQGrbtifZwxyCrmRcQ7/6a/ka4kqZn7ovg== X-Received: by 2002:aca:90b:: with SMTP id 11mr10792431oij.77.1619790513099; Fri, 30 Apr 2021 06:48:33 -0700 (PDT) From: Connor Kuehl To: qemu-devel@nongnu.org Subject: [PATCH 1/2] [RESEND] sev: use explicit indices for mapping firmware error codes to strings Date: Fri, 30 Apr 2021 08:48:29 -0500 Message-Id: <20210430134830.254741-2-ckuehl@redhat.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210430134830.254741-1-ckuehl@redhat.com> References: <20210430134830.254741-1-ckuehl@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ckuehl@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=ckuehl@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.22, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thomas.lendacky@amd.com, brijesh.singh@amd.com, ehabkost@redhat.com, richard.henderson@linaro.org, pbonzini@redhat.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This can help lower any margin for error when making future additions to the list, especially if they're made out of order. While doing so, make capitalization of ASID consistent with its usage in the SEV firmware spec (Asid -> ASID). Signed-off-by: Connor Kuehl Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/sev.c | 46 +++++++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/target/i386/sev.c b/target/i386/sev.c index 72b9e2ab40..9e2e47012f 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -88,29 +88,29 @@ static SevGuestState *sev_guest; static Error *sev_mig_blocker; =20 static const char *const sev_fw_errlist[] =3D { - "", - "Platform state is invalid", - "Guest state is invalid", - "Platform configuration is invalid", - "Buffer too small", - "Platform is already owned", - "Certificate is invalid", - "Policy is not allowed", - "Guest is not active", - "Invalid address", - "Bad signature", - "Bad measurement", - "Asid is already owned", - "Invalid ASID", - "WBINVD is required", - "DF_FLUSH is required", - "Guest handle is invalid", - "Invalid command", - "Guest is active", - "Hardware error", - "Hardware unsafe", - "Feature not supported", - "Invalid parameter" + [SEV_RET_SUCCESS] =3D "", + [SEV_RET_INVALID_PLATFORM_STATE] =3D "Platform state is invalid", + [SEV_RET_INVALID_GUEST_STATE] =3D "Guest state is invalid", + [SEV_RET_INAVLID_CONFIG] =3D "Platform configuration is invali= d", + [SEV_RET_INVALID_LEN] =3D "Buffer too small", + [SEV_RET_ALREADY_OWNED] =3D "Platform is already owned", + [SEV_RET_INVALID_CERTIFICATE] =3D "Certificate is invalid", + [SEV_RET_POLICY_FAILURE] =3D "Policy is not allowed", + [SEV_RET_INACTIVE] =3D "Guest is not active", + [SEV_RET_INVALID_ADDRESS] =3D "Invalid address", + [SEV_RET_BAD_SIGNATURE] =3D "Bad signature", + [SEV_RET_BAD_MEASUREMENT] =3D "Bad measurement", + [SEV_RET_ASID_OWNED] =3D "ASID is already owned", + [SEV_RET_INVALID_ASID] =3D "Invalid ASID", + [SEV_RET_WBINVD_REQUIRED] =3D "WBINVD is required", + [SEV_RET_DFFLUSH_REQUIRED] =3D "DF_FLUSH is required", + [SEV_RET_INVALID_GUEST] =3D "Guest handle is invalid", + [SEV_RET_INVALID_COMMAND] =3D "Invalid command", + [SEV_RET_ACTIVE] =3D "Guest is active", + [SEV_RET_HWSEV_RET_PLATFORM] =3D "Hardware error", + [SEV_RET_HWSEV_RET_UNSAFE] =3D "Hardware unsafe", + [SEV_RET_UNSUPPORTED] =3D "Feature not supported", + [SEV_RET_INVALID_PARAM] =3D "Invalid parameter", }; =20 #define SEV_FW_MAX_ERROR ARRAY_SIZE(sev_fw_errlist) --=20 2.30.2 From nobody Mon Feb 9 01:01:07 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619790645; cv=none; d=zohomail.com; s=zohoarc; b=LejImr/sTDds9/uikI+lMCC7xfM/2M0UDkq0ilZyIYkoZ9FeUDJKetqZGcfu1om/5flPpXsweyF0JUyK9piAmxb3Demjr76Y/fSoGjqzTJQRB0ODS0Sx6gtCEFMAFBh1tiLPGO1wMIX2AcOPAOAJJ1r/yKL++wG0SVXj8psKMRg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619790645; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VFI189G+ERaYcl1gELpXtjCqfkKrblNOG0vuU6aoJJ4=; b=UphILuaV2bOYsy2GHLOAuiYt5zwS+FxuxkBjN0YWRVl+GXriTC4JYc201/FnF9LchTPpq7N/tqScAnxS0XMfRBibp3lmEosmg0dmrLkWjZFn8eZ5nxiWV27jgpQOJcn3QZhm/RFTctzQsUlMrP8yENC7Yq0lAd4ltLDMN4KYLE4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1619790645350188.3832308503122; Fri, 30 Apr 2021 06:50:45 -0700 (PDT) Received: from localhost ([::1]:37938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcTXY-0005ud-2U for importer@patchew.org; Fri, 30 Apr 2021 09:50:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47752) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcTVX-0004GZ-TK for qemu-devel@nongnu.org; Fri, 30 Apr 2021 09:48:39 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:22808) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcTVV-0007NK-7V for qemu-devel@nongnu.org; Fri, 30 Apr 2021 09:48:39 -0400 Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-593-rHahWC6HPxSSvsEDu6vxuQ-1; Fri, 30 Apr 2021 09:48:35 -0400 Received: by mail-ot1-f72.google.com with SMTP id f89-20020a9d2c620000b0290280d753a255so30027047otb.2 for ; Fri, 30 Apr 2021 06:48:35 -0700 (PDT) Received: from redhat.redhat.com (ip68-103-222-6.ks.ok.cox.net. [68.103.222.6]) by smtp.gmail.com with ESMTPSA id p127sm799072oig.16.2021.04.30.06.48.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Apr 2021 06:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619790516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VFI189G+ERaYcl1gELpXtjCqfkKrblNOG0vuU6aoJJ4=; b=KY3WglKvPmm4C/zLVTbn99op5UMx5av1gXuDtwNl2dyynfJKOtVGvUmGKgsmLSv2JUjXvf MaKaa8YpUw1ed5vDdGHAtAngwRSfE08JjdCv31Y1ry+KNY2HSDsJlBOrO0Lhd6cMv6rD0g 5DqidHbFzfZzkH1HfRGyJQ7dfqfoJXg= X-MC-Unique: rHahWC6HPxSSvsEDu6vxuQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VFI189G+ERaYcl1gELpXtjCqfkKrblNOG0vuU6aoJJ4=; b=lSDsmYqrl52TUBJVsjycbaT30zF1CZFeDbkJO5NJuEkfq34rpsTsd4bO0F1h2cczpD bd213s3vGX6infPMB1FvQy+v3ow6aMo54b7uY9vwQzqP/D6TzDc7mVQeYTn+p17xJ89d M5fLyxq+fJbAh8VTDk2dzr6gUVmAwd6R7hN4Myvp2g01SxfF+dDML0gL4R9sl4cuAn/T OJQWfgoUefhTzvsA9dSjHGwj1wVqRf2h9XGELB+5InM32w8JB2jy4GVy2dk3e2RIKG7Y N2M3UBVnmgo5Ayr7pnKf44NAeaAbmzIWZ1iyLofrk4Rwlxw986BMw1IG6eq5kuCAo6gG OSDw== X-Gm-Message-State: AOAM532SpwiOuohChdvFyVkl15cUeu9i8LSPxaCyLHyzk0G6viKt4ADq W1EKaOkEY5LmH4DX37hG47Iy/sNpihN2VmMIdO0xXyjlgI8KZKSEdxfqxpXXsa8G4WYeixyewTe WSWOzQi0EgHrUwT8mYcRX1gnG+0raOIzsA7UmBzgo44J3qqzDYWIMQI6Qdcw5WM7s X-Received: by 2002:aca:5c44:: with SMTP id q65mr3964166oib.12.1619790514239; Fri, 30 Apr 2021 06:48:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhwHEDN4WonWcs7ed8XmlzJkmYknfOhUyw08LfGfQcYhEM4I13oFORltyiVRq1Ud20VfuyjA== X-Received: by 2002:aca:5c44:: with SMTP id q65mr3964151oib.12.1619790514081; Fri, 30 Apr 2021 06:48:34 -0700 (PDT) From: Connor Kuehl To: qemu-devel@nongnu.org Subject: [PATCH 2/2] [RESEND] sev: add missing firmware error conditions Date: Fri, 30 Apr 2021 08:48:30 -0500 Message-Id: <20210430134830.254741-3-ckuehl@redhat.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210430134830.254741-1-ckuehl@redhat.com> References: <20210430134830.254741-1-ckuehl@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ckuehl@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=ckuehl@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.22, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thomas.lendacky@amd.com, brijesh.singh@amd.com, ehabkost@redhat.com, richard.henderson@linaro.org, pbonzini@redhat.com, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) The SEV userspace header[1] exports a couple of other error conditions that aren't listed in QEMU's SEV implementation, so let's just round out the list. [1] linux-headers/linux/psp-sev.h Signed-off-by: Connor Kuehl Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/sev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/sev.c b/target/i386/sev.c index 9e2e47012f..dfafd3b543 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -111,6 +111,8 @@ static const char *const sev_fw_errlist[] =3D { [SEV_RET_HWSEV_RET_UNSAFE] =3D "Hardware unsafe", [SEV_RET_UNSUPPORTED] =3D "Feature not supported", [SEV_RET_INVALID_PARAM] =3D "Invalid parameter", + [SEV_RET_RESOURCE_LIMIT] =3D "Required firmware resource deple= ted", + [SEV_RET_SECURE_DATA_INVALID] =3D "Part-specific integrity check fa= ilure", }; =20 #define SEV_FW_MAX_ERROR ARRAY_SIZE(sev_fw_errlist) --=20 2.30.2