From nobody Mon Feb 9 09:33:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619614278; cv=none; d=zohomail.com; s=zohoarc; b=L88gnOru/mZioRyTGcTIwbciI9btoCljlBK0u8VBgI8Wc4fkwaLybSy9J1yxJNHmyPXsgdYFpUVEYoffz+yfdI9KvxCJwclO+mOLoQ9z0z0qMAxZZ/A43c2CYybK+oDHutfoQj5X9fbecteHRSr2rx+xPwosmYbu4DXdTTmds7g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619614278; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=rszJafCnyNWycC3JCo6/5f7yLN9qGaXOTFl5n8p392I=; b=Rq6zr6W7l4LdRD0i48yR/2n8i4Y32Cx3QjcUwkyFI/+qSz1jwNg/u1rJkkl4NlKwA3Vocx7IIydDwmFHpMgt2l9nLZT16GwXkwqh6BdpEjULJdEdCEzwa7nQV/85wLpOsWnkrkLI2COCBPFGWB2FEX1Wkt4yHWDDIjVwMMliEPI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=philmd@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1619614278156939.734463075202; Wed, 28 Apr 2021 05:51:18 -0700 (PDT) Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-ZMZTOhXQMci8OUVSyN-fRQ-1; Wed, 28 Apr 2021 08:51:13 -0400 Received: by mail-wr1-f69.google.com with SMTP id 88-20020adf95610000b029010758d8d7e2so10655268wrs.19 for ; Wed, 28 Apr 2021 05:51:12 -0700 (PDT) Return-Path: Return-Path: Received: from localhost.localdomain (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id j15sm8068534wrt.17.2021.04.28.05.51.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Apr 2021 05:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619614277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rszJafCnyNWycC3JCo6/5f7yLN9qGaXOTFl5n8p392I=; b=Hf8MGBrK9CTP8dt3zP8XaOGLcfCYcuMeOkhIQXw7ZS3cnM2atr/esy0CoCekSJ4wTstZFB c5z45CgWW0266ZtkweZp4VQ64LODI0vvqDPa+JPHJDFQP3EROWoT/ViIzzvCIAg8cd2+QP SkOhwNwYH8c8Lbo6XEWjHHk9GPYmJ4w= X-MC-Unique: ZMZTOhXQMci8OUVSyN-fRQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rszJafCnyNWycC3JCo6/5f7yLN9qGaXOTFl5n8p392I=; b=G8sbhBxtZz3hjBgzSUc6R8am6DzQjROfuScMgg6sGbOrrKi9g3hk6YYirXKrCg3bYP A9UCtovyAsZoAan2tWA6538A7mi8ewSHi3CiKUYgAM6cSCSJcZ6Yg/II9OjyhP39TPFB VAB37NFULHJ6uM55eORCvLVkJm4D6HHHpnU8089zS+YPVQeQASyyjrAOND3BsuDyDT8O ipJaTGD7w8L1N+VQZS72RY6Pid/kt2/ZyaCSu6JNxYz14AmFuQH8yjtcDT06pu9VT6ai RdcZ5klfEzIyhs8y+ga3aTYmTko05USG7y0muca47F1NVgl3ppgMFRIU071UklvujzrI sHUQ== X-Gm-Message-State: AOAM531Re4qxUnGRxfpetIe4TPGX5JqfjR9VC0TUC4Ug6+ajjZxE+FcP vPEendD9uvjI9SoHlz/6vIFLX0JRuNEhcOtTqoYOIKnmXvXvjPWLxjsMU+1kpocnl0ZP7ryFNN1 0gy3vvpxXhm0wrg== X-Received: by 2002:a5d:6145:: with SMTP id y5mr34997522wrt.27.1619614272057; Wed, 28 Apr 2021 05:51:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz61VG118UfSl2+PXbhlQc+4e39CWACMo+zUJ8n8qWW8PaseAF2kXslsRxRixMrlXQFBWJmzg== X-Received: by 2002:a5d:6145:: with SMTP id y5mr34997498wrt.27.1619614271900; Wed, 28 Apr 2021 05:51:11 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: John Snow , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , Artyom Tarasenko , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Jiaxun Yang , qemu-block@nongnu.org, Miroslav Rezanina , Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Kevin Wolf , Max Reitz Subject: [PATCH v2 1/8] hw/block/fdc: Replace disabled fprintf() by trace event Date: Wed, 28 Apr 2021 14:50:57 +0200 Message-Id: <20210428125104.358535-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20210428125104.358535-1-philmd@redhat.com> References: <20210428125104.358535-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Reviewed-by: John Snow Acked-by: Mark Cave-Ayland Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/block/fdc.c | 7 +------ hw/block/trace-events | 1 + 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/block/fdc.c b/hw/block/fdc.c index a825c2acbae..1d3a0473678 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -1242,12 +1242,7 @@ static void fdctrl_external_reset_isa(DeviceState *d) =20 static void fdctrl_handle_tc(void *opaque, int irq, int level) { - //FDCtrl *s =3D opaque; - - if (level) { - // XXX - FLOPPY_DPRINTF("TC pulsed\n"); - } + trace_fdctrl_tc_pulse(level); } =20 /* Change IRQ state */ diff --git a/hw/block/trace-events b/hw/block/trace-events index fa12e3a67a7..306989c193c 100644 --- a/hw/block/trace-events +++ b/hw/block/trace-events @@ -3,6 +3,7 @@ # fdc.c fdc_ioport_read(uint8_t reg, uint8_t value) "read reg 0x%02x val 0x%02x" fdc_ioport_write(uint8_t reg, uint8_t value) "write reg 0x%02x val 0x%02x" +fdctrl_tc_pulse(int level) "TC pulse: %u" =20 # pflash_cfi01.c # pflash_cfi02.c --=20 2.26.3