From nobody Mon Feb 9 20:18:10 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1619531578; cv=none; d=zohomail.com; s=zohoarc; b=MkTiXUp03+z1oaZgeZQ0qZ0W2d+zUkTlbW3CUDJb86Uclwf52dIgqo7RjIZFJUIWXN7IPJp60HJOGdvyRW5drk625Nr/DjqJI9GSu6NUKSMB4hs8NakezZhqNvmvfVy4WbAnnUAz8+SLFLqtnJTxINz2R8aBLTySu7LeiOfi6mw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619531578; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=KemaLIyy+3SsiNvfAJLnHo56H97iPkpiDOSePpunSJY=; b=KNsfRWBFxnBEC4XNadJatpedlVyBZlmqJQfLt/4ruXkmTyHuN4vyC5UhB9G4n5ZppFHAqMNQ5MqgvqMPlCL0LwI5s/G4b4E0p4EPqIpadl8KucmctWOTXpWXpEwyidQAWGm4azk04N+tajcHdmzP/JclZJZERxIDlBV5HGsNyYY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1619531578316863.7362712182659; Tue, 27 Apr 2021 06:52:58 -0700 (PDT) Received: from localhost ([::1]:44110 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbO93-0003Vx-4V for importer@patchew.org; Tue, 27 Apr 2021 09:52:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbO89-000357-9S for qemu-devel@nongnu.org; Tue, 27 Apr 2021 09:52:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44187) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbO87-0006mY-Jo for qemu-devel@nongnu.org; Tue, 27 Apr 2021 09:52:01 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-jo1P6MmjNn2Rx0WcmlQKSg-1; Tue, 27 Apr 2021 09:51:54 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C140280295E for ; Tue, 27 Apr 2021 13:51:53 +0000 (UTC) Received: from thinkpad.redhat.com (ovpn-112-156.ams2.redhat.com [10.36.112.156]) by smtp.corp.redhat.com (Postfix) with ESMTP id B258460CC9; Tue, 27 Apr 2021 13:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619531518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KemaLIyy+3SsiNvfAJLnHo56H97iPkpiDOSePpunSJY=; b=MeBGkbKREm+IZqQUSHrcu8w2pjoUw75WcqkOGbb8w28h/8jbBoj/H8u7QP3uAEJExXZrp2 KsKByAhBwu3jM8huodu4LqvlJKbBsRpJKh0QfbWIJaKBnnoo2D6RJMMZP0JB7AQzeT1HbU FbLS3UL4Y97PZANgl5fFfWY0I9wdnN4= X-MC-Unique: jo1P6MmjNn2Rx0WcmlQKSg-1 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PATCH] virtio-net: failover: add missing remove_migration_state_change_notifier() Date: Tue, 27 Apr 2021 15:51:47 +0200 Message-Id: <20210427135147.111218-1-lvivier@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lvivier@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=lvivier@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.218, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Igor Mammedov , Jason Wang , "Dr . David Alan Gilbert" , "Michael S. Tsirkin" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" In the failover case configuration, virtio_net_device_realize() uses an add_migration_state_change_notifier() to add a state notifier, but this notifier is not removed by the unrealize function when the virtio-net card is unplugged. If the card is unplugged and a migration is started, the notifier is called and as it is not valid anymore QEMU crashes. This patch fixes the problem by adding the remove_migration_state_change_notifier() in virtio_net_device_unrealize(). The problem can be reproduced with: $ qemu-system-x86_64 -enable-kvm -m 1g -M q35 \ -device pcie-root-port,slot=3D4,id=3Droot1 \ -device pcie-root-port,slot=3D5,id=3Droot2 \ -device virtio-net-pci,id=3Dnet1,mac=3D52:54:00:6f:55:cc,failover=3Don,= bus=3Droot1 \ -monitor stdio disk.qcow2 (qemu) device_del net1 (qemu) migrate "exec:gzip -c > STATEFILE.gz" Thread 1 "qemu-system-x86" received signal SIGSEGV, Segmentation fault. 0x0000000000000000 in ?? () (gdb) bt #0 0x0000000000000000 in () #1 0x0000555555d726d7 in notifier_list_notify (...) at .../util/notify.c:39 #2 0x0000555555842c1a in migrate_fd_connect (...) at .../migration/migration.c:3975 #3 0x0000555555950f7d in migration_channel_connect (...) error@entry=3D0x0) at .../migration/channel.c:107 #4 0x0000555555910922 in exec_start_outgoing_migration (...) at .../migration/exec.c:42 Reported-by: Igor Mammedov Signed-off-by: Laurent Vivier Acked-by: Jason Wang Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Michael S. Tsirkin Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 66b9ff451185..914051feb75b 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -3373,6 +3373,7 @@ static void virtio_net_device_unrealize(DeviceState *= dev) =20 if (n->failover) { device_listener_unregister(&n->primary_listener); + remove_migration_state_change_notifier(&n->migration_state); } =20 max_queues =3D n->multiqueue ? n->max_queues : 1; --=20 2.30.2