From nobody Sun Feb 8 05:35:40 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1619507354; cv=none; d=zohomail.com; s=zohoarc; b=CnOZRiZBh0RawDTnnbuzyJBrDuzCoUhhmnxt6uiC0tn76MT0EhpW2VLf8dYvpt7GAWo+B7cBYJYCZ/Ff5msz6rpexRehcOR+DeymUP8w5FvLW3L3zxy9frE5MrbGhaxFV/u7AHcfq7JA/MUUxDj5/7N1d5wemOko0uGe+lbKvKc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619507354; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=owX1dSajuIIOVl4+GXzt2HodR9xCC+UKr/4IiMuHaA0=; b=JFO8gD9VykRvmOWRuqXsImXGcv2rCyrx2dT/wMxf9xaENl+7g0q1QyYKd/dBwloUjak5/hVopujJH9nvK7Cna9T7R+0ub/7UNVhynaz7135F7FEWloUahhwmo5HSsZKHwm5ZmOy+kgQMdoj6kKG3q89X0DhoBFJICmj982VP3bI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1619507354886987.2705497678289; Tue, 27 Apr 2021 00:09:14 -0700 (PDT) Received: from localhost ([::1]:52090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbHqL-0001c5-24 for importer@patchew.org; Tue, 27 Apr 2021 03:09:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbHH7-0006DO-1c; Tue, 27 Apr 2021 02:32:50 -0400 Received: from mta-09-3.privateemail.com ([68.65.122.19]:13991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbHH1-0006o4-G5; Tue, 27 Apr 2021 02:32:48 -0400 Received: from MTA-09.privateemail.com (localhost [127.0.0.1]) by MTA-09.privateemail.com (Postfix) with ESMTP id 8DC4B60104; Tue, 27 Apr 2021 02:32:32 -0400 (EDT) Received: from hal-station.. (unknown [10.20.151.204]) by MTA-09.privateemail.com (Postfix) with ESMTPA id 10A1160076; Tue, 27 Apr 2021 02:32:31 -0400 (EDT) From: effective-light To: qemu-devel@nongnu.org Subject: [PATCH] linux-user: make process_pending_signals thread-safe Date: Tue, 27 Apr 2021 02:32:17 -0400 Message-Id: <20210427063217.60753-1-someguy@effective-light.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: ClamAV using ClamSMTP Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=68.65.122.19; envelope-from=someguy@effective-light.com; helo=MTA-09-3.privateemail.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 27 Apr 2021 03:07:59 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, laurent@vivier.eu, effective-light Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Use pthread_sigmask instead of sigprocmask inside process_pending_signals to ensure that race conditions aren't possible. Signed-off-by: Hamza Mahfooz --- linux-user/signal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 7eecec46c4..81ff753c01 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -1005,9 +1005,8 @@ void process_pending_signals(CPUArchState *cpu_env) sigset_t *blocked_set; =20 while (qatomic_read(&ts->signal_pending)) { - /* FIXME: This is not threadsafe. */ sigfillset(&set); - sigprocmask(SIG_SETMASK, &set, 0); + pthread_sigmask(SIG_SETMASK, &set, 0); =20 restart_scan: sig =3D ts->sync_signal.pending; --=20 2.31.1