From nobody Mon Feb 9 17:41:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1619442647; cv=none; d=zohomail.com; s=zohoarc; b=FxxV7HcCrTZk8CqYzS3U5zO7tAiQgNeuiUc7/9Gvqi41vy8QOcI9xQTkjfS6ibon2ftUO/1113/Z70/vefu4zvA5UAavLiq5X0z0GJav37/WrCczt1qVlgZhw+S6ZRBJ+6v05Hmn7imfdkoVAQBembfgpmq0/jEvpyvrQVt+f0U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619442647; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=NpEEoWTMTHK89KjdPj2lo9Ub4b6fFrxyZ/gpr6UgFKM=; b=IGyJzWnYaKexC76CnkATFtuDeIdSkz/f73gOFD1weS3JvRqRD7uijPAmBYWxXoMUEgs847XLp5oXNxnhnlNni0AqYs3TJQaCsFODyn0XqbH0x7jeIs6qlBo10crJNk0zmUbGYM7GnI+PkwdGqWJrxGNeXA0bczPtX12ZBwUo1FY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1619442647309971.5238442848892; Mon, 26 Apr 2021 06:10:47 -0700 (PDT) Received: from localhost ([::1]:34106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb10a-000050-FZ for importer@patchew.org; Mon, 26 Apr 2021 09:10:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36458) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laulF-0004va-6b; Mon, 26 Apr 2021 02:30:28 -0400 Received: from mga07.intel.com ([134.134.136.100]:63423) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laulB-0007xK-6Q; Mon, 26 Apr 2021 02:30:24 -0400 Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2021 23:30:06 -0700 Received: from duan-optiplex-7080.bj.intel.com ([10.238.156.114]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2021 23:30:05 -0700 IronPort-SDR: 0VQnWplUhKdcBxraKGIz+dc89vL8s7r9Krgs9GRwjyQXdxqLugkaALEg2lMnR+ynKRLxFg5p18 ENEu4JxoZncw== X-IronPort-AV: E=McAfee;i="6200,9189,9965"; a="260240567" X-IronPort-AV: E=Sophos;i="5.82,251,1613462400"; d="scan'208";a="260240567" IronPort-SDR: AkVlfQ4N4YI3SAok1heT26gTzJ9I0Q1ZPNjLzbTtvrLmq96LDme3WI3tSInu0yxB4Rm93tA0Fv cuPHhWETssGA== X-IronPort-AV: E=Sophos;i="5.82,251,1613462400"; d="scan'208";a="429264602" From: Zhenzhong Duan To: qemu-devel@nongnu.org Subject: [PATCH] cutils: Fix memleak in get_relocated_path() Date: Tue, 27 Apr 2021 06:30:42 +0800 Message-Id: <20210426223042.119554-1-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=134.134.136.100; envelope-from=zhenzhong.duan@intel.com; helo=mga07.intel.com X-Spam_score_int: -9 X-Spam_score: -1.0 X-Spam_bar: - X-Spam_report: (-1.0 / 5.0 requ) BAYES_00=-1.9, DATE_IN_FUTURE_12_24=3.199, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 26 Apr 2021 09:08:51 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, Zhenzhong Duan Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Valgrind complains definitely loss in get_relocated_path(), because GString is leaked in get_relocated_path() when returning with gchar *. Use g_string_free(, false) to free GString while preserving gchar *. Signed-off-by: Zhenzhong Duan --- util/cutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/cutils.c b/util/cutils.c index ee908486da..f58c2157d2 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -1055,5 +1055,5 @@ char *get_relocated_path(const char *dir) assert(G_IS_DIR_SEPARATOR(dir[-1])); g_string_append(result, dir - 1); } - return result->str; + return g_string_free(result, FALSE); } --=20 2.25.1