From nobody Mon Feb 9 14:34:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1619374888; cv=none; d=zohomail.com; s=zohoarc; b=EiRFvd00Oc70wf27OnixoKksqnbWfYiE+zlylEk8XplhZRqmaXE1nrXfgfH0GDz7PYey2/ctKDsfCFJZwlHvTtTwhIbzHAS1EWFynlJF7QnwuJUyMOheOzb1rp4TKUe2FzBs9M7hSyyyoJaSSn5o0Ri8aFdZfHrEufjmewZiyI0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619374888; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Sender:Subject:To; bh=+qXnCeZ8SXvCXhTdH8MnT6llOvMv70z+YtJ8m7AeDwQ=; b=LTzN7CrlDbBmQrQ6SxFUmEkM6NCIXiWbpzZJev0Bpqw89xQffrWAVr3UNcPhw3mqbkFxa1vKMQmIQBuUzPnOwFSxEO9NgxqVWsmZ9bZcQAf5TvtRf5QwgYckvI9/+Wk9wCi2Yqv2cFOhaoLPPDXcMfl9I/hCiwxjo1TeqVd5ncE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 1619374888280686.7048449260616; Sun, 25 Apr 2021 11:21:28 -0700 (PDT) Received: by mail-wm1-f46.google.com with SMTP id y204so27341466wmg.2 for ; Sun, 25 Apr 2021 11:21:27 -0700 (PDT) Return-Path: Return-Path: Received: from x1w.redhat.com (39.red-81-40-121.staticip.rima-tde.net. [81.40.121.39]) by smtp.gmail.com with ESMTPSA id q128sm2336043wma.39.2021.04.25.11.21.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Apr 2021 11:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+qXnCeZ8SXvCXhTdH8MnT6llOvMv70z+YtJ8m7AeDwQ=; b=Bl244YUIvOW91J2wpXygXvSlAx/s22x/LBkZjXkj33N7Jdh76pf8V2tzYAvs9Qpc6f wb0NcLTKcDaCbmpZZc5HedNIRQxaYKzq/7btCtBtlOnDnrMKCBLB44dVcAGbxNqUANzL yGbIB7AKL07F57f2jZaGSbiney+jqRxucm1IlPn/rfvzNT1w7rn1qGvuGJ4cgkqY0KId YVugytDpMTe7abQa+ck1wzuYltIKlg8VyPTV7fKgHX8HhPzURJaR9aYCYFKe7ruyfeHX k8z1zIUHQMcXwNgfmUNgEGS3nAz+lbHRCibKa8LIugIsjVt6dlJEF+xYl/baPSYfxZP5 TqLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=+qXnCeZ8SXvCXhTdH8MnT6llOvMv70z+YtJ8m7AeDwQ=; b=qTBgbFWfhWwa0InlgywVONG1HoFPX3RbMT0tdMDDs4Ucv5Ezy3CmtUvc22IF6rgOjQ mSMluGjbcUQHdBDWSlID5gqiP1VtH02+bM5nwTkJqbyO9n9c8tktAwfHgK9F8hrPZAxx We0/RZHJmUnXCH8mT3r+AtV/yDczDeCHJ+OLX+j78MFs60ZfloKO9awmj+2kBsQtDWW/ YNMW0tLqLo/kCnJpAo1LGEI1XY9NuLKYCIVktzOA84/JMm+rG7n/bSiziev9WE1GV6P6 qX+qW1I12p/QGvqNWvZ3q7NBQYz1Ar62kOsfYDZBLri5RWpDNOB+5NXnw7zG0EQ+8m54 H5VA== X-Gm-Message-State: AOAM5330+2lG5fD6oOIPOh2OE9um9UYEGTT6P+RgkFtp3lirFxxG0Lpr wStgtqO5uAWeifr2iGJKrCE= X-Google-Smtp-Source: ABdhPJy3jKjtDXLVtsnyoKdd1qLjqsD8TKPN/w+iAc19/LFwE2HpnaU8H1sPVNFXbHAb7kwBo2Hmqw== X-Received: by 2002:a7b:cd85:: with SMTP id y5mr16658325wmj.93.1619374886586; Sun, 25 Apr 2021 11:21:26 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Igor Mammedov , "Michael S . Tsirkin" , Jiahui Cen , Gerd Hoffmann , Thomas Huth , Xingang Wang , Yubo Miao , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] hw/pci-host: Do not build gpex-acpi.c if GPEX is not selected Date: Sun, 25 Apr 2021 20:21:24 +0200 Message-Id: <20210425182124.3735214-1-f4bug@amsat.org> X-Mailer: git-send-email 2.26.3 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Since its introduction in commit 5b85eabe68f ("acpi: add acpi_dsdt_add_gpex") we build gpex-acpi.c if ACPI is selected, even if the GPEX_HOST device isn't build. Add the missing Kconfig dependency. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: Gerd Hoffmann --- The gpex*.c files aren't covered by any MAINTAINERS section: $ ./scripts/get_maintainer.pl -f hw/pci-host/gpex.c -f hw/pci-host/gpex-acp= i.c get_maintainer.pl: No maintainers found, printing recent contributors. get_maintainer.pl: Do not blindly cc: them on patches! Use common sense. Markus Armbruster (commit_signer:2/2=3D100%) Paolo Bonzini (commit_signer:2/2=3D100%) Alistair Francis (commit_signer:1/2=3D50%) "Philippe Mathieu-Daud=C3=A9" (commit_signer:1/2=3D50%) "Michael S. Tsirkin" (commit_signer:14/8=3D100%) Jiahui Cen (commit_signer:6/8=3D75%) Igor Mammedov (commit_signer:4/8=3D50%) Gerd Hoffmann (commit_signer:2/8=3D25%) Yubo Miao (commit_signer:2/8=3D25%) qemu-devel@nongnu.org (open list:All patches CC here) --- hw/pci-host/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/meson.build b/hw/pci-host/meson.build index 87a896973e7..d52dce77cbd 100644 --- a/hw/pci-host/meson.build +++ b/hw/pci-host/meson.build @@ -3,7 +3,7 @@ pci_ss.add(when: 'CONFIG_PCI_BONITO', if_true: files('bonito.c')) pci_ss.add(when: 'CONFIG_PCI_EXPRESS_DESIGNWARE', if_true: files('designwa= re.c')) pci_ss.add(when: 'CONFIG_PCI_EXPRESS_GENERIC_BRIDGE', if_true: files('gpex= .c')) -pci_ss.add(when: 'CONFIG_ACPI', if_true: files('gpex-acpi.c')) +pci_ss.add(when: ['CONFIG_PCI_EXPRESS_GENERIC_BRIDGE', 'CONFIG_ACPI'], if_= true: files('gpex-acpi.c')) pci_ss.add(when: 'CONFIG_PCI_EXPRESS_Q35', if_true: files('q35.c')) pci_ss.add(when: 'CONFIG_PCI_EXPRESS_XILINX', if_true: files('xilinx-pcie.= c')) pci_ss.add(when: 'CONFIG_PCI_I440FX', if_true: files('i440fx.c')) --=20 2.26.3